From: Dominik Honnef <dominik@honnef.co>
To: 66719@debbugs.gnu.org
Subject: bug#66719: mark-defun doesn't like function literals / the need for treesit-mark-defun
Date: Mon, 23 Oct 2023 22:59:35 +0200 [thread overview]
Message-ID: <8734y1m4w8.fsf@honnef.co> (raw)
treesit.el currently defines treesit-beginning-of-defun and
treesit-end-of-defun, and binds C-M-a and C-M-e to them in addition to
setting beginning-of-defun-function and end-of-defun-function.
That way, C-M-a and C-M-e work well even for function literals, which do
not necessarily start and end on their own, dedicated lines. This
differs from beginning-of-defun, which always goes to the beginning
of the line.
The problem is that there is no treesit-mark-defun, and mark-defun calls
beginning-of-defun, via beginning-of-defun-comments. Thus, mark-defun
will mark more than the actual function literal. For example, in Go,
given
// some comment
someCall(func() {
...
})
and a major mode that sets
(setq-local treesit-defun-type-regexp (rx (or "function_declaration" "func_literal")))
(setq-local end-of-defun-moves-to-eol nil)
mark-defun will also mark the call to someCall, and the comment above
it, while it should only mark the function literal.
Adding treesit-mark-defun would be a quick fix for the interactive use
case. However, this problem probably affects other functions that call
beginning-of-defun, or ones that build on top of mark-defun. I am not
sure how to address that, considering moving to the beginning of the
line is part of the contract of beginning-of-defun.
next reply other threads:[~2023-10-23 20:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 20:59 Dominik Honnef [this message]
2023-10-24 10:56 ` bug#66719: mark-defun doesn't like function literals / the need for treesit-mark-defun Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734y1m4w8.fsf@honnef.co \
--to=dominik@honnef.co \
--cc=66719@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.