From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 66902@debbugs.gnu.org
Subject: bug#66902: 30.0.50; Recognize env -S/--split-string in shebangs
Date: Sat, 18 Nov 2023 11:31:29 +0100 [thread overview]
Message-ID: <8734x3cpz2.fsf@gmail.com> (raw)
In-Reply-To: <83ttpjmm8v.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 18 Nov 2023 11:41:52 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Kévin Le Gouguec <kevin.legouguec@gmail.com>
>> Date: Sun, 12 Nov 2023 18:53:40 +0100
>>
>> > 3. Assuming we do want to amend that regexp, would it be possible to use
>> > rx here? OT1H guessing "no" because files.el is pre-reloaded, whereas
>> > rx.el is not; OTOH I see that files.el requires easy-mmode at
>> > compile-time, and that package does not show up in loadup.el, so…
>> > settling for "maybe?"
>>
>> Figured rx was similar to pcase in that regard:
>>
>> * They need to be required explicitly despite their macros being
>> "autoloaded", because files.el is loaded during bootstrap before
>> autoloading is set up.
>>
>> * Somehow that does not cause them to be preloaded? At least going by
>> emacs -Q,
>> * featurep returns nil,
>> * preloaded-file-list does not include them.
>
> I'd prefer not to have rx required in files.el, so could you please
> rewrite those parts of your patch and resubmit? Also, please add a
> NEWS entry about the change.
ACK; will get to it in the coming days.
> I think otherwise your patch is ready to
> go in.
>
> Thanks.
Thank you for the review!
next prev parent reply other threads:[~2023-11-18 10:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-02 20:57 bug#66902: 30.0.50; Recognize env -S/--split-string in shebangs Kévin Le Gouguec
2023-11-12 17:53 ` Kévin Le Gouguec
2023-11-18 9:41 ` Eli Zaretskii
2023-11-18 10:31 ` Kévin Le Gouguec [this message]
2023-11-18 17:44 ` Kévin Le Gouguec
2023-11-19 9:09 ` Eli Zaretskii
2023-11-19 10:51 ` Kévin Le Gouguec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734x3cpz2.fsf@gmail.com \
--to=kevin.legouguec@gmail.com \
--cc=66902@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.