From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Thierry Volpiatto <thievol@posteo.net>
Newsgroups: gmane.emacs.bugs
Subject: bug#66394: 29.1; Make register-read-with-preview more useful
Date: Wed, 29 Nov 2023 18:18:40 +0000
Message-ID: <8734wov2wv.fsf@posteo.net>
References: <87il7ib6cu.fsf@posteo.net> <8734y5vnj7.fsf@posteo.net>
 <87bkcslr18.fsf@web.de> <87y1fwtyrl.fsf@posteo.net>
 <87y1fut1wp.fsf@web.de> <87ttqgpjiz.fsf@posteo.net>
 <87wmvbibpr.fsf@web.de> <877cnb2n63.fsf@posteo.net>
 <8734xyc8z0.fsf@web.de> <87zg05rewi.fsf@posteo.net>
 <87ttqcg8gw.fsf@web.de> <87h6mcr8ol.fsf@posteo.net>
 <87r0l73029.fsf@web.de> <877cmdx8ud.fsf@posteo.net>
 <jwvjzqcxrnq.fsf-monnier+emacs@gnu.org> <87sf50s1gh.fsf@posteo.net>
 <83o7ficesp.fsf@gnu.org> <878r6leh9d.fsf@posteo.net>
 <83il5pbnmh.fsf@gnu.org> <87zfz1cz7s.fsf@posteo.net>
 <83bkbc7j1o.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="39224"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: michael_heerdegen@web.de, 66394@debbugs.gnu.org, monnier@iro.umontreal.ca,
 stefankangas@gmail.com
To: Eli Zaretskii <eliz@gnu.org>
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 29 19:20:25 2023
Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>
Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>)
	id 1r8PAe-0009xo-O2
	for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Nov 2023 19:20:24 +0100
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <bug-gnu-emacs-bounces@gnu.org>)
	id 1r8PAM-0004cm-Bu; Wed, 29 Nov 2023 13:20:06 -0500
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1r8PAC-0004Z3-TR
 for bug-gnu-emacs@gnu.org; Wed, 29 Nov 2023 13:20:03 -0500
Original-Received: from debbugs.gnu.org ([2001:470:142:5::43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1r8PAB-00022i-2b
 for bug-gnu-emacs@gnu.org; Wed, 29 Nov 2023 13:19:56 -0500
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1r8PAI-0003Vx-F1
 for bug-gnu-emacs@gnu.org; Wed, 29 Nov 2023 13:20:02 -0500
X-Loop: help-debbugs@gnu.org
Resent-From: Thierry Volpiatto <thievol@posteo.net>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Wed, 29 Nov 2023 18:20:02 +0000
Resent-Message-ID: <handler.66394.B66394.170128194913425@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 66394
X-GNU-PR-Package: emacs
Original-Received: via spool by 66394-submit@debbugs.gnu.org id=B66394.170128194913425
 (code B ref 66394); Wed, 29 Nov 2023 18:20:02 +0000
Original-Received: (at 66394) by debbugs.gnu.org; 29 Nov 2023 18:19:09 +0000
Original-Received: from localhost ([127.0.0.1]:51095 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1r8P9Q-0003UT-TR
 for submit@debbugs.gnu.org; Wed, 29 Nov 2023 13:19:09 -0500
Original-Received: from mout02.posteo.de ([185.67.36.66]:56285)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <thievol@posteo.net>) id 1r8P9O-0003Tz-DB
 for 66394@debbugs.gnu.org; Wed, 29 Nov 2023 13:19:07 -0500
Original-Received: from submission (posteo.de [185.67.36.169]) 
 by mout02.posteo.de (Postfix) with ESMTPS id 24A04240103
 for <66394@debbugs.gnu.org>; Wed, 29 Nov 2023 19:18:53 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1701281933; bh=sb9lm94GFg5U6Jr66H2LHfhpV/Ayr9fT8dzL7dtSIOw=;
 h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Autocrypt:OpenPGP:
 From;
 b=XyHDcj+UJi4E5PK3Rv2ass0OpqcHsvi6c6eDFHZIlBfzuymwGVLL3UbMmx5eYYKWi
 aQy5MnHbLBQ0lFMY79nU36Vu6gRi6UrYH4lLKdN05z0UTWu4ER4rdYC7egJCg5D/gH
 0RPg5ka6kZpTMvQXb90yH0Qre4H1QMaxxItOCpR9UD/BYeprbCySjUd9x5KaWhEx23
 67sM0IhrpmmsXPbnt96ngIEt7fMCHPNdHWUzWzW6iOXHTcgLWN0ZvhdGOGRYZOthfe
 /2WP1m9B/aARnF4StbkCoy27oBo49F1FlSfMfIJXRfwNQtII8+BKQ8iG/OLn9mHK7b
 KJFmdKniB0hfg==
Original-Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4SgSJ56CH9z6tsj;
 Wed, 29 Nov 2023 19:18:45 +0100 (CET)
In-Reply-To: <83bkbc7j1o.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 29 Nov
 2023 16:04:03 +0200 (4 hours, 1 minute, 26 seconds ago)")
Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual;
 keydata=xsDNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA
 edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p
 kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb
 tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ
 GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC
 WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha
 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA
 Ac0SdGhpZXZvbEBwb3N0ZW8ubmV0wsEOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA
 FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8h
 Bp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslx
 hU46VSz1Z83NwIG3mpdYNV5WUTUdgzxExHTNTFCd7NKv0nlHKQaA 
OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
 the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.bugs:275253
Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/275253>

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Thierry Volpiatto <thievol@posteo.net>
>> Cc: monnier@iro.umontreal.ca,  michael_heerdegen@web.de,
>>   stefankangas@gmail.com,  66394@debbugs.gnu.org
>> Date: Sat, 25 Nov 2023 21:14:31 +0000
>>=20
>> Here a patch with the change suggested by Stefan applied, slighly
>> modified though because it fails if I put the call to
>> cl--generic-prefill-dispatchers at the recommended place.
>>=20
>> I recompiled Emacs with this patch with no errors.
>
> Thanks, installed on master.

Thanks.

> The response "a" to the "Point to register:" question is something I
> needed to type;

Of course we are using now read-from-minibuffer and the test is related
to read-key not quitting with C-g

> previously the test never asked any questions (and it shouldn't,
> AFAIU).

Yes, it shouldn't, but now we are using a real minibuffer, is this test
really needed?
It is like if you had to make tests in all functions using
read-from-minibuffer to check if it quit properly with C-g (it does of cour=
se).

> Could you please see if the test suite needs some adaptations to these
> changes?

If you really need this test, it needs a complete rewrite.

ALSO: I intentionally leave register-preview-delay defcustom with a FIXME
comment, do you want to remove it? It is not used anymore now AFAIK.

Thanks.

=2D-=20
Thierry

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmVngIATHHRoaWV2b2xA
cG9zdGVvLm5ldAAKCRAOxW0UHRbvk/pwC/9TNXjnt45y2PkCZMvmj5zIFTYflGrZ
xMiOdlCak2jDxMkERRwzAOByNwAu0bsD/3cLJpgOJsAKOg/nqmvWhWIyA4363wbq
Wrax5Pyhk2UfsCFGh5Ti5nEhyfUj7sEPrPNu5Aw7uMFsZxeHie7oD6/ATT/WR7ir
s5jHhfiVANrIrQAMJ7K7bEACOrjQ//liQXOfMORAuINGP7+f+IfqQ9pYyrZho/A9
HcWn7a3cPkIBPJ+VxXxcQ9llczfJDWNU+cbZala9CHO2TAzFHlMM55OsHIFHArM1
uwagwqwQ5vz1Ku/Q3kynZJdCyx2m0AgJWWTF+vzVMEDnzFjI4phGwJPE7WBBDuT0
OJQ/Wc25zqIBKa3bk7aXONqVfqbxA/pJhy8udD4tBjIspJv2Okpchpz4f2j7sSJK
6vbUcAJ00iV0uj4sMURr3l2mR4D+WTN2sHbWtgdMDXpjEduCiC7f3BRzx3kJxHXV
X16FCWvH5Y/35m0WwY+RMF2ZtZAGyEZ11cY=
=sxPD
-----END PGP SIGNATURE-----
--=-=-=--