From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Rahguzar Newsgroups: gmane.emacs.devel Subject: Re: master 84e4bc6219a 1/2: Add input methods for Urdu, Pashto and Sindhi (bug#66470) Date: Sat, 20 Jan 2024 12:30:20 +0100 Message-ID: <8734uss0jj.fsf@zohomail.eu> References: <170030013667.20571.18090141972402319489@vcs2.savannah.gnu.org> <20231118093537.9F147C0C994@vcs2.savannah.gnu.org> <87a5p1679r.fsf@gmx.de> <83a5p0til9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30596"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.10.5; emacs 29.1.90 Cc: Michael Albinus , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 20 12:53:09 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rR9uP-0007jL-4e for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Jan 2024 12:53:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rR9td-0002Sg-3E; Sat, 20 Jan 2024 06:52:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rR9aN-0004RK-Q0 for emacs-devel@gnu.org; Sat, 20 Jan 2024 06:32:27 -0500 Original-Received: from sender11-pp-o91.zoho.eu ([31.186.226.249]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rR9aM-00083Q-2N; Sat, 20 Jan 2024 06:32:27 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1705750341; cv=none; d=zohomail.eu; s=zohoarc; b=VGuESyJYD7n8fTtIuvrDn3OiDgbSFebm2aluifFhyIJaOyzysiM9tVlutq3JXghQq/iG6Fbw8FAUpLZMdPM7iYRrcNaZWTxIOOkgbwIHHjk5WyKl+rH9dkln2cYopj+752xmNWEquUhR2+b2FtHCSykFx1axhrICsUuz0UQ76V8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1705750341; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=Bjco1/YRuxN1vFsHyAPpqZuBztab+BNORRFllQmYYas=; b=BBUA+aJWOj/QT+D/EKCFO7zNkvLHUHXrNVmPjc5BPFmq4ypPXZoTBcgsv2+iHxGTsisr/cqH/4J11sdGI3Ew41Y7o4+oEthLwRs7jlIY81vGPceWlbSs86OCVW9IhEp6OORWTaTlHMHN0mAG7kRk8haSgZW5B7EelOpaS+Xvs3k= ARC-Authentication-Results: i=1; mx.zohomail.eu; dkim=pass header.i=zohomail.eu; spf=pass smtp.mailfrom=rahguzar@zohomail.eu; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1705750341; s=zoho; d=zohomail.eu; i=rahguzar@zohomail.eu; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To; bh=Bjco1/YRuxN1vFsHyAPpqZuBztab+BNORRFllQmYYas=; b=eLOlMueZWzsVnetiHoHHq88i2UDnloQW+6PWjvlKLS+slAGDP5mjsJ1YmRXc0f1R GTf8OrBmoELupbHnMhx4kg73pVICEpstg+QHVNVoHujzVMXAXz9juGQYdo/wSeiMuZO xLUX/MfywoTgoHQRTyVcsKsRes3CpiWhuPM0dhQk= Original-Received: from localhost (78-73-246-128-no600.tbcn.telia.com [78.73.246.128]) by mx.zoho.eu with SMTPS id 1705750337932855.3729639379471; Sat, 20 Jan 2024 12:32:17 +0100 (CET) In-reply-to: <83a5p0til9.fsf@gnu.org> X-ZohoMailClient: External Received-SPF: pass client-ip=31.186.226.249; envelope-from=rahguzar@zohomail.eu; helo=sender11-pp-o91.zoho.eu X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 20 Jan 2024 06:52:11 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:315138 Archived-At: Actually can be it be because `leim-list.el` needs to be updated with call to `register-input-method` for the input methods in pakistan.el? Rahguzar Eli Zaretskii writes: >> From: Michael Albinus >> Cc: Rahguzar >> Date: Fri, 19 Jan 2024 09:45:36 +0100 >> >> Eli Zaretskii writes: >> >> > branch: master >> > commit 84e4bc6219af2c08097027d4b75043b23c1fcce6 >> > Author: Rahguzar >> > Commit: Eli Zaretskii >> > >> > Add input methods for Urdu, Pashto and Sindhi (bug#66470) >> >> This commit has added the following error in Emacs' tests: >> >> --8<---------------cut here---------------start------------->8--- >> # make -C test test-custom-deps >> The following load problems appeared: >> (pakistan-urdu-input pakistan (file-missing Cannot open load file No such file or directory pakistan)) >> (quail pakistan (file-missing Cannot open load file No such file or directory pakistan)) >> Test test-custom-deps backtrace: >> signal(ert-test-failed (((should-not cus-test-deps-errors) :form cus >> ert-fail(((should-not cus-test-deps-errors) :form cus-test-deps-erro >> (if (not (unwind-protect (setq value-5 cus-test-deps-errors) (setq f >> (let (form-description-6) (if (not (unwind-protect (setq value-5 cus >> (let ((value-5 (gensym "ert-form-evaluation-aborted-"))) (let (form- >> (closure (cus-test-deps-errors t) nil (let* ((fn-0 #'file-readable-p >> ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test >> ert-run-test(#s(ert-test :name test-custom-deps :documentation nil : >> ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m >> ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil >> ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) >> ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco >> eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n >> command-line-1(("-L" ":." "-l" "ert" "-l" "misc/test-custom-deps.el" >> command-line() >> normal-top-level() >> Test test-custom-deps condition: >> (ert-test-failed >> ((should-not cus-test-deps-errors) :form cus-test-deps-errors :value >> ((pakistan-urdu-input pakistan >> (file-missing "Cannot open load file" >> "No such file or directory" >> "pakistan")) >> (quail pakistan >> (file-missing "Cannot open load file" >> "No such file or directory" "pakistan"))))) >> FAILED 1/1 test-custom-deps (40.411856 sec) at misc/test-custom-deps.el:35 >> >> Ran 1 tests, 0 results as expected, 1 unexpected (2024-01-18 21:00:25+0100, 41.295278 sec) >> >> 1 unexpected results: >> FAILED test-custom-deps >> --8<---------------cut here---------------end--------------->8--- > > I tried to look into this. It seems test-custom-deps runs > cus-test-deps and then requires that cus-test-deps-errors is nil. I > therefore ran cus-test-deps interactively, and looked at > cus-test-deps-errors. It is not nil, but its value is > > ((org-babel ob-vala (file-missing "Cannot open load file" "No such file or directory" "ob-vala")) (org-babel ob-stan (file-missing "Cannot open load file" "No > such file or directory" "ob-stan")) (org-babel ob-picolisp (file-missing "Cannot open load file" "No such file or directory" "ob-picolisp")) (org-babel ob-J > (file-missing "Cannot open load file" "No such file or directory" "ob-J"))) > > which doesn't mention pakistan at all. > > So I'm unsure how to proceed. It would be useful to see the value of > cus-test-deps-errors in the test that fails, or maybe I'm missing > something in how this test should be run interactively. > > P.S. My guess is that some autoload is missing from pakistan.el, but > without reproducing the problem I cannot verify that and cannot test a > solution, and the error message from the failing test is not helpful, > as it doesn't divulge the important details.