From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#69237: 30.0.50; Toggle password visibility Date: Sun, 25 Feb 2024 13:34:26 +0000 Message-ID: <8734tgk6ql.fsf@gmail.com> References: <87zfw0ttyp.fsf@gmx.de> <87h6i0xhbb.fsf@gmail.com> <8734tjrxt6.fsf@gmx.de> <87v86f86g8.fsf@gmail.com> <87frxgvrh4.fsf@gmx.de> <87o7c4yfzj.fsf@gmail.com> <877cisvl8s.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8379"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 69237-done@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 25 14:37:08 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1reEgl-00023e-N6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Feb 2024 14:37:07 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1reEgK-0004kI-1j; Sun, 25 Feb 2024 08:36:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1reEgH-0004jQ-KG for bug-gnu-emacs@gnu.org; Sun, 25 Feb 2024 08:36:38 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1reEgH-0004lJ-2V for bug-gnu-emacs@gnu.org; Sun, 25 Feb 2024 08:36:37 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1reEgf-0006Dt-Jc for bug-gnu-emacs@gnu.org; Sun, 25 Feb 2024 08:37:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Feb 2024 13:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69237 X-GNU-PR-Package: emacs Original-Received: via spool by 69237-done@debbugs.gnu.org id=D69237.170886816723784 (code D ref 69237); Sun, 25 Feb 2024 13:37:01 +0000 Original-Received: (at 69237-done) by debbugs.gnu.org; 25 Feb 2024 13:36:07 +0000 Original-Received: from localhost ([127.0.0.1]:45379 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reEfn-0006BX-2m for submit@debbugs.gnu.org; Sun, 25 Feb 2024 08:36:07 -0500 Original-Received: from mail-wr1-f47.google.com ([209.85.221.47]:47396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1reEfj-0006Ap-MS for 69237-done@debbugs.gnu.org; Sun, 25 Feb 2024 08:36:04 -0500 Original-Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-33dcad9e3a2so160082f8f.3 for <69237-done@debbugs.gnu.org>; Sun, 25 Feb 2024 05:35:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708868072; x=1709472872; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R7l3QzAH8/1j1h0Mdf5clHe2FSHTBGr1pN7CB/zbfQY=; b=Jp0ufdfyoWolGiv9KXyVoo7krsBpsSI8Zs8ICkWCPIn0j5L97sYMxWmfkEyB7AG8qC 2s6AoTJNz0GJGJ4NXiVTmyfO11woI1M3jQUjDWHSzHiKwczSFiuAT7rJY35yQDG+UMXn FMD8Qn2DqKemFhGfDEKpf9Lvbk91HV6i8xhv6LQsglezoWAU8CN6LRF6QCKGu60uBucQ kHznhu9GCLL9okIpMVM65GhWUWr/kg/c1RhWztsWHsc4c227Lnxj2zgWqrOS/Ct4rdxx HcJlFmBkYl/JUzN+7LnDNPx9vO8OiSyYZh4UpwkqYNF4x7cUyIu/qiJCqx+WQwupmWnI BMiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708868072; x=1709472872; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=R7l3QzAH8/1j1h0Mdf5clHe2FSHTBGr1pN7CB/zbfQY=; b=LMMlgRCCxiO5+FMUnW9BB8S1pb8mJ+sUoe3HERAjRSanB3DzeI6w9/0SAvNj//Br84 UejLK787+En8UV2E7fDfo4bEIVXvgCeFVyUUY6xPJFpxAY6PxK4CeyJzU9xInB2AibAc EQmb2Gd52W2Dm27BsQHclkfNYAN8ggBFQMbPO1FTwC7B9qLdO8i7b7Yl38iGtcqeQL1d OKgT9CHRONAD2F3cbXgnwEKoZj9l1uyy0pbIS/8MYfKVkzfWn4rTKPiFpHJOhc2wZ2Bv gQm7VKmu+E3xSvejBx9eCp4UB38kTDhH8nvirvse5iLpKy688ZOheUji/Oce5Y+80Ad3 GWdw== X-Gm-Message-State: AOJu0YwBkyuZUD2TnKlckZM1xxnRZAeibbvBIwveoX8ggwQQkUQjW43E lssOnfdaNMps6V+5/hE4OBGFwCHGCDhL5EoMoA3h3h8JmltpX101t8ApGEuY8L49Dw== X-Google-Smtp-Source: AGHT+IHm0Kg/uZKXgbTcf5ZqhZKcb70m5pVQF+BSzTEkSvzVHt2iUWKw6EXsnWG33Wvu4vc0rPo81w== X-Received: by 2002:adf:e0c8:0:b0:33d:6fd8:90d3 with SMTP id m8-20020adfe0c8000000b0033d6fd890d3mr2914632wri.4.1708868072293; Sun, 25 Feb 2024 05:34:32 -0800 (PST) Original-Received: from hirondell (ip-185-104-136-49.ptr.icomera.net. [185.104.136.49]) by smtp.gmail.com with ESMTPSA id e15-20020adf9bcf000000b0033dd15b0dafsm1590004wrc.26.2024.02.25.05.34.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Feb 2024 05:34:31 -0800 (PST) In-Reply-To: <877cisvl8s.fsf@gmx.de> (Michael Albinus's message of "Sun, 25 Feb 2024 12:25:39 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280613 Archived-At: Michael Albinus writes: >> * Should we keep the double hyphen in "read-passwd--toggle-visibility"? >> Feeling like it connotes "Emacs internals" somewhat, and wondering if >> it's appropriate for interactive commands since they are "user-facing", >> and users might feel discouraged from remapping "internal-looking" >> commands. > > It is not intended that users call 'M-x read-passwd--toggle-visibility'. > It makes sense only when you are already editing the minibuffer, typing > the password. Right, I don't expect many users to run this command via M-x. My thinking went more toward users who might want to do=E2=80=A6 (keymap-unset read-passwd-map "\t" 'remove) (keymap-set read-passwd-map "C-c \t" 'read-passwd--toggle-visibility) =E2=80=A6 and who might feel uneasy about that "--" in their personal confi= g. >> * For the 'text icon variants, should we follow outline.el's example and >> use full verbs, like " reveal " and " conceal "? > > Hmm. It would be too much space of the mode-line, I fear. See the other > examples, for example in tab-bar.el or tab-line.el. Yep, those tab bar & line examples work very well because the symbols ("+", "x") ought to be familiar to users working with tabs in other UIs. For read-passwd, I'd argue it's a taller order to expect users to intuit what "o" and "x" mean. I'd also argue the extra mode-line space should not matter that much, since it's a transient situation that will last only until the user is done typing their password, and the displaced mode-line content might not be that relevant to the user in that exact moment anyway. Maybe we can bike-shed some shorter ASCII art, e.g. (reveal) <\> (conceal) (All those nits are pretty academic, admittedly, at least as far as I am concerned, as I do not expect to rebind the command, nor to rely on the 'text icon form)