all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Kévin Le Gouguec" <kevin.legouguec@gmail.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 69237-done@debbugs.gnu.org
Subject: bug#69237: 30.0.50; Toggle password visibility
Date: Sun, 25 Feb 2024 13:34:26 +0000	[thread overview]
Message-ID: <8734tgk6ql.fsf@gmail.com> (raw)
In-Reply-To: <877cisvl8s.fsf@gmx.de> (Michael Albinus's message of "Sun, 25 Feb 2024 12:25:39 +0100")

Michael Albinus <michael.albinus@gmx.de> writes:

>> * Should we keep the double hyphen in "read-passwd--toggle-visibility"?
>> Feeling like it connotes "Emacs internals" somewhat, and wondering if
>> it's appropriate for interactive commands since they are "user-facing",
>> and users might feel discouraged from remapping "internal-looking"
>> commands.
>
> It is not intended that users call 'M-x read-passwd--toggle-visibility'.
> It makes sense only when you are already editing the minibuffer, typing
> the password.

Right, I don't expect many users to run this command via M-x.  My
thinking went more toward users who might want to do…

  (keymap-unset read-passwd-map "\t" 'remove)
  (keymap-set read-passwd-map "C-c \t" 'read-passwd--toggle-visibility)

… and who might feel uneasy about that "--" in their personal config.

>> * For the 'text icon variants, should we follow outline.el's example and
>> use full verbs, like " reveal " and " conceal "?
>
> Hmm. It would be too much space of the mode-line, I fear. See the other
> examples, for example in tab-bar.el or tab-line.el.

Yep, those tab bar & line examples work very well because the symbols
("+", "x") ought to be familiar to users working with tabs in other UIs.
For read-passwd, I'd argue it's a taller order to expect users to intuit
what "o" and "x" mean.

I'd also argue the extra mode-line space should not matter that much,
since it's a transient situation that will last only until the user is
done typing their password, and the displaced mode-line content might
not be that relevant to the user in that exact moment anyway.  Maybe we
can bike-shed some shorter ASCII art, e.g.

  <o> (reveal)
  <\> (conceal)

(All those nits are pretty academic, admittedly, at least as far as I am
concerned, as I do not expect to rebind the command, nor to rely on the
'text icon form)





  reply	other threads:[~2024-02-25 13:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-16 13:33 bug#69237: 30.0.50; Toggle password visibility Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-18 19:00 ` Eli Zaretskii
2024-02-18 20:04   ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-19 12:21 ` Eli Zaretskii
2024-02-19 15:54   ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-19 16:48     ` Eli Zaretskii
2024-02-19 17:08       ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-22 22:30 ` Kévin Le Gouguec
2024-02-23 15:43   ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-23 16:56     ` Kévin Le Gouguec
2024-02-25  9:11       ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-25 10:50         ` Kévin Le Gouguec
2024-02-25 11:25           ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-25 13:34             ` Kévin Le Gouguec [this message]
2024-02-25 14:09               ` Eli Zaretskii
2024-02-25 14:38                 ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-25 14:42                   ` Eli Zaretskii
2024-02-25 14:48               ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-25 15:27                 ` Kévin Le Gouguec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734tgk6ql.fsf@gmail.com \
    --to=kevin.legouguec@gmail.com \
    --cc=69237-done@debbugs.gnu.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.