From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions Date: Mon, 04 Mar 2024 18:41:26 +0000 Message-ID: <8734t5yh49.fsf@posteo.net> References: <87edcrtegz.fsf@gmail.com> <87sf15rjyf.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32692"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69528@debbugs.gnu.org To: No Wayman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 04 19:42:57 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rhDH7-0008JG-0t for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Mar 2024 19:42:57 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rhDGp-0005aY-CT; Mon, 04 Mar 2024 13:42:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rhDGj-0005Xz-GA for bug-gnu-emacs@gnu.org; Mon, 04 Mar 2024 13:42:34 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rhDGj-00054F-8P for bug-gnu-emacs@gnu.org; Mon, 04 Mar 2024 13:42:33 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rhDHC-0006UN-D5 for bug-gnu-emacs@gnu.org; Mon, 04 Mar 2024 13:43:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Mar 2024 18:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69528 X-GNU-PR-Package: emacs Original-Received: via spool by 69528-submit@debbugs.gnu.org id=B69528.170957772924882 (code B ref 69528); Mon, 04 Mar 2024 18:43:02 +0000 Original-Received: (at 69528) by debbugs.gnu.org; 4 Mar 2024 18:42:09 +0000 Original-Received: from localhost ([127.0.0.1]:44867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhDGL-0006TG-0G for submit@debbugs.gnu.org; Mon, 04 Mar 2024 13:42:09 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:40527) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rhDGH-0006Sg-LD for 69528@debbugs.gnu.org; Mon, 04 Mar 2024 13:42:07 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 54370240029 for <69528@debbugs.gnu.org>; Mon, 4 Mar 2024 19:41:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1709577688; bh=8fK9A6aPFm2kjQQxIldEW8Br0MTverLviNH8K9Bwjwk=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=h/pNTYNI9v02oOVX9AQkWrRSuiiAF7WSqi2Ip1NFFrxEhQ1/F/OwB6jjEsPOM2Kf9 sl+QD65PH8k+wK2GSe32S//jNj5Mk3WPxn7Hgl4q28RX6yf7M5RF1sVW8n9X2AEUJr owxKmup1YkwvoM5rebYmst96MtQuYcSRFlXgLPcxc0F5OIdfcNQTSODRwu8s5KC4zF m7qU9OlmqpQRLLRCG4ZgLtyLMgtJnsSq6HF++BYiqGUVh7ruHUd1gx3f41TQdp9ISw UzZ6nH5xq4eLyH07LR0lPLH0ck/A/sZuDHbtnn1FLZWowE8qo3lq2kvaHVaQ1IcSBm sNaE8NgJlJ0zw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TpSFz6Qpnz9rxN; Mon, 4 Mar 2024 19:41:27 +0100 (CET) In-Reply-To: <87sf15rjyf.fsf@gmail.com> (No Wayman's message of "Mon, 04 Mar 2024 12:22:00 -0500") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281018 Archived-At: --=-=-= Content-Type: text/plain No Wayman writes: > No Wayman writes: > >> Transient.el was added in 28.1 according to NEWS. >> It is not a member of package--builtin-versions for any of the >> following Emacs >> versions: 28.1, 28.2, 29.1, 29.2. At least on Emacs 30, (assq 'transient package--builtin-versions) gives me a non-nil value. I can confirm that this is the case on the emacs-29 branch. I suspect this commit resolved the issue, since `loaddefs-generate--parse-file' only checks the version header, not the package-version header. --8<---------------cut here---------------start------------->8--- commit fa5f06c1251ff717d661f05fcd240b4792054aae Author: Jonas Bernoulli Date: Tue Dec 5 20:01:44 2023 +0100 ; * lisp/transient.el: Set Version instead of Package-Version `finder-compile-keywords' only considers the "Version" header. diff --git a/lisp/transient.el b/lisp/transient.el --- a/lisp/transient.el +++ b/lisp/transient.el @@ -1,35 +1,35 @@ ;;; transient.el --- Transient commands -*- lexical-binding:t -*- ;; Copyright (C) 2018-2023 Free Software Foundation, Inc. ;; Author: Jonas Bernoulli ;; Homepage: https://github.com/magit/transient ;; Keywords: extensions -;; Package-Version: 0.5.2 +;; Version: 0.5.2 ;; Package-Requires: ((emacs "26.1") (compat "29.1.4.4") (seq "2.24")) ;; SPDX-License-Identifier: GPL-3.0-or-later ;; This file is part of GNU Emacs. ;; GNU Emacs is free software: you can redistribute it and/or modify ;; it under the terms of the GNU General Public License as published ;; by the Free Software Foundation, either version 3 of the License, ;; or (at your option) any later version. ;; ;; GNU Emacs is distributed in the hope that it will be useful, ;; but WITHOUT ANY WARRANTY; without even the implied warranty of ;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the ;; GNU General Public License for more details. ;; ;; You should have received a copy of the GNU General Public License ;; along with this program. If not, see . ;;; Commentary: ;; Transient is the library used to implement the keyboard-driven menus ;; in Magit. It is distributed as a separate package, so that it can be ;; used to implement similar menus in other packages. ;;; Code: --8<---------------cut here---------------end--------------->8--- So in general, this patch might be appropriate? --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el index 581053f6304..42f386933dc 100644 --- a/lisp/emacs-lisp/loaddefs-gen.el +++ b/lisp/emacs-lisp/loaddefs-gen.el @@ -433,7 +433,8 @@ loaddefs-generate--parse-file ;; loaddefs for packages so that `syntax-ppss' later gives ;; correct results. (emacs-lisp-mode) - (let ((version (lm-header "version")) + (let ((version (or (lm-header "package-version") + (lm-header "version"))) package) (when (and version (setq version (ignore-errors (version-to-list version))) --=-=-= Content-Type: text/plain > > I believe the behavior described here is due to this: > https://www.reddit.com/r/emacs/comments/1b69v1b/let_magit_330_use_builtin_transient/ > > To summarize, the user has a built-in version of transient.el shipped > with Emacs 29.2. > They installed magit 3.3.0, which requires transient 0.3.6. Instead of > package.el seeing magit's transient.el dependency as satisfied by the > built-in version, it installed the latest version. > > I've patched Elpaca, which relies on package--builtin-vesrions, due to > similar complaints about transient.el being pulled in despite the > built-in version satisfying a dependency. I suspect that whatever you did, won't help us since this specific issue will be resolved by the time any package.el-related fix would be published? -- Philip Kaludercic on peregrine --=-=-=--