bug#69646: [PATCH] Have insert 'submit-emacs-patch' maintainers into X-Debbugs-Cc

bug#69646: [PATCH] Have insert 'submit-emacs-patch' maintainers into X-Debbugs-Cc

[Philip Kaludercic]

[-- Attachment #1: Type: text/plain, Size: 17074 bytes --]

Tags: patch


Here's a suggestion, to have the submit-emacs-patch command
automatically ping maintainers, in case they are not following the bug
tracker.  Basically it goes through all the files and extracts the
information from the Maintainer: header.

One non-technical issue here is that the maintainer information might
not be up to date.  I've run a quick scan to see who is mentioned how
frequently.  It might be necessary to clean up this list or to check who
is still around:

--8<---------------cut here---------------start------------->8---
    339 emacs-devel@gnu.org
    160 Eric M. Ludlam <zappo@gnu.org>
     90 Lars Magne Ingebrigtsen <larsi@gnus.org>
     40 David Gillespie <daveg@synaptics.com>
     39 Stefan Monnier <monnier@iro.umontreal.ca>
     37 F. Jason Park <jp@neverwas.me>
     37 Amin Bandali <bandali@gnu.org>
     34 Stefan Kangas <stefankangas@gmail.com>
     34 John Wiegley <johnw@gnu.org>
     33 Michael Albinus <michael.albinus@gmx.de>
     28 Carsten Dominik <carsten.dominik@gmail.com>
     24 Bill Wohler <wohler@newt.com>
     22 Simen Heggestøyl <simenheg@gmail.com>
     19 Michael Kifer <kifer@cs.stonybrook.edu>
     18 Nicolas Goaziou <mail@nicolasgoaziou.fr>
     17 Simon Josefsson <simon@josefsson.org>
     17 Dave Love <fx@gnu.org>
     15 Vinicius Jose Latorre <viniciusjl.gnu@gmail.com>
     15 Daiki Ueno <ueno@unixuser.org>
     13 Masanobu UMEDA <umerin@flab.flab.fujitsu.junet>
     13 bug-cc-mode@gnu.org
     12 João Távora <joaotavora@gmail.com>
     12 David Ponce <david@dponce.com>
     11 auctex-devel@gnu.org
     10 Ulf Jasper <ulf.jasper@web.de>
     10 Thomas Fitzsimmons <fitzsim@fitzsim.org>
     10 Shenghuo Zhu <zsh@cs.rochester.edu>
     10 Philipp Stephani <phst@google.com>
     10 Per Abrahamsen <abraham@dina.kvl.dk>
     10 Lars Ingebrigtsen <larsi@gnus.org>
     10 John Wiegley <johnw@newartisans.com>
     10 Andrea Corallo <acorallo@gnu.org>
      9 Modus-Themes Development <~protesilaos/modus-themes@lists.sr.ht>
      9 Artur Malabarba <emacs@endlessparentheses.com>
      8 Tino Calancha <tino.calancha@gmail.com>
      8 Miles Bader <miles@gnu.org>
      7 Ted Zlatanov <tzz@lifelogs.com>
      7 Phil Sainty <psainty@orcon.net.nz>
      7 Kim F. Storm <storm@cua.dk>
      7 Kenichi Handa <handa@gnu.org>
      7 J. R. Hacker <jrh@example.com>
      7 Dave Gillespie <daveg@synaptics.com>
      6 Theodor Thornhill <theo@thornhill.no>
      6 Stefan Monnier <monnier@gnu.org>
      6 Peter Breton <pbreton@cs.umb.edu>
      6 Kevin Gallagher <kevin.gal@verizon.net>
      6 Eli Zaretskii <eliz@gnu.org>
      6 Daniel Pfeiffer <occitan@esperanto.org>
      6 Artur Malabarba <bruce.connor.am@gmail.com>
      5 Teodor Zlatanov <tzz@lifelogs.com>
      5 TAKAHASHI Naoto <ntakahas@m17n.org>
      5 Sameer Singh <lumarzeli30@gmail.com>
      5 Randy Taylor <dev@rjt.dev>
      5 MORIOKA Tomohiko <morioka@jaist.ac.jp>
      5 Julien Danjou <julien@danjou.info>
      5 Chong Yidong <cyd@stupidchicken.com>
      5 Boris Goldowsky <boris@gnu.org>
      4 Rob Riepel <riepel@networking.stanford.edu>
      4 Pavel Janík <Pavel@Janik.cz>
      4 Nicolas Petton <nicolas@petton.fr>
      4 Michal Nazarewicz <mina86@mina86.com>
      4 Juri Linkov <juri@linkov.net>
      4 Jonathan Yavner <jyavner@member.fsf.org>
      4 Ihor Radchenko <yantar92atgmaildotcom>
      4 Eric Abrahamsen <eric@ericabrahamsen.net>
      4 Dmitry Gutov <dgutov@yandex.ru>
      4 Daniel Colascione <dancol@dancol.org>
      4 Christian Ohler <ohler@gnu.org>
      4 Bastien Guerry <bzg@gnu.org>
      3 Toru TOMABECHI <Toru.Tomabechi@orient.unil.ch>
      3 Tom Tromey <tromey@redhat.com>
      3 Stephen Berman <stephen.berman@gmx.net>
      3 Simon Josefsson <jas@pdc.kth.se>
      3 Shuhei KOBAYASHI <shuhei@aqua.ocn.ne.jp>
      3 Sean Whitton <spwhitton@spwhitton.name>
      3 Richard Stallman <rms@gnu.org>
      3 Noah Friedman <friedman@splode.com>
      3 Nicolas Richard <youngfrog@members.fsf.org>
      3 Masatake YAMATO <yamato@redhat.com>
      3 Ken Manheimer <kendotmanheimeratgmail...>
      3 Juanma Barranquero <lekktu@gmail.com>
      3 John Paul Wallington <jpw@gnu.org>
      3 Glynn Clements <glynn@sensei.co.uk>
      3 Didier Verna <didier@didierverna.net>
      3 Dan Nicolaescu <dann@ics.uci.edu>
      3 Daiki Ueno <ueno@gnu.org>
      3 Bob Rogers <rogers@rgrjr.com>
      3 Alex Schroeder <alex@gnu.org>
      2 Yuan Fu <casouri@gmail.com>
      2 Wolfgang Jenkner <wjenkner@inode.at>
      2 Wilhelm H Kirschbaum <wkirschbaum@gmail.com>
      2 Werner Lemberg <wl@gnu.org>
      2 Vivek Dasmohapatra <vivek@etla.org>
      2 Vincent Belaïche <vincentb1@users.sourceforge.net>
      2 Torsten Hilbrich <torsten.hilbrich@gmx.net>
      2 TEC <orgmode@tec.tecosaur.net>
      2 Taro Kawagishi <tarok@transpulse.org>
      2 TAKAHASHI Naoto <ntakahas@etl.go.jp>
      2 Stephen Eglen <stephen@gnu.org>
      2 Sen Nagata <sen@eccosys.com>
      2 Scott Frazer <frazer.scott@gmail.com>
      2 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
      2 Roland Winkler <winkler@gnu.org>
      2 Reto Zimmermann <reto@gnu.org>
      2 Przemysław Wojnowski <esperanto@cumego.com>
      2 Phillip Lord <phillip.lord@russet.org.uk>
      2 Paul Jarc <prj@po.cwru.edu>
      2 Nicolas Goaziou <n.goaziouatgmaildotcom>
      2 Morten Welinder <terra@diku.dk>
      2 Milan Zamazal <pdm@zamazal.org>
      2 Masanobu Umeda <umerin@mse.kyutech.ac.jp>
      2 Mark Oteiza <mvoteiza@udel.edu>
      2 Mario Lang <mlang@delysid.org>
      2 Magnus Henoch <magnus.henoch@gmail.com>
      2 Leo Liu <sdl.web@gmail.com>
      2 Kenichi OKADA <okada@opaopa.org>
      2 Ken'ichi Handa <handa@gnu.org>
      2 Karl Fogel <kfogel@red-bean.com>
      2 Jostein Kjønigsen <jostein@kjonigsen.net>
      2 John Wiegley <johnwatgnudotorg>
      2 John Heidemann <johnh@ISI.EDU>
      2 Johan Vromans <jvromans@squirrel.nl>
      2 Jim Blandy <jimb@occs.cs.oberlin.edu>
      2 Jihyun Cho <jihyun.jo@gmail.com>
      2 Jens Lechtenbörger <jens.lechtenboerger@fsfe.org>
      2 Geoff Voelker <voelker@cs.washington.edu>
      2 Gemini Lasswell <gazally@runbox.com>
      2 Fabrice Niessen <>
      2 Erik Naggum <erik@naggum.no>
      2 Eric S. Raymond <esr@thyrsus.com>
      2 Dave Pearson <davep@davep.org>
      2 Daniel Kraus <daniel@kraus.my>
      2 Daniel Hackney <dan@haxney.org>
      2 Damien Cassou <damien@cassou.me>
      2 Andrew Cohen <cohen@andy.bu.edu>
      2 Alexandru Harsanyi <AlexHarsanyi@gmail.com>
      2 Alan Third <alan@idiocy.org>
      2 Alain Schneble <a.s@realize.ch>
      2 Aaron S. Hawley <aaron.s.hawley@gmail.com>
      1 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
      1 Wojciech S. Gac <wojciech.s.gac@gmail.com>
      1 Włodek Bzyl <matwb@univ.gda.pl>
      1 Wilson Snyder <wsnyder@wsnyder.org>
      1 Will Mengarini <seldon@eskimo.com>
      1 William Stevenson <yhvh2000@gmail.com>
      1 William M. Perry <wmperry@gnu.org>
      1 William M. Perry <wmperry@aventail.com>
      1 Werner LEMBERG <wl@gnu.org>
      1 Vladimir Panteleev <vladimir@thecybershadow.net>
      1 Ulrik Vieth <vieth@thphy.uni-duesseldorf.de>
      1 Ulf Stegemann <ulfatzeitformdotde>
      1 Tyler Smith <tyler@plantarum.ca>
      1 Tomohiro Matsuyama <tomo@cx4a.org>
      1 Tom Houlder <thoulder@icor.fr>
      1 Tom Gillespie <tgbugs@gmail.com>
      1 Tomas Abrahamsson <tab@lysator.liu.se>
      1 Thomas Baumann <thomasdotbaumannatchdottumdotde>
      1 Thierry Banel <tbanelwebmin@free.fr>
      1 Thien-Thi Nguyen <ttn@gnu.org>
      1 Theresa O'Connor <ted@oconnor.cx>
      1 Terry Jones <terry@santafe.edu>
      1 Terrence Brannon <metaperl@gmail.com>
      1 Tassilo Horn <tsdh@gnu.org>
      1 Tassilo Horn <tassiloatmemberdotfsfdotorg>
      1 Tak Kunihiro <tkk@misasa.okayama-u.ac.jp>
      1 Takaaki Ota <Takaaki.Ota@am.sony.com>
      1 Taichi <kawabata@m17n.org>
      1 Taichi Kawabata <kawabata.taichi@gmail.com>
      1 Steven L Baur <steve@xemacs.org>
      1 Stephen Gildea <stepheng+emacs@gildea.com>
      1 Stefan Merten <stefanatmerten-homedotde>
      1 Stefan Bruda <stefanbrudaca>
      1 stardiviner <numbchild@gmail.com>
      1 stanislav shalunov <shalunov@mccme.ru>
      1 Spenser Truex <web@spensertruex.com>
      1 Spencer Baugh <sbaugh@janestreet.com>
      1 Spencer Baugh <sbaugh@catern.com>
      1 SKK Development Team <skk@ring.gr.jp>
      1 Simon South <ssouth@member.fsf.org>
      1 Shigeru Fukaya <shigeru.fukaya@gmail.com>
      1 ShengHuo Zhu <zsh@cs.rochester.edu>
      1 Shakthi Kannan <author@shakthimaan.com>
      1 Sebastian Rose <sebastian_roseATgmxDOTde>
      1 Scott Byer <byer@mv.us.adobe.com>
      1 Sascha Lüdecke <sascha@meta-x.de>
      1 Sam Steingold <sds@gnu.org>
      1 Ryan Yeske <rcyeske@gmail.com>
      1 Ron Schnell <ronnie@driver-aces.com>
      1 Romain Francoise <rfrancoise@gnu.org>
      1 Roland McGrath <roland@gnu.org>
      1 Robert Pluim <rpluim@gmail.com>
      1 Robert J. Chassell <bob@gnu.org>
      1 Rick Farnbach <rick_farnbach@MENTORG.COM>
      1 Richard Sharman <rsharman@pobox.com>
      1 Richard Kim <emacs18@gmail.com>
      1 Reiner Steib <reiner.steib@gmx.de>
      1 Raymond Scholz <rscholz@zonix.de>
      1 Rasmus Pank Roulund <emacsatpankdoteu>
      1 Randal Schwartz <merlyn@stonehenge.com>
      1 Ralph Schleicher <rs@ralph-schleicher.de>
      1 Rahguzar <rahguzar@zohomail.eu>
      1 Pip Cet <pipcet@gmail.com>
      1 Philippe Schnoebelen <phs@lsv.ens-cachan.fr>
      1 Philip K. <philipk@posteo.net>
      1 Philip Kaludercic <philipk@posteo.net>
      1 Philip Jackson <phil@shellarchive.co.uk>
      1 Philip Jackson <emacs@shellarchive.co.uk>
      1 Peter S. Galbraith <psg@debian.org>
      1 Peter Kleiweg <p.c.j.kleiweg@rug.nl>
      1 Perry Smith <pedz@easesoftware.com>
      1 Per Persson <pp@gnu.ai.mit.edu>
      1 Per Bothner <per@bothner.com>
      1 Per Abrahamsen <amanda@iesd.auc.dk>
      1 Pedro Bruel <pedro.bruel@gmail.com>
      1 Peder O. Klingenberg <peder@klingenberg.no>
      1 Paul Sexton <eeeickythump@gmail.com>
      1 Paul D. Smith <psmith@BayNetworks.com>
      1 Palak Mathur <palakmathur@gmail.com>
      1 Pablo Barbáchano <pablob@amazon.com>
      1 Oliver Scholz <epameinondas@gmx.de>
      1 Olin Shivers <shivers@cs.cmu.edu>
      1 Oleh Krehel <ohwoeowho@gmail.com>
      1 Nicolas Goaziou <n.goaziou@gmail.com>
      1 Nick Savage <nick@nicksavage.ca>
      1 Nguyen Thai Ngoc Duy <pclouds@gmail.com>
      1 Neal Ziring <nz@rsch.wisc.edu>
      1 NAGY Andras <nagya@inf.elte.hu>
      1 Morten Welinder <terra@gnu.org>
      1 Mohsen BANAN <emacs@mohsen.1.banan.byname.net>
      1 Michael McNamara <mac@verilog.com>
      1 Michael Mauger <michael@mauger.com>
      1 Michael Gschwind <mike@vlsivie.tuwien.ac.at>
      1 Matthias Meulien <orontee@gmail.com>
      1 Masanobu UMEDA <umerin@mse.kyutech.ac.jp>
      1 Masahiko Sato <ms@sail.stanford.edu>
      1 Markus Rost <rost@math.uni-bielefeld.de>
      1 Mark A. Hershberger <mah@everybody.org>
      1 Marco Wahl <marcowahlsoft@gmail.com>
      1 Marco Wahl a <gmailcom>
      1 Marcin Borkowski <mbork@mbork.pl>
      1 Manoj Srivastava <srivasta@ieee.org>
      1 Luke Lee <luke.yx.lee@gmail.com>
      1 Luis R Anaya <papoanayaarobahotmailpuntocom>
      1 Ludovic Courtès <ludo@gnu.org>
      1 Luc Teirlinck <teirllm@auburn.edu>
      1 Lawrence Bottorff <borgauf@gmail.com>
      1 Kristoffer Grönlund <krig@koru.se>
      1 Konrad Hinsen <konrad.hinsenATfastmail.net>
      1 Koaunghi Un <koaunghi.un@zdv.uni-tuebingen.de>
      1 Kevin Ryde <user42@zip.com.au>
      1 Kevin Greiner <kgreiner@xpediantsolutions.com>
      1 Ken Stevens <k.stevens@ieee.org>
      1 Ken Mankoff <mankoff@gmail.com>
      1 Keith Amidon <camalot@picnicpark.org>
      1 Katsumi Yamaoka <yamaoka@jpl.org>
      1 Kai Großjohann <Kai.Grossjohann@CS.Uni-Dortmund.DE>
      1 Kai Großjohann <grossjohann@ls6.cs.uni-dortmund.de>
      1 Justin Talbott <justin@waymondo.com>
      1 Justin Abrahms <justin@abrah.ms>
      1 Juri Linkov <juri@jurta.org>
      1 Jürgen Hötzel <juergen@archlinux.org>
      1 Julien Gilles <jgilles@free.fr>
      1 Juergen Nickelsen <nickel@cs.tu-berlin.de>
      1 Juan León Lahoz García <juanleon1@gmail.com>
      1 Jose A Ortega Ruiz <jao@gnu.org>
      1 Jonas Bernoulli <jonas@bernoul.li>
      1 John Muhl <jm@pub.pink>
      1 Joe Wells <jbw@bigbird.bu.edu>
      1 Joakim Verona <joakim@verona.se>
      1 Joakim Jalap <joakim.jalap@fastmail.com>
      1 Joakim Hove <hove@phys.ntnu.no>
      1 Jesper Harder <harder@ifa.au.dk>
      1 Jeremie Juste <jeremiejuste@gmail.com>
      1 Jens Petersen <petersen@kurims.kyoto-u.ac.jp>
      1 Jeff Peck <peck@sun.com>
      1 Jason Rumney <jasonr@gnu.org>
      1 Jarno Malmari <jarno@malmari.fi>
      1 Jarmo Hurri <jarmo.hurri@iki.fi>
      1 Jan Tatarik <Jan.Tatarik@gmail.com>
      1 Jan Tatarik <jan.tatarik@gmail.com>
      1 Jan Schormann <Jan.Schormann@rechen-gilde.de>
      1 Jan Moringen <scymtym@users.sourceforge.net>
      1 Jan Böcker <jan.boeckeratjboeckerdotde>
      1 James Cloos <cloos@jhcloos.com>
      1 Jambunathan K <kjambunathanatgmaildotcom>
      1 J. Alexander Branham <alex.branham@gmail.com>
      1 Jack Kamm <jackkamm@gmail.com>
      1 Ivar Rummelhoff <ivarru@math.uio.no>
      1 Inc. <bwarsaw@cen.com>
      1 Ilja Weis <kult@uni-paderborn.de>
      1 Ihor Radchenko <yantar92@gmail.com>
      1 Ian T Zimmerman <itz@rahul.net>
      1 Ian Martins <ianxm@jhu.edu>
      1 Hrvoje Nikšić <hrvoje.niksic@avl.com>
      1 Hovav Shacham <hovav@cs.stanford.edu>
      1 Holger Schauer <Holger.Schauer@gmx.de>
      1 Gerd Moellmann <gerd@gnu.org>
      1 Gerd Moellmann <gerd@acm.org>
      1 Gary D. Foster <Gary.Foster@Corp.Sun.COM>
      1 Gary D. Foster <Gary.Foster@corp.sun.com>
      1 F. Thomas May <uw-nsr!uw-warp!tom@beaver.cs.washington.edu>
      1 Francesco Potortì <pot@gnu.org>
      1 Felix S. T. Wu <wu@crys.wisc.edu>
      1 Felix E. Klee <felix.klee@inka.de>
      1 Federico Tedin <federicotedin@gmail.com>
      1 Fabián E. Gallina <fgallina@gnu.org>
      1 Espen Skoglund <esk@gnu.org>
      1 Eshel Yaron <me@eshelyaron.com>
      1 Eli Tziperman <eliATdeas.harvard.edu>
      1 Eli Barzilay <eli@barzilay.org>
      1 Eduard Wiebe <usenet@pusto.de>
      1 Dmitry Gutov <dmitry@gutov.dev>
      1 Detlev Zundel <dzu@gnu.org>
      1 David Reitter <david.reitter@gmail.com>
      1 David Moore <dmoore@ucsd.edu>
      1 David M. Koppelman <koppel@ece.lsu.edu>
      1 David Leatherman <leathekd@gmail.com>
      1 David Kågedal <davidk@lysator.liu.se>
      1 David Engster <dengste@eml.cc>
      1 David Engster <deng@randomsample.de>
      1 Dan Nicolaescu <done@ece.arizona.edu>
      1 Dan Nicolaescu <dann@gnu.org>
      1 Daniel Mendler <mail@daniel-mendler.de>
      1 Daniel Fleischer <danflscr@gmail.com>
      1 Dan Davison <davisonatstatsdotoxdotacdotuk>
      1 Damien Cassou <damien.cassou@gmail.com>
      1 Dale R. Worley <worley@world.std.com>
      1 Corwin Brust <corwin@bru.st>
      1 Compat Development <~pkal/compat-devel@lists.sr.ht>
      1 Christoph Wedler <Christoph.Wedler@sap.com>
      1 Christopher J. Madsen <chris_madsen@geocities.com>
      1 Chris Smith <csmith@convex.com>
      1 Chong Yidong <cyd@stupidchicken>
      1 Brian Cully <bjc@kublai.com>
      1 Boruch Baum <boruch_baum@gmx.com>
      1 Bill Rozas <jinx@martigny.ai.mit.edu>
      1 Bill Perry <wmperry@gnu.org>
      1 Bill Carpenter <bill@carpenter.ORG>
      1 Benjamin Drieu <bdrieu@april.org>
      1 Bastien Guerry <bzgATalternDOTorg>
      1 Arni Magnusson <arnima@hafro.is>
      1 Arne Jørgensen <arne@arnested.dk>
      1 Anna M. Bigatti <bigatti@dima.unige.it>
      1 Andy Stewart <lazycat.manatee@gmail.com>
      1 Andy Stewart <lazycatdotmanateeatgmaildotcom>
      1 Andrew Csillag <drew@thecsillags.com>
      1 András Simonyi <andras.simonyi@gmail.com>
      1 Alexandre Oliva <oliva@lsd.ic.unicamp.br>
      1 Alexandre Julliard <julliard@winehq.org>
      1 Albert Krewinkel <tarleb@moltkeplatz.de>
      1 Alan Mackenzie <acm@muc.de>
      1 Aidan Gauland <aidalgol@no8wireless.co.nz>
--8<---------------cut here---------------end--------------->8---

The patch already includes a blacklist, to avoid emacs-devel@gnu.org
from being pinged.

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.41, cairo version 1.18.0) of 2024-03-08 built on peregrine
Repository revision: 4818022c7c45b04c55cf2a80ef689ee2681a5d78
Repository branch: master
System Description: Fedora Linux 39 (Workstation Edition)

Configured using:
 'configure --with-pgtk --with-native-compilation=aot
 --with-imagemagick'


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Have-insert-submit-emacs-patch-maintainers-into-X-De.patch --]
[-- Type: text/patch, Size: 2367 bytes --]

From 8701afcf721098f7e58204d7ddeb1977cfa84336 Mon Sep 17 00:00:00 2001
From: Philip Kaludercic <philipk@posteo.net>
Date: Fri, 8 Mar 2024 16:32:02 +0100
Subject: [PATCH] Have insert 'submit-emacs-patch' maintainers into
 X-Debbugs-Cc

* lisp/mail/emacsbug.el
(submit-emacs-patch-excluded-maintainers): Add new variable.
(submit-emacs-patch): Go through all files mentioned in the diff
and check for maintainers.
---
 lisp/mail/emacsbug.el | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/lisp/mail/emacsbug.el b/lisp/mail/emacsbug.el
index e89e66cc7cb..d6639c67c49 100644
--- a/lisp/mail/emacsbug.el
+++ b/lisp/mail/emacsbug.el
@@ -36,6 +36,7 @@
 
 (require 'sendmail)
 (require 'message)
+(require 'lisp-mnt)
 
 (defgroup emacsbug nil
   "Sending Emacs bug reports."
@@ -497,6 +498,10 @@ report-emacs-bug-hook
     (when (get-buffer-window help)
       (quit-window nil (get-buffer-window help)))))
 
+(defvar submit-emacs-patch-excluded-maintainers
+  '("emacs-devel@gnu.org")
+  "List of maintainer addresses for `submit-emacs-patch' to ignore.")
+
 ;;;###autoload
 (defun submit-emacs-patch (subject file)
   "Send an Emacs patch to the Emacs maintainers.
@@ -532,6 +537,29 @@ submit-emacs-patch
     (view-mode 1)
     (button-mode 1))
   (compose-mail-other-window report-emacs-bug-address subject)
+  (let ((maint (let (files)
+                 (with-temp-buffer
+                   (insert-file-contents file)
+                   (while (search-forward-regexp "^\\+\\{3\\} ./\\(.*\\)" nil t)
+                     (push (expand-file-name
+                            (match-string-no-properties 1)
+                            source-directory)
+                           files)))
+                 (mapcan
+                  (lambda (patch)
+                    (seq-remove
+                     (pcase-lambda (`(,_name . ,addr))
+                       (not (member addr submit-emacs-patch-excluded-maintainers)))
+                     (lm-maintainers patch)))
+                  files))))
+    (when maint
+      (rfc822-goto-eoh)
+      (insert "X-Debbugs-Cc: "
+              (mapconcat
+               (pcase-lambda (`(,name . ,addr))
+                 (format "%s <%s>" name addr))
+               maint ", ")
+              "\n")))
   (message-goto-body)
   (insert "\n\n\n")
   (emacs-build-description)
-- 
2.44.0


[-- Attachment #3: Type: text/plain, Size: 37 bytes --]


-- 
	Philip Kaludercic on peregrine

bug#69646: [PATCH] Have insert 'submit-emacs-patch' maintainers into X-Debbugs-Cc

[Andrea Corallo]

Philip Kaludercic <philipk@posteo.net> writes:

> Tags: patch
>
>
> Here's a suggestion, to have the submit-emacs-patch command
> automatically ping maintainers, in case they are not following the bug
> tracker.  Basically it goes through all the files and extracts the
> information from the Maintainer: header.
>
> One non-technical issue here is that the maintainer information might
> not be up to date.  I've run a quick scan to see who is mentioned how
> frequently.  It might be necessary to clean up this list or to check who
> is still around:

Hi Philip,

IIUC with this patch I'd be in Cc of all bugs? If that's the case I'm
not personally in favor of this, I score mails on bug-gnu-emacs also
based on me being in Cc or not.

I think the bug is that maintainers should be subscribed to
bug-gnu-emacs (otherwise I'm not sure how they can actually maintain).

Isn't a long list of people in Cc technically just another mailing list?

My 2cents, thanks!

  Andrea

bug#69646: [PATCH] Have insert 'submit-emacs-patch' maintainers into X-Debbugs-Cc

[Philip Kaludercic]

Andrea Corallo <acorallo@gnu.org> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>> Tags: patch
>>
>>
>> Here's a suggestion, to have the submit-emacs-patch command
>> automatically ping maintainers, in case they are not following the bug
>> tracker.  Basically it goes through all the files and extracts the
>> information from the Maintainer: header.
>>
>> One non-technical issue here is that the maintainer information might
>> not be up to date.  I've run a quick scan to see who is mentioned how
>> frequently.  It might be necessary to clean up this list or to check who
>> is still around:
>
> Hi Philip,
>
> IIUC with this patch I'd be in Cc of all bugs? If that's the case I'm
> not personally in favor of this, I score mails on bug-gnu-emacs also
> based on me being in Cc or not.

Why should that be?  I have tested the new command out with bug#69647,
and you weren't added automatically.  In fact, a quick grep tells me you
aren't listed as the maintainer in any file, so you wouldn't be affected
by this.

> I think the bug is that maintainers should be subscribed to
> bug-gnu-emacs (otherwise I'm not sure how they can actually maintain).

The issue is that for someone like me, who maintains a few little things
around Emacs, following all bugs and all discussions would be too much.

> Isn't a long list of people in Cc technically just another mailing list?

It shouldn't be a long list, just the people responsible for the
specific files being modified.  My idea is to have something comparable
to Linux's "get_maintainer.pl"[0], and a bit more streamlined (assuming
people even use M-x submit-emacs-patch).

[0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/get_maintainer.pl

> My 2cents, thanks!
>
>   Andrea

-- 
	Philip Kaludercic on peregrine

bug#69646: [PATCH] Have insert 'submit-emacs-patch' maintainers into X-Debbugs-Cc

[Eric Abrahamsen]

Philip Kaludercic <philipk@posteo.net> writes:

> Andrea Corallo <acorallo@gnu.org> writes:
>
>> Philip Kaludercic <philipk@posteo.net> writes:
>>
>>> Tags: patch
>>>
>>>
>>> Here's a suggestion, to have the submit-emacs-patch command
>>> automatically ping maintainers, in case they are not following the bug
>>> tracker.  Basically it goes through all the files and extracts the
>>> information from the Maintainer: header.
>>>
>>> One non-technical issue here is that the maintainer information might
>>> not be up to date.  I've run a quick scan to see who is mentioned how
>>> frequently.  It might be necessary to clean up this list or to check who
>>> is still around:
>>
>> Hi Philip,
>>
>> IIUC with this patch I'd be in Cc of all bugs? If that's the case I'm
>> not personally in favor of this, I score mails on bug-gnu-emacs also
>> based on me being in Cc or not.
>
> Why should that be?  I have tested the new command out with bug#69647,
> and you weren't added automatically.  In fact, a quick grep tells me you
> aren't listed as the maintainer in any file, so you wouldn't be affected
> by this.
>
>> I think the bug is that maintainers should be subscribed to
>> bug-gnu-emacs (otherwise I'm not sure how they can actually maintain).
>
> The issue is that for someone like me, who maintains a few little things
> around Emacs, following all bugs and all discussions would be too much.
>
>> Isn't a long list of people in Cc technically just another mailing list?
>
> It shouldn't be a long list, just the people responsible for the
> specific files being modified.  My idea is to have something comparable
> to Linux's "get_maintainer.pl"[0], and a bit more streamlined (assuming
> people even use M-x submit-emacs-patch).

Also see Bug#41373 -- IMO the really useful thing here would be to
expand this for reporting bugs in ELPA packages, where the maintainers
aren't necessarily subscribed to the main bug list.

Some time before that bug I'd proposed something similar, the patch is
here[1], it might be of some relevance.

[1]: https://lists.nongnu.org/archive/html/bug-gnu-emacs/2020-05/msg01235.html

bug#69646: [PATCH] Have insert 'submit-emacs-patch' maintainers into X-Debbugs-Cc

[Andrea Corallo]

Philip Kaludercic <philipk@posteo.net> writes:

> Andrea Corallo <acorallo@gnu.org> writes:
>
>> Philip Kaludercic <philipk@posteo.net> writes:
>>
>>> Tags: patch
>>>
>>>
>>> Here's a suggestion, to have the submit-emacs-patch command
>>> automatically ping maintainers, in case they are not following the bug
>>> tracker.  Basically it goes through all the files and extracts the
>>> information from the Maintainer: header.
>>>
>>> One non-technical issue here is that the maintainer information might
>>> not be up to date.  I've run a quick scan to see who is mentioned how
>>> frequently.  It might be necessary to clean up this list or to check who
>>> is still around:
>>
>> Hi Philip,
>>
>> IIUC with this patch I'd be in Cc of all bugs? If that's the case I'm
>> not personally in favor of this, I score mails on bug-gnu-emacs also
>> based on me being in Cc or not.
>
> Why should that be?  I have tested the new command out with bug#69647,
> and you weren't added automatically.  In fact, a quick grep tells me you
> aren't listed as the maintainer in any file, so you wouldn't be affected
> by this.

Maybe your patch should parse also admin/MAINTAINERS and collect names
from there as well?

>> I think the bug is that maintainers should be subscribed to
>> bug-gnu-emacs (otherwise I'm not sure how they can actually maintain).
>
> The issue is that for someone like me, who maintains a few little things
> around Emacs, following all bugs and all discussions would be too much.
>
>> Isn't a long list of people in Cc technically just another mailing list?
>
> It shouldn't be a long list, just the people responsible for the
> specific files being modified.  My idea is to have something comparable
> to Linux's "get_maintainer.pl"[0], and a bit more streamlined (assuming
> people even use M-x submit-emacs-patch).

If we want to Cc maintainers who are impacted by a patch I'm in favor,
if we want to Cc all maintainers then I'm not.  I haven't read your
patch but from the initial description I thought was the first case,
I've now the impression is the second.  Apologies if there was some
miss-understanding on my side.

Thanks

  Andrea

bug#69646: [PATCH] Have insert 'submit-emacs-patch' maintainers into X-Debbugs-Cc

[Philip Kaludercic]

Andrea Corallo <acorallo@gnu.org> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>> Andrea Corallo <acorallo@gnu.org> writes:
>>
>>> Philip Kaludercic <philipk@posteo.net> writes:
>>>
>>>> Tags: patch
>>>>
>>>>
>>>> Here's a suggestion, to have the submit-emacs-patch command
>>>> automatically ping maintainers, in case they are not following the bug
>>>> tracker.  Basically it goes through all the files and extracts the
>>>> information from the Maintainer: header.
>>>>
>>>> One non-technical issue here is that the maintainer information might
>>>> not be up to date.  I've run a quick scan to see who is mentioned how
>>>> frequently.  It might be necessary to clean up this list or to check who
>>>> is still around:
>>>
>>> Hi Philip,
>>>
>>> IIUC with this patch I'd be in Cc of all bugs? If that's the case I'm
>>> not personally in favor of this, I score mails on bug-gnu-emacs also
>>> based on me being in Cc or not.
>>
>> Why should that be?  I have tested the new command out with bug#69647,
>> and you weren't added automatically.  In fact, a quick grep tells me you
>> aren't listed as the maintainer in any file, so you wouldn't be affected
>> by this.
>
> Maybe your patch should parse also admin/MAINTAINERS and collect names
> from there as well?

Imaginable, but that is much more difficult to parse.  If we want to do
this, when some more general function should be written to extract this
information.

>>> I think the bug is that maintainers should be subscribed to
>>> bug-gnu-emacs (otherwise I'm not sure how they can actually maintain).
>>
>> The issue is that for someone like me, who maintains a few little things
>> around Emacs, following all bugs and all discussions would be too much.
>>
>>> Isn't a long list of people in Cc technically just another mailing list?
>>
>> It shouldn't be a long list, just the people responsible for the
>> specific files being modified.  My idea is to have something comparable
>> to Linux's "get_maintainer.pl"[0], and a bit more streamlined (assuming
>> people even use M-x submit-emacs-patch).
>
> If we want to Cc maintainers who are impacted by a patch I'm in favor,
> if we want to Cc all maintainers then I'm not.  I haven't read your
> patch but from the initial description I thought was the first case,
> I've now the impression is the second.  Apologies if there was some
> miss-understanding on my side.

No, definitely the second case.  The data-flow is

 .patch file -> list of modified files -> list of maintainers of these files

and only those are added to X-Debbugs-CC.

> Thanks
>
>   Andrea

-- 
	Philip Kaludercic on peregrine

bug#69646: [PATCH] Have insert 'submit-emacs-patch' maintainers into X-Debbugs-Cc

[Felician Nemeth]

> Here's a suggestion, to have the submit-emacs-patch command
> automatically ping maintainers, in case they are not following the bug
> tracker.  Basically it goes through all the files and extracts the
> information from the Maintainer: header.

Do I understand correctly that the maintainer is detected by searching
the local copy of Emacs, and not the always up-to-date remote version?

I'm not sure this makes a difference in practice, but a possible
alternative approach is to define two packages in the bug report.  For
example:

   Package: emacs,emacs-eglot

Then if the file "/etc/debbugs/Maintainers" on fencepost has a line
"emacs-eglot    joaotavora@gmail.com", debbugs will CC João as well.

This approach might be more complicated than yours, but would possibly
work with outdated working copies as well.  Or might not work at all.
I've come up with it based on the file emacs/admin/notes/bugtracker, and
this: https://elpa.gnu.org/packages/doc/debbugs-ug.html

bug#69646: [PATCH] Have insert 'submit-emacs-patch' maintainers into X-Debbugs-Cc

[Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Felician Nemeth <felician.nemeth@gmail.com> writes:

Hi Felician,

>> Here's a suggestion, to have the submit-emacs-patch command
>> automatically ping maintainers, in case they are not following the bug
>> tracker.  Basically it goes through all the files and extracts the
>> information from the Maintainer: header.
>
> Do I understand correctly that the maintainer is detected by searching
> the local copy of Emacs, and not the always up-to-date remote version?
>
> I'm not sure this makes a difference in practice, but a possible
> alternative approach is to define two packages in the bug report.  For
> example:
>
>    Package: emacs,emacs-eglot
>
> Then if the file "/etc/debbugs/Maintainers" on fencepost has a line
> "emacs-eglot    joaotavora@gmail.com", debbugs will CC João as well.

This file is on debbugs.gnu.org, FTR.

I don't know (and haven't tested) whether this cooperates well with the
debbugs software. A package is usually defined as such on debbugs, don't
know whether an entry as proposed by you confuses debbugs (hopefully,
not).

And I don't know how you want to maintain this file. It is intended for
all packages existing on debbugs.gnu.org, not only for Emacs.

Practically, there is only one maintainer on debbugs.gnu.org ATM, that's
me. I won't commit to this additional burden.

> This approach might be more complicated than yours, but would possibly
> work with outdated working copies as well.  Or might not work at all.
> I've come up with it based on the file emacs/admin/notes/bugtracker, and
> this: https://elpa.gnu.org/packages/doc/debbugs-ug.html

Best regards, Michael.

bug#69646: [PATCH] Have insert 'submit-emacs-patch' maintainers into X-Debbugs-Cc

[Philip Kaludercic]

Felician Nemeth <felician.nemeth@gmail.com> writes:

>> Here's a suggestion, to have the submit-emacs-patch command
>> automatically ping maintainers, in case they are not following the bug
>> tracker.  Basically it goes through all the files and extracts the
>> information from the Maintainer: header.
>
> Do I understand correctly that the maintainer is detected by searching
> the local copy of Emacs, and not the always up-to-date remote version?

Yes, it uses a local checkout, but this should be fine considering that
if someone is writing a patch, they /should/ be using a relatively
up-to-date checkout to begin with.

> I'm not sure this makes a difference in practice, but a possible
> alternative approach is to define two packages in the bug report.  For
> example:
>
>    Package: emacs,emacs-eglot
>
> Then if the file "/etc/debbugs/Maintainers" on fencepost has a line
> "emacs-eglot    joaotavora@gmail.com", debbugs will CC João as well.
>
> This approach might be more complicated than yours, but would possibly
> work with outdated working copies as well.  Or might not work at all.
> I've come up with it based on the file emacs/admin/notes/bugtracker, and
> this: https://elpa.gnu.org/packages/doc/debbugs-ug.html

I don't know too much about Debbugs, to be fair.  But I assumed that one
cannot just arbitrarily declare packages, or am I mistaken?

-- 
	Philip Kaludercic on peregrine

bug#69646: [PATCH] Have insert 'submit-emacs-patch' maintainers into X-Debbugs-Cc

[Felician Nemeth]

Hi Michael,

Albinus <michael.albinus@gmx.de> writes:

>> Then if the file "/etc/debbugs/Maintainers" on fencepost has a line
>> "emacs-eglot    joaotavora@gmail.com", debbugs will CC João as well.
>
> This file is on debbugs.gnu.org, FTR.

Thanks.

> I don't know (and haven't tested) whether this cooperates well with the
> debbugs software. A package is usually defined as such on debbugs, don't
> know whether an entry as proposed by you confuses debbugs (hopefully,
> not).
>
> And I don't know how you want to maintain this file. It is intended for
> all packages existing on debbugs.gnu.org, not only for Emacs.

My idea was that the ELPA automation scripts could start an updated
version of Philip's script to take care of maintaining this file.

If I understand Philip correctly, then this approach has little gain
over Philp's original idea.  And it is not clear for any of us whether
this approach is feasible.

Cheers,
Felicián

bug#69646: [PATCH] Have insert 'submit-emacs-patch' maintainers into X-Debbugs-Cc

[Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Felician Nemeth <felician.nemeth@gmail.com> writes:

> Hi Michael,

Hi Felicián,

>> And I don't know how you want to maintain this file. It is intended for
>> all packages existing on debbugs.gnu.org, not only for Emacs.
>
> My idea was that the ELPA automation scripts could start an updated
> version of Philip's script to take care of maintaining this file.

It isn't foreseen that external scripts have write access to debbugs.gnu.org.

> If I understand Philip correctly, then this approach has little gain
> over Philp's original idea.  And it is not clear for any of us whether
> this approach is feasible.

D'accord.

> Cheers,
> Felicián

Best regards, Michael.