From: Philip Kaludercic <philipk@posteo.net>
To: "Mattias Engdegård" <mattias.engdegard@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
Stefan Monnier <monnier@iro.umontreal.ca>,
70068@debbugs.gnu.org
Subject: bug#70068: [PATCH] Don't warn about lexical binding in lisp-interaction-mode
Date: Wed, 03 Apr 2024 18:17:16 +0000 [thread overview]
Message-ID: <8734s2cnv7.fsf@posteo.net> (raw)
In-Reply-To: <2FB192D4-40E7-4327-BC0E-62674C2C1A03@gmail.com> ("Mattias Engdegård"'s message of "Wed, 3 Apr 2024 11:35:50 +0200")
Mattias Engdegård <mattias.engdegard@gmail.com> writes:
>> - (unless (local-variable-p 'lexical-binding)
>> + (unless (or (local-variable-p 'lexical-binding)
>> + (null lexical-binding))
>
> That logic doesn't make sense to me, and it clearly doesn't work so I reverted it.
> (For some reason the test didn't catch it, but it's now been made more robust.)
You are right, I made a mistake; What I want to say is this:
--8<---------------cut here---------------start------------->8---
diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el
index 5cff86784f0..a1194f2dc70 100644
--- a/lisp/emacs-lisp/bytecomp.el
+++ b/lisp/emacs-lisp/bytecomp.el
@@ -2234,7 +2234,8 @@ byte-compile-file
(setq buffer-read-only nil
filename buffer-file-name))
;; Don't inherit lexical-binding from caller (bug#12938).
- (unless (local-variable-p 'lexical-binding)
+ (when (or (not (local-variable-p 'lexical-binding))
+ (null lexical-binding))
(let ((byte-compile-current-buffer (current-buffer)))
(displaying-byte-compile-warnings
(byte-compile-warn-x
--8<---------------cut here---------------end--------------->8---
What makes me uncertain is that you say it makes "no sense", so I want
to make sure I am not misunderstanding something completely.
--
Philip Kaludercic on peregrine
next prev parent reply other threads:[~2024-04-03 18:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 11:31 bug#70068: [PATCH] Don't warn about lexical binding in lisp-interaction-mode Philip Kaludercic
2024-03-30 6:57 ` Eli Zaretskii
2024-03-30 11:07 ` Philip Kaludercic
2024-03-30 12:54 ` Eli Zaretskii
2024-04-01 5:27 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-03 8:52 ` Philip Kaludercic
2024-04-03 9:35 ` Mattias Engdegård
2024-04-03 18:17 ` Philip Kaludercic [this message]
2024-04-03 19:07 ` Mattias Engdegård
2024-04-06 10:14 ` Mattias Engdegård
2024-04-08 7:21 ` Philip Kaludercic
2024-04-08 11:41 ` Eli Zaretskii
2024-04-08 12:02 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-09 8:57 ` Mattias Engdegård
2024-04-09 9:51 ` Eli Zaretskii
2024-04-09 10:45 ` Mattias Engdegård
2024-04-09 11:24 ` Eli Zaretskii
2024-04-09 13:35 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-09 13:42 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8734s2cnv7.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=70068@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=mattias.engdegard@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.