all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: emacs-devel@gnu.org
Subject: Re: master 1601c5a518d: Gnus: Add back end for Atom feeds (nnatom)
Date: Sun, 28 Apr 2024 16:53:25 -0700	[thread overview]
Message-ID: <8734r5avt6.fsf@ericabrahamsen.net> (raw)
In-Reply-To: 871q6p2z5r.fsf@ericabrahamsen.net

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> On 04/28/24 12:53 PM, Michael Albinus wrote:
>> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>>
>> Hi,
>>
>>> branch: master
>>> commit 1601c5a518dfa208af4827c56cf9570f3b90e15d
>>> Author: Daniel Semyonov <daniel@dsemy.com>
>>> Commit: Eric Abrahamsen <eric@ericabrahamsen.net>
>>>
>>>     Gnus: Add back end for Atom feeds (nnatom)
>>>
>>>     * lisp/gnus/gnus.el (gnus-valid-select-methods): Add entry for nnatom.
>>>     * lisp/gnus/nnfeed.el: New file implementing an abstract web feed back
>>>     end.
>>>     * lisp/gnus/nnatom.el: New file implementing a back end for Atom feeds.
>>>     * doc/misc/gnus.texi (Browsing the Web, Back End Interface):
>>>     * etc/NEWS (Gnus): Document nnatom and nnfeed.
>>> ---
>>>  doc/misc/gnus.texi  |  77 ++++++
>>>  etc/NEWS            |  10 +
>>>  lisp/gnus/gnus.el   |   1 +
>>>  lisp/gnus/nnatom.el | 276 +++++++++++++++++++++
>>>  lisp/gnus/nnfeed.el | 683 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>  5 files changed, 1047 insertions(+)
>>
>> This fails the tests:
>>
>> # make -C test test-custom-opts
>
> Thanks, we were missing a "category" definition in the new option
> default, fixing now.

This is still failing the tests, and I can't see why, I suspect the
reason is in the "... ..." below:

Test check-for-wrong-custom-opts condition:
    (ert-test-failed
     ((should (null (cus-test-opts t))) :form
      (null ((gnus-valid-select-methods :type-error ... ...))) :value nil))
   FAILED  1/1  check-for-wrong-custom-opts (13.744560 sec) at misc/test-custom-opts.el:33

I've edited test-custom-opts.el to let-bind
`ert-batch-print-level/length' to nil around the (cus-test-opts t) call,
but that doesn't change anything -- can anyone tell me how to expand the
output there?

Thanks,
Eric




  reply	other threads:[~2024-04-28 23:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <171389641522.15334.4055859790974801392@vcs2.savannah.gnu.org>
     [not found] ` <20240423182018.97FA3C12C33@vcs2.savannah.gnu.org>
2024-04-28 10:53   ` master 1601c5a518d: Gnus: Add back end for Atom feeds (nnatom) Michael Albinus
2024-04-28 17:08     ` Eric Abrahamsen
2024-04-28 23:53       ` Eric Abrahamsen [this message]
2024-04-29 16:42         ` Michael Albinus
2024-04-29 17:14           ` Mattias Engdegård
2024-04-29 18:39             ` Daniel Semyonov
2024-04-29 20:12               ` Eric Abrahamsen
2024-04-29 21:02                 ` Daniel Semyonov
2024-04-30  6:59                 ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734r5avt6.fsf@ericabrahamsen.net \
    --to=eric@ericabrahamsen.net \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.