Re: MPS image cache

[Helmut Eller <eller.helmut@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 688 bytes --]

On Sun, May 05 2024, Gerd Möllmann wrote:

>> Would something like this also be needed for glyph matrices?  
>
> Probably. Either we make the matrices roots, or objects, I guess. For
> correctness. We can't easily realloc when they are objects, but I don't
> think that's a big problem.
>
>> Or in general, can we scan anything other than the block that
>> dflt_scan was called with? 
>
> Let's say we shouldn't :-). MPS lets us scan memory it doesn't manage,
> but with multi-threading it's not really safe.

So fix_glyph_matrix currently doesn't things exactly by the book.  Hm.

Anyway, I have a patch that prevents my Emacs from sporadically crashing
at startup.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Zero-out-terminal-keyboard_coding.patch --]
[-- Type: text/x-diff, Size: 1342 bytes --]

From eda36223e8062337cd40c97471749c519fcc7b9b Mon Sep 17 00:00:00 2001
From: Helmut Eller <eller.helmut@gmail.com>
Date: Mon, 6 May 2024 10:07:14 +0200
Subject: [PATCH] Zero out terminal->keyboard_coding

This avoids hard to reproduce crashes in fix_coding.

* src/terminal.c (create_terminal): Use xzalloc instead of
xmalloc.
---
 src/terminal.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/terminal.c b/src/terminal.c
index 23a5582d4d9..33f8623c214 100644
--- a/src/terminal.c
+++ b/src/terminal.c
@@ -24,6 +24,9 @@
 #include "termchar.h"
 #include "termhooks.h"
 #include "keyboard.h"
+#ifdef HAVE_MPS
+#include "igc.h"
+#endif
 
 #if HAVE_STRUCT_UNIPAIR_UNICODE
 # include <errno.h>
@@ -281,8 +284,13 @@ create_terminal (enum output_method type, struct redisplay_interface *rif)
   terminal->rif = rif;
   terminal->id = next_terminal_id++;
 
+#ifdef HAVE_MPS
+  terminal->keyboard_coding = xzalloc (sizeof (struct coding_system));
+  terminal->terminal_coding = xzalloc (sizeof (struct coding_system));
+#else
   terminal->keyboard_coding = xmalloc (sizeof (struct coding_system));
   terminal->terminal_coding = xmalloc (sizeof (struct coding_system));
+#endif
 
   /* If default coding systems for the terminal and the keyboard are
      already defined, use them in preference to the defaults.  This is
-- 
2.39.2