From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master f896c5e8cab: ; Fix coding style of last change Date: Sun, 09 Jun 2024 19:59:55 +0800 Message-ID: <8734pme37o.fsf@yahoo.com> References: <171789547948.26161.15918757774801688043@vcs2.savannah.gnu.org> <20240609011119.F1942C1F9FF@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16805"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jun 09 14:01:03 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sGHEM-0004Du-Vk for ged-emacs-devel@m.gmane-mx.org; Sun, 09 Jun 2024 14:01:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sGHDf-0004C5-Ss; Sun, 09 Jun 2024 08:00:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sGHDd-0004BM-K4 for emacs-devel@gnu.org; Sun, 09 Jun 2024 08:00:17 -0400 Original-Received: from sonic306-20.consmr.mail.ne1.yahoo.com ([66.163.189.82]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sGHDU-00070K-HM for emacs-devel@gnu.org; Sun, 09 Jun 2024 08:00:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1717934405; bh=slR+//drVmpru6K5sgNPAXf4aIWINw/KS6SrGJ5xnYk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=R+8t8XlFRcpbXgleSka96LxrnVNhUIyes7VsGL9483CtTdP8xDBbyu43dv7oZuNMdyYwnk2vWF4azASot7dGFybUCWQBgbYA0jN3wVAlJWX0FkOS7ale3UL+JPo194tC0qBAEXCpfBZWOk2uX+hfG/17yL+InBd0Hzn+X1gdq6atkQdL3k6JuY28kozrbVsBMYzUHQgJqY6iKAtuJkjveQ7t/KDAUFhLtbN6RnQr3gvieUjtdEdFv2VpKnycikcTVk59mg565aUywBkji3UkqF66omZ4NHD9+GN+Kqy03mGjocms/KZQlVb4VlHi+8Dxw6N6s5xBrfsJThoJW20GkQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1717934405; bh=gg/bWANoeVDLuaZOghEJHENdDuioWr/tziqW2PCnObj=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Ud75SHKcipXgW7G8grdfdeHmaoXB4+Ch/cqRqeMwsayAADA2qVUfFuHhr6TYcs5UsMFMstU+BlkgE/GYnsxSYJErnJpIxgR8p1r0fxrLBaDFLqP9UbV1CSTWW9aLutWX+ARtvlPie/J0ztPaXsEXMHxmvqmthsfWRkR3c7n5Lwy5JQ6zgn0kF38B458cSMGu6C+YaZc1Dy1LCNBANZo9bKvRK5XqJ5ivL+CHMuYPXOG2ymJjUZYVFy/iVrOx4D//sUcHJBT3cEHzZXu7eCDxV/Dy0hN3YzSPCi7Liv4nX+seBTy2aVWWIQsL5z/x5AW/myrVLTJ5y3AJP9JoEMiFog== X-YMail-OSG: .t.5om8VM1l70pptrzeqpZyafRUwvYZX3hX9HSbmPM_YZ3rMFE8cyFVUaNWZBVS P4rdu2HleQl8YQaiU3R6RnmDZzEAMCM31JNsDVA9nYjVSOW9KH535duN24sxuFxPZHsq.Ize0it. txFELvDyuu92rkbff89mPxAnerN3b3g3_wBjzK3uqmUhNzYXAVdzsnOdKhH0WGMSGpKGH.lPjw5B ZXq9kEx.Qq65p4GyQubg3282qTYQFVHq_ydeIrhqVNaTfZwmn.AUqAe0CY0TddvmFhlKlV5y.rR9 ac2ltFuCu1mx7bIiXYKmh0PuijV7iej1iLyemTZjdGbKPyqdF5uYXzv55miKfrTSyaZgBDkC27on VmhoyEssjdUBUXqp1zHqi3aO5AxXdn1_pi4fT2ZeBWS060oh_0Mruxt4OO1px7aSALd..1ip89Zx vHTlRl1gOMMvpdX7gFtD86BQpdAodPoHtTWPdFvUMoHK0qtkJun4IvF7.C5drbW70ZCzo_HI1m3G KP3nq7m9ZdQegu.qSjCpRYmLBIobY.Acotww1DvqwSo5Tee3fJ8Zvz9mhWzYQgKWMHbrk7vzSZMs fkgq8te61L2RCvq1dH9J9yfvJX87sZhhQwst91VDNFI5W7zu4hwG3toND27P_cy_eUFaHZLYjaVh .prURICvkMKWPerj30WTgfmL3UFoVq6sxqes__OwHUVbcFyg4Ojmrux2VjoMTuyv13U61S2tbN4T G4fKQ9cZ9LwVshqVYXjLo78nhkdVm3ezMYA_qf_OP_WLgQ59U_hkgONigqYeFbzLZ6QkNrtN2mpx b6yNEGQBZJRM5ptQ5T08rj3THy82ClbgBymWZf_C8r X-Sonic-MF: X-Sonic-ID: ee6592ae-0c6b-4dec-ad20-d4e349beebac Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Sun, 9 Jun 2024 12:00:05 +0000 Original-Received: by hermes--production-sg3-6f9f87bd85-8fmbs (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID c7e6e647ee383723afbce84654b72960; Sun, 09 Jun 2024 12:00:00 +0000 (UTC) In-Reply-To: (Stefan Kangas's message of "Sun, 9 Jun 2024 04:53:57 -0700") X-Mailer: WebService/1.1.22407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.189.82; envelope-from=luangruo@yahoo.com; helo=sonic306-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319927 Archived-At: Stefan Kangas writes: > Po Lu via Mailing list for Emacs changes writes: > >> -static void >> -read_and_dispose_of_process_output (struct Lisp_Process *p, char *chars, >> - ssize_t nbytes, >> - struct coding_system *coding); >> +static void read_and_dispose_of_process_output (struct Lisp_Process *, char *, >> + ssize_t, >> + struct coding_system *); > > I thought we preferred the above style? Not in declarations. > But here we change to the other one? > > Could someone please explain what I'm missing? The author evidently confused the identity of the latter with that of the former.