From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Brennan Vincent" Newsgroups: gmane.emacs.bugs Subject: bug#73279: [PATCH] Eglot: use immediate-mode eglot--request for :completionItem/resolve Date: Mon, 16 Sep 2024 11:17:05 -0400 Message-ID: <8734lz7hn2.fsf@taipei.mail-host-address-is-not-set> References: <87v7ywoh7m.fsf@taipei.mail-host-address-is-not-set> <86wmjbdehl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31401"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 73279@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , Eli Zaretskii , Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 16 17:18:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sqDUQ-0007sK-Lo for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Sep 2024 17:18:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sqDU7-0003wv-67; Mon, 16 Sep 2024 11:17:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sqDU5-0003q5-Bp for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2024 11:17:49 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sqDU5-0005Mb-2h for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2024 11:17:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=ZnVyl1gPh8JYwala4pBqFWBGA3l/PUgTahuXCi5RH2Q=; b=LylPQrnxKkPnO2MjoLL9BDhcesPhjIFG3zE/X63yR7cW4ws4mmVA/ht1kX5OYGhVbJMuYufKC9+lFTEw4OgQEe4eCRPpIb4K5NrPXRnUNhA1PsGCCizPAz17rOT+xKtjehLWJzbG7rJacADtIxKvHw8QaR66qt3r7LKAJFyOJR0bkGU6laVxonPcXj/DwtPvm6+vIe9INrEmUXaGm38vI+21XHATPkjpDSbbhh3hWkfBWRB7TM9r0IJFYqV1I8hFdeN1GyMbEx9lac0KFzttrm+fFXAXeAVz8tFq+2Gu0AqZIvBXxuEsFXur74ntjuW9s6iFanBQZirm1QBaO4qZdw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sqDUI-00067y-Ar for bug-gnu-emacs@gnu.org; Mon, 16 Sep 2024 11:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Brennan Vincent" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Sep 2024 15:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73279 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73279-submit@debbugs.gnu.org id=B73279.172649985323505 (code B ref 73279); Mon, 16 Sep 2024 15:18:02 +0000 Original-Received: (at 73279) by debbugs.gnu.org; 16 Sep 2024 15:17:33 +0000 Original-Received: from localhost ([127.0.0.1]:53044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqDTo-000673-Nz for submit@debbugs.gnu.org; Mon, 16 Sep 2024 11:17:33 -0400 Original-Received: from smtp.umanwizard.com ([54.203.248.109]:14706) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sqDTm-00066n-RR for 73279@debbugs.gnu.org; Mon, 16 Sep 2024 11:17:31 -0400 Original-Received: from localhost ([108.6.22.48]) by smtp.umanwizard.com ; 16 Sep 2024 15:17:06 +0000 X-Fes-Received-For: 73279@debbugs.gnu.org X-Fes-Received-From: In-Reply-To: X-Fes-Encrypted: true X-Fes-Ehlo-Domain: localhost X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291895 Archived-At: Hi Jo=C3=A3o, Just in case you're not familiar with Rust, here are the detailed repro instructions: 1. Install rust, cargo, and rust-analyzer: https://rustup.rs 2. Create a new project: cargo new my-project 3. Paste the repro recipe from my patch commit message into my-project/src/main.rs As for the regression: yes, it's a regression from 29.4, and in fact I have bisected to the commit that regressed it: a8c1559a663d9bc21776e33303251e244f86f0d7 So this is broken for me in both 30 and 31. Jo=C3=A3o T=C3=A1vora writes: > On Mon, Sep 16, 2024 at 12:28=E2=80=AFPM Eli Zaretskii wro= te: >> >> > From: Brennan Vincent >> > Date: Sun, 15 Sep 2024 15:22:05 -0400 > >> Jo=C3=A3o, any comments? > > Yes, I have yet to try the reproduction recipe of this alleged problem > but one thing stands out. Brennan, you wrote "as it did in Emacs 29.4". > So this is a recent regression of sorts, is that what you're saying? I d= on't > think that code has changed much over the past years. > > I also don't recognize the timing you're describing, but I'll comment > on that after I've done my investigation. Usually there's a low > chance a patch will easily go through in this very sensitive area > of the code. But a low change is nonetheless non-0 :-) Maybe > Dmitry can also have a look, as he's been tinkering with Eglot > completion lately. > > Jo=C3=A3o T=C3=A1vora