From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Morgan Willcock Newsgroups: gmane.emacs.bugs Subject: bug#73533: [PATCH] Rewrite speedbar expansion for all descendants Date: Mon, 30 Sep 2024 19:28:12 +0100 Message-ID: <8734lhgfnn.fsf@ice9.digital> References: <87y13blhu1.fsf@ice9.digital> <86a5fr5apb.fsf@gnu.org> <87v7yeeqig.fsf@ice9.digital> <87wmitfr8p.fsf@ice9.digital> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37038"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 73533@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 30 20:31:59 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1svLBf-0009Tw-1k for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 30 Sep 2024 20:31:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1svLBI-0003tt-FI; Mon, 30 Sep 2024 14:31:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1svLBE-0003t4-Bj for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2024 14:31:33 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1svLBC-0002ZH-EG for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2024 14:31:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=pE6Le+bgXmhtAa+VqUzqvOhqgW1751b6Do8UKqTj0AA=; b=TsIeGSJj37bQbPrKl2vaXKlk58MmIbjEKfL083PTtVZXqE4t6jY9ptYBvkiUcot7NXVGtobvDjqzMGTGEYNTGfTWUXRsnfZiUzygtAalkrmhAytY8J/dtI2Bn9Lp2kdugg1jWVAm554v0thNkVw5TQaSPQfHgiwL6iv42bp2QfEJwObhTBHVvcUfC3EEh945jXSfaslL6Arxwvy0NLylWDgN+TaQff9Kva43WrbcRdGePb6qmYqIod25m3Qb1owoAxjdTq8jsx1DbzyspJxTlH0SU2A+G5Av7tFbUEZtvlMkuIjz5f5j2ifqLyEZv4iAAy5H3h9CKjfkjYK7Sj0z5A==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1svLBj-00080e-7y for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2024 14:32:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Morgan Willcock Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Sep 2024 18:32:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73533 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 73533-submit@debbugs.gnu.org id=B73533.172772107230396 (code B ref 73533); Mon, 30 Sep 2024 18:32:03 +0000 Original-Received: (at 73533) by debbugs.gnu.org; 30 Sep 2024 18:31:12 +0000 Original-Received: from localhost ([127.0.0.1]:46258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svLAp-0007tW-5c for submit@debbugs.gnu.org; Mon, 30 Sep 2024 14:31:11 -0400 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:55811) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1svL8j-00075i-AD for 73533@debbugs.gnu.org; Mon, 30 Sep 2024 14:29:40 -0400 Original-Received: by mail.gandi.net (Postfix) with ESMTPSA id DD0C4E0002; Mon, 30 Sep 2024 18:28:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ice9.digital; s=gm1; t=1727720895; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pE6Le+bgXmhtAa+VqUzqvOhqgW1751b6Do8UKqTj0AA=; b=UFYmBcxHgQGBJ36Gb6LRYewxjHfetRqljBCsOhSH1y6RKus8evC/clqNeOPdPUo7PatNv1 LmrOHoWyKEztuANxA7YzC+S29CQlE89PSHEherhOQGWinH9AVBxNgeHSnM8EPhLSYryp69 GC8WGGg51AAoCOGjHCCMMysv7oDSzRLZTntciHfdtb2CnnEwfb4Bt9ZSUcoXO1Urd6gXfW 18kSSJtflFgqwcWUQqZX5GK1+VjW0wE5hWD++FMTwneRj5YeI5OGNP/oY2Wzt9s/4G0c0/ OMo2wMxZZGehd1Zaig9Wbze4thAxP1LdQEqy7iDPZKWmkJZrBFGQXNFTMMvQ+g== In-Reply-To: <87wmitfr8p.fsf@ice9.digital> (Morgan Willcock's message of "Mon, 30 Sep 2024 10:03:18 +0100") X-GND-Sasl: morgan@ice9.digital X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:292737 Archived-At: Morgan Willcock writes: > The change that was made in bug#35014 looks like it broke the expansion > when the item was already partially expanded, so attached is a modified > version of the patch that completely removes the narrowing-per-item > approach and also includes more comments. Unfortunately the narrowing trick causes problems in some situations, either the previous way from bug#35014 or using the result of point-max (either too few entries or expanded to too many). I'll try to an alternative way to move through the entries. -- Morgan Willcock