From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Add completion to compilation-read-command Date: Tue, 24 Dec 2024 14:53:26 +0000 Message-ID: <8734idb09l.fsf@posteo.net> References: <87ttatb9g0.fsf@posteo.net> <87ikr9b5u8.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33270"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Spyros Roum Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 24 15:54:05 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tQ6IO-0008WO-Pm for ged-emacs-devel@m.gmane-mx.org; Tue, 24 Dec 2024 15:54:04 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tQ6Ht-0000eL-O5; Tue, 24 Dec 2024 09:53:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQ6Hs-0000ds-3g for emacs-devel@gnu.org; Tue, 24 Dec 2024 09:53:32 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQ6Hp-000122-UB for emacs-devel@gnu.org; Tue, 24 Dec 2024 09:53:31 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id DD8CC240027 for ; Tue, 24 Dec 2024 15:53:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1735052007; bh=zXFkCAzJRNERqHnam70jVq0vEuKB4RS1ElAur5JhrK4=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=fDyrbKcLxI3+0/gMasJLOyZ7a2BQeTMU0h6yTDG/joaaIoqBiSIIdF0f4zF9IworQ EIqGIsvz/xQ82EuoZOMcK/Chu0dydrvFvbQakxOrm4gkGZAIuSTKRRDXbZZPn1kDJb /0uhNnvwMDZWpv5Us+fUo4xwsrUAUgR6U1nVUfbdN143p1Smz1brd342Fx11ShKoW4 Q6T8eHLJOvpiU/33CNwAlJ4/XzX6GUYTN4U5FczbAa30pwMfTBMGAFeY/9/KSmnG3H tfW2M7jxn/TKBFPn+cxIzuUo0DqikVUSHI06MVyOQwOCRorFKLSS7q+wGp/JNFZoRm +AzFo7k639lBA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YHdDl39FLz9rxQ; Tue, 24 Dec 2024 15:53:27 +0100 (CET) In-Reply-To: (Spyros Roum's message of "Tue, 24 Dec 2024 13:43:43 +0000") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327020 Archived-At: Spyros Roum writes: > Philip Kaludercic wrote: >>>>> , I = was >>>>> missing auto-complete a lot. >>>>> I managed to add this functionality by writing a simple function based >>>>> on compilation-read-command that uses completing-read instead of >>>>> read-shell-command. >>>> Do you know about the `bash-completion' package? It enhances >>>> `read-shell-command' completion with completion data provided by bash. >>>> It is very easy to set up, >>>> >>>> (use-package bash-completion :ensure t >>>> :init (bash-completion-setup)) >>>> >>>> should do it. >>> I was not aware of this, but it doesn't seem to do what I'm looking for. >>> For once, I am not using bash, but even ignoring that it doesn't seem >>> to have the effect I'm looking for. >>> >>> I'm trying to get the compile prompt to suggest completion based on >>> past commands I've run. >> My bad. In that case, why not use C-r to search `compile-history'? > > I'm not sure if you are suggesting that I should be able to use C-r in > the compile prompt, if so there might be a keybind issue as I'm using > evil and C-r does not do that for me. > If that's the case, could you name the function that does that? It > could be what I'm looking for. Oh, sorry about that. C-r is just the regular `isearch-backward' binding. >>>>> Then I used advice-add to overwrite the >>>>> original=C2=A0compilation-read-command with mine. >>>>> >>>>> So far this works well, and as far as I can tell there is no good >>>>> reason not to make compile auto-completing, it already has a history >>>>> that you can navigate anyway. >>>>> >>>>> With that said, this is the first time I write here and the first time >>>>> I'm trying to contribute to emacs, so I'm not sure what the best way >>>>> to go from here would be. >>>>> I think some decisions would need to be taken, for once I am not sure >>>>> if it's acceptable to change the default and make it completing or if >>>>> there should be an option for it. >>>> I am not sure if you meant to attach any code, but that would probably >>>> be the best place to start. >>>> >>>>> Looking forward to your feedback, thanks >>> You are right I should have posted code, so here is what I have: >>> >>> =C2=A0 (defun compilation-read-command-with-autocomplete (command) >>> =C2=A0=C2=A0=C2=A0 "Use `completing-read` to add autocomplete powers t= o compilation read" >>> =C2=A0=C2=A0=C2=A0 (completing-read "Compile command: " compile-history >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 nil nil command >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (if (equal (car compile-history) comman= d) >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 '(compile-history . 1) >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 'compile-history))) >>> >>> =C2=A0 (advice-add >>> =C2=A0=C2=A0=C2=A0 #'compilation-read-command >>> =C2=A0=C2=A0=C2=A0 :override #'compilation-read-command-with-autocompl= ete) >> If this were added to Emacs, we probably wouldn't use advice. I think >> the best strategy for you would be to prepare a patch against compile.el >> and add a user option that allows prompting the user with >> completing-read. What do you think? > > I agree advice is not a good solution if this gets merged, this is > just what I have in my config to make it work. > > I believe an option defaulting to the current behavior is fine, > assuming we don't want to just change it to the completing version all > together. I think that would be to invasive. > However, I am somewhat lost on what that option might look > like. Probably some customizable option based on which > compilation-read-command's internals change to either the current or > my version? The easiest choice is just a user option that holds function, presumably without taking any argument The default value would use regular shell-read-command, and a suggested alternative could be your suggestion. > If so, I will need to figure out how the customizable system works > internally in order to use it. Any pointers on that would be > appreciated. It will probably look something like this (defcustom compilation-prompt-function=20 #'complation-prompt-using-read-shell-command "[document the user option here]." :version "31.0" :type 'function)