From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#47207: 28.0.50; decode_next_window_args crash Date: Thu, 15 Apr 2021 16:45:20 +0200 Message-ID: <872ab30c-3492-b523-eb4a-2f33a6c5da56@gmx.at> References: <83h7l9d651.fsf@gnu.org> <83eegdd4uz.fsf@gnu.org> <8335wsdcob.fsf@gnu.org> <11b795a6-1a20-cc58-73d6-b75227dc732a@gmx.at> <83r1kcflv6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29451"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 47207@debbugs.gnu.org To: Alan Mackenzie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 15 16:46:27 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lX3GF-0007X9-B8 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Apr 2021 16:46:27 +0200 Original-Received: from localhost ([::1]:34442 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lX3GE-00032a-C2 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Apr 2021 10:46:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lX3Fq-00032K-CZ for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2021 10:46:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55543) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lX3Fq-00055L-1v for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2021 10:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lX3Fp-00039P-WD for bug-gnu-emacs@gnu.org; Thu, 15 Apr 2021 10:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Apr 2021 14:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47207 X-GNU-PR-Package: emacs Original-Received: via spool by 47207-submit@debbugs.gnu.org id=B47207.161849793412058 (code B ref 47207); Thu, 15 Apr 2021 14:46:01 +0000 Original-Received: (at 47207) by debbugs.gnu.org; 15 Apr 2021 14:45:34 +0000 Original-Received: from localhost ([127.0.0.1]:38853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lX3FO-00038Q-8y for submit@debbugs.gnu.org; Thu, 15 Apr 2021 10:45:34 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:58807) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lX3FJ-000386-4L for 47207@debbugs.gnu.org; Thu, 15 Apr 2021 10:45:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1618497921; bh=GEID7luB0jjjh6Keta6DYduHI2Y8BOF5GJwCAxdxATw=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=JR6WxGBGByUIqjfDwi25TvrzmwzCj92TGN4swx006CAsPwT1i+QuwlsVOjjE4ld9D z9yJ/r0pTtU1+hIdU57wbTbSAok49fAUowPXTT6A/CgBUM/z8/qMZ6oFGH8NgKLqRa 81D/YODRZnDXDoei1INBMAKIu/6nvBERbArffZHo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([212.95.5.198]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N9MpY-1lcdoT2WEW-015ItI; Thu, 15 Apr 2021 16:45:21 +0200 In-Reply-To: Content-Language: en-US X-Provags-ID: V03:K1:IejzjYGMzEfVFOoVrjJzwY90qNqT9f6Z4Cx5dQ8xAadNnPTWxaf vViCsLLFstPMVyX/Xt5hSokIyXQiBOMPCW5m1iIM65Svdi+1L58o4+qO34cxlP0U1ffqAOf ATzGgFTFUVIkElVb672CjpM9BwcAAUdnzwGAO232VRx9OHxCdUQ+uYTh4G5D+Dm3RQ76SSV 6TnHlSFBVE47Aedr0v8IQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:/8DzKbG2K84=:msiHMfmz/mkZA5qq+zGHbp 7XlvOFs2frE8F5mfS9Z3F0K46ID2pLrKqMVEyBgLuQApgybhEsWUHuPH5n458KLMtxBb3AeT5 yjJLxt1vmM6yOj8dUm89wEJo515qQ5WQDE2C1ieozU8jIhV4/onaSfvKlbR18mHdw1KQaECUj z3IiO4WkZQgK8zkpULIdK53lXbDgW0AraCrc45xOaf7uaHQT7mUqjH5iVzJXkWbdVBs29iDnS F/PFpn+0F+pEMfdZDevz9vSbvQVLQ3YR4geqGBXeyzt+eyIwc37RO1CrpJgJkMYsoIktzvNLq LTPYMxnrQn6Gz8Z47sWFZ0kkj3dVaPa49aoSmIQ1UHwJs824vvHTv61dULAAsAJWonWfD7Pfn ylfBPX+6nJv3P0atUGQizosQO++Xpzl88z5CjiCZbCCc3y4GE/SfNEdDiFpVR2xSi+LlYarQw QdSnshExbCnwcyPGP/cVQJUUHjnyZQ2oqi1iFVrogUNE106ILB/rRhXBM9j3VwToxNkOxeFll ft9WrVmWpy2vbXL17RbtV1070DOsDHW9Eto5MlSfMEnYUeam/VQRgvp+QJKw2AWc7bZ3w0VlP C4yxmLyg3RLGJubEkQNx1jOocpfVjy8B812/bmQB46v5Z8u05aBtJVJevKvKbYd33EdqqO0DJ Lx/QCPVxOYZ/OXd9ARD0+D1HJwHmYEpPkGjWiZje5Y6L2YncKhsIAawrII+MDAfX3TmFzq8WH lWpGydgRc1DZhCPVHun32/E/nqvoPkvEvg8KFUSVTrlWfocjFb7lZB3csIvlAtqyI/JzFJcW X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204076 Archived-At: > That's quite an involved thread. I've read through it, but can't > remember seeing a firm decision on how to fix the problem, or even if it > was fixed then. It wasn't fixed then. > The current problem in minibuf.c seems to be that we assume > f->minibuffer_window to be non-nil in several (~6) places, rather than > checking it. We assume that it is a live window. > In most of these places, if we detect NILP (f->m_w), we can simply skip > the action we were intending to take. This is certainly the case in the > bit that gave you the trouble in read_minibuf_unwind, where we're > stepping through all frames looking for the expired minibuffer. The most secure way is to skip the action whenever f->minibuffer_window fails the WINDOW_LIVE_P check. > It might well be that we never call do_switch_frame to a tool-tip frame, > for example. Do you know if this is the case? This could save some > checking code. I wrote some code that avoids that a tooltip window ever gets selected and do_switch_frame returns silently when asked to switch to a tooltip frame. But I wouldn't rely on that - the display engine might still try to select a tooltip window for some reason. > So, where do we go from here? I'm quite willing to make these changes > to minibuf.c. Would that be OK with everybody else? It would be OK with me (and should fix Bug#47774 too). And please look into Bug#47781 next. martin