From: Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Re: Is that change a good idea?
Date: Fri, 18 Mar 2005 08:45:49 -0500 [thread overview]
Message-ID: <871xad5b2j.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20050318082442.GA4710@kenny.sha-bang.local> (Sascha Wilde's message of "Fri, 18 Mar 2005 09:24:42 +0100")
>> > * help.el (describe-mode): Allow a :minor-mode-function property to
>> > specify a different minor mode toggle function than the variable.
>> > * simple.el (auto-fill-function):
>> > * subr.el (add-minor-mode): Use it.
>>
>> > I have my doubts that the resulting flexibility is really in the best
>> > interest of the users...
>>
>> 100% agreement.
>> It's only meant to clean up the code,
> Wouldn't it be far more cleaner to convert old minor-modes which would
> need this hack to proper minor-modes following standard semantics?
You do realize that there are packages over which we have no control, right?
>> not as a new feature.
> I would guess: when its there, it will be used...
> btw. I posted a patch, convertinge auto-fill-function to a standard
> minor-mode (thus addressing the same problem) earlier this week, but
> got no response -- was it _that_ bad?
No: if it were bad you'd have received complaints.
I thought the code was acceptable, but at the same I found it someone
unsatisfactory because there are then two variables that decide whether the
mode is ON or not: auto-fill-mode and auto-fill-function and you have to
make sure they're kept in sync. Maybe we could do (defvaralias
'auto-fill-function 'auto-fill-mode) and then slowly change modes
to replace (if auto-fill-function (funcall auto-fill-function)) with
(if auto-fill-mode (funcall normal-auto-fill-function)).
Stefan
next prev parent reply other threads:[~2005-03-18 13:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-17 22:07 Is that change a good idea? David Kastrup
2005-03-17 22:16 ` Stefan Monnier
2005-03-18 8:24 ` Sascha Wilde
2005-03-18 13:45 ` Stefan Monnier [this message]
2005-03-18 14:07 ` David Kastrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871xad5b2j.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.