From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Options menu is broken on CVS Date: Thu, 08 Sep 2005 17:02:05 -0400 Message-ID: <871x3znuon.fsf-monnier+emacs@gnu.org> References: <200509062007.04648.ismail@uludag.org.tr> <17181.65500.337376.386116@farnswood.snap.net.nz> <200509062349.18090.ismail@uludag.org.tr> <17182.8135.530028.132576@farnswood.snap.net.nz> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1126214303 6827 80.91.229.2 (8 Sep 2005 21:18:23 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 8 Sep 2005 21:18:23 +0000 (UTC) Cc: nickrob@snap.net.nz, emacs-devel@gnu.org, rms@gnu.org, ismail@uludag.org.tr Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 08 23:18:13 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EDTkh-0000SP-06 for ged-emacs-devel@m.gmane.org; Thu, 08 Sep 2005 23:16:11 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EDTkg-0000vH-8F for ged-emacs-devel@m.gmane.org; Thu, 08 Sep 2005 17:16:10 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EDTiT-0000UH-UG for emacs-devel@gnu.org; Thu, 08 Sep 2005 17:13:54 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EDTiP-0000Rh-Ff for emacs-devel@gnu.org; Thu, 08 Sep 2005 17:13:50 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EDTiN-0000KG-7s for emacs-devel@gnu.org; Thu, 08 Sep 2005 17:13:47 -0400 Original-Received: from [209.226.175.74] (helo=tomts20-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EDTbZ-00055n-LB; Thu, 08 Sep 2005 17:06:45 -0400 Original-Received: from alfajor ([67.71.33.77]) by tomts20-srv.bellnexxia.net (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP id <20050908210205.MDHI26550.tomts20-srv.bellnexxia.net@alfajor>; Thu, 8 Sep 2005 17:02:05 -0400 Original-Received: by alfajor (Postfix, from userid 1000) id 4C06BD733A; Thu, 8 Sep 2005 17:02:05 -0400 (EDT) Original-To: Eli Zaretskii In-Reply-To: (Eli Zaretskii's message of "Thu, 08 Sep 2005 06:39:05 +0300") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:42760 Archived-At: >> Perhaps the best way to find out what the bug was is to revert the >> change; then someone will see that bug again, and someone can write a >> new fix for it. > No, this is IMHO a bad way: the chances of that someone to see that > bug could be small, depending on what was the configuration in which > it was found back then. It is much better to read the emacs-devel > discussions related to my change and understand what was the bug I > fixed. Let's take it as a reminder that when we commit a fix, we should make sure we describe the bug it fixes, either in comments in the code (when possible/meaningful) or in the ChangeLog entry. Of course, if the old code was just plain wrong it's not necessary. Stefan