all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: nickrob@snap.net.nz, emacs-devel@gnu.org, rms@gnu.org,
	ismail@uludag.org.tr
Subject: Re: Options menu is broken on CVS
Date: Thu, 08 Sep 2005 17:02:05 -0400	[thread overview]
Message-ID: <871x3znuon.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <ull28w7mu.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 08 Sep 2005 06:39:05 +0300")

>> Perhaps the best way to find out what the bug was is to revert the
>> change; then someone will see that bug again, and someone can write a
>> new fix for it.

> No, this is IMHO a bad way: the chances of that someone to see that
> bug could be small, depending on what was the configuration in which
> it was found back then.  It is much better to read the emacs-devel
> discussions related to my change and understand what was the bug I
> fixed.

Let's take it as a reminder that when we commit a fix, we should make sure
we describe the bug it fixes, either in comments in the code (when
possible/meaningful) or in the ChangeLog entry.  Of course, if the old code
was just plain wrong it's not necessary.


        Stefan

  reply	other threads:[~2005-09-08 21:02 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-06 17:07 Options menu is broken on CVS İsmail Dönmez
2005-09-06 20:45 ` Nick Roberts
2005-09-06 20:49   ` İsmail Dönmez
2005-09-06 23:01     ` Nick Roberts
2005-09-07  4:16       ` Eli Zaretskii
2005-09-07 14:58         ` İsmail Dönmez
2005-09-07 18:04           ` Eli Zaretskii
2005-09-07 18:13             ` İsmail Dönmez
2005-09-07 22:11               ` Nick Roberts
     [not found]                 ` <20050907223612.GA7445@uludag.org.tr>
2005-09-07 23:27                   ` Nick Roberts
2005-09-07 22:04         ` Nick Roberts
2005-09-08  3:50           ` Eli Zaretskii
2005-09-08  4:24             ` Nick Roberts
2005-09-08 19:33               ` Eli Zaretskii
2005-09-09 11:50                 ` Eli Zaretskii
2005-09-09 13:12                   ` Nick Roberts
2005-09-09 13:49                     ` Eli Zaretskii
2005-09-09 23:07                       ` Nick Roberts
2005-09-10  9:28                         ` Eli Zaretskii
2005-09-10 11:09                           ` Eli Zaretskii
2005-09-09 13:46                   ` Eli Zaretskii
2005-09-09 15:47                     ` David Kastrup
2005-09-09 18:23                       ` Eli Zaretskii
2005-09-10  0:08                     ` YAMAMOTO Mitsuharu
2005-09-10  9:18                       ` Eli Zaretskii
2005-09-11  6:54                         ` Richard M. Stallman
2005-09-11 19:51                           ` Eli Zaretskii
2005-09-12 15:34                             ` Richard M. Stallman
2005-09-09 18:12                   ` Stefan Monnier
2005-09-09 18:18                     ` Eli Zaretskii
2005-09-10  0:18                       ` YAMAMOTO Mitsuharu
2005-09-08  9:04           ` Richard M. Stallman
2005-09-08  9:50           ` İsmail Dönmez
2005-09-08  2:41       ` Richard M. Stallman
2005-09-08  3:39         ` Eli Zaretskii
2005-09-08 21:02           ` Stefan Monnier [this message]
2005-09-09 10:41             ` Eli Zaretskii
2005-09-09 13:06               ` Stefan Monnier
2005-09-09 17:40                 ` Bug repository Bill Wohler
2005-09-10  6:12                   ` Miles Bader
2005-09-10  8:13                   ` Richard M. Stallman
2005-09-10  8:14                 ` Options menu is broken on CVS Richard M. Stallman
2005-09-10  8:48                   ` Eli Zaretskii
2005-09-11  6:54                     ` Richard M. Stallman
2005-09-11  9:36                       ` Refering to bug reports (was: Options menu is broken on CVS) Reiner Steib
2005-09-12 15:33                         ` Richard M. Stallman
2005-09-11 19:54                       ` Options menu is broken on CVS Eli Zaretskii
2005-09-12 15:33                         ` Richard M. Stallman
     [not found] <131DDC775E8EB841AD6D175CDF410DCE0311C1D0@payload.camelot.bsquare.com>
2005-09-06 18:32 ` İsmail Dönmez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871x3znuon.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=ismail@uludag.org.tr \
    --cc=nickrob@snap.net.nz \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.