From: michael.cadilhac@lrde.org (Michaël Cadilhac)
Cc: agustin.martin@hispalinux.es, emacs-devel@gnu.org, storm@cua.dk
Subject: Re: delete-process bug
Date: Tue, 30 May 2006 00:32:25 +0200 [thread overview]
Message-ID: <871wucfona.fsf@lrde.org> (raw)
In-Reply-To: <uirnofplk.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 30 May 2006 01:11:51 +0300")
[-- Attachment #1.1.1: Type: text/plain, Size: 1032 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
>> From: michael.cadilhac@lrde.org (=?iso-8859-1?Q?Micha=EBl?= Cadilhac)
>> Cc: agustin.martin@hispalinux.es, emacs-devel@gnu.org, storm@cua.dk
>> Date: Mon, 29 May 2006 23:42:39 +0200
>>
>> I will summarize the whole thing:
>
> Thanks. I think I understand now.
>
>> AFAICT, both functions are just in a #ifdef subprocesses. But, maybe,
>> in some systems, sigchld_handler is not used albeit compiled.
>>
>> The question I asked is : do we have to disable the
>> `deleted_process_alist' mechanism in some configuration to avoid that
>> it will be filled but never cleaned ?
>
> Well, as we established, at least on MS-Windows, sigchld_handler _is_
> called, so your fix should work for the Windows build, AFAIU.
So, AFAIU too, if delete_process can be called (protected by #ifdef
subprocesses), sigchld_handler can be too.
Patch updated to remove #ifdef SIGCHLD guards attached.
It addresses all the problems we've seen so far, and seems to work (AFAICT).
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.1.2: process.patch --]
[-- Type: text/x-patch, Size: 4376 bytes --]
Index: src/process.c
===================================================================
RCS file: /sources/emacs/emacs/src/process.c,v
retrieving revision 1.481
diff -c -r1.481 process.c
*** src/process.c 8 May 2006 05:19:42 -0000 1.481
--- src/process.c 29 May 2006 22:26:17 -0000
***************
*** 778,783 ****
--- 778,791 ----
return proc;
}
+
+ /* Fdelete_process promises to immediately forget about the process, but in
+ reality, Emacs needs to remember those processes until they have been
+ treated by sigchld_handler; otherwise this handler would consider the
+ process as being synchronous and say that the synchronous process is
+ dead. */
+ static Lisp_Object deleted_pid_list;
+
DEFUN ("delete-process", Fdelete_process, Sdelete_process, 1, 1, 0,
doc: /* Delete PROCESS: kill it and forget about it immediately.
PROCESS may be a process, a buffer, the name of a process or buffer, or
***************
*** 799,810 ****
}
else if (XINT (p->infd) >= 0)
{
! Fkill_process (process, Qnil);
! /* Do this now, since remove_process will make sigchld_handler do nothing. */
! p->status
! = Fcons (Qsignal, Fcons (make_number (SIGKILL), Qnil));
! XSETINT (p->tick, ++process_tick);
! status_notify (p);
}
remove_process (process);
return Qnil;
--- 807,835 ----
}
else if (XINT (p->infd) >= 0)
{
! Lisp_Object symbol;
!
! /* No problem storing the pid here, as it is still in Vprocess_alist. */
! deleted_pid_list = Fcons (make_fixnum_or_float (p->pid),
! /* GC treated elements set to nil. */
! Fdelq (Qnil, deleted_pid_list));
! /* If the process has already signaled, remove it from the list. */
! if (p->raw_status_new)
! update_status (p);
! symbol = p->status;
! if (CONSP (p->status))
! symbol = XCAR (p->status);
! if (EQ (symbol, Qsignal) || EQ (symbol, Qexit))
! Fdelete (make_fixnum_or_float (p->pid), deleted_pid_list);
! else
! {
! Fkill_process (process, Qnil);
! /* Do this now, since remove_process will make sigchld_handler do nothing. */
! p->status
! = Fcons (Qsignal, Fcons (make_number (SIGKILL), Qnil));
! XSETINT (p->tick, ++process_tick);
! status_notify (p);
! }
}
remove_process (process);
return Qnil;
***************
*** 6373,6378 ****
--- 6398,6412 ----
/* Find the process that signaled us, and record its status. */
+ /* The process can have been deleted by Fdelete_process. */
+ tail = Fmember (make_fixnum_or_float (pid), deleted_pid_list);
+ if (!NILP (tail))
+ {
+ Fsetcar (tail, Qnil);
+ goto sigchld_end_of_loop;
+ }
+
+ /* Otherwise, if it is asynchronous, it is in Vprocess_alist. */
p = 0;
for (tail = Vprocess_alist; GC_CONSP (tail); tail = XCDR (tail))
{
***************
*** 6424,6431 ****
EMACS_SET_SECS_USECS (*input_available_clear_time, 0, 0);
}
! /* There was no asynchronous process found for that id. Check
! if we have a synchronous process. */
else
{
synch_process_alive = 0;
--- 6458,6465 ----
EMACS_SET_SECS_USECS (*input_available_clear_time, 0, 0);
}
! /* There was no asynchronous process found for that pid: we have
! a synchronous process. */
else
{
synch_process_alive = 0;
***************
*** 6442,6447 ****
--- 6476,6485 ----
EMACS_SET_SECS_USECS (*input_available_clear_time, 0, 0);
}
+
+ sigchld_end_of_loop:
+ ;
+
/* On some systems, we must return right away.
If any more processes want to signal us, we will
get another signal.
***************
*** 6843,6848 ****
--- 6881,6887 ----
FD_SET (0, &input_wait_mask);
Vprocess_alist = Qnil;
+ deleted_pid_list = Qnil;
for (i = 0; i < MAXDESC; i++)
{
chan_process[i] = Qnil;
***************
*** 6981,6986 ****
--- 7020,7026 ----
staticpro (&Qlast_nonmenu_event);
staticpro (&Vprocess_alist);
+ staticpro (&deleted_pid_list);
DEFVAR_BOOL ("delete-exited-processes", &delete_exited_processes,
doc: /* *Non-nil means delete processes immediately when they exit.
[-- Attachment #1.1.3: Type: text/plain, Size: 323 bytes --]
--
| Michaël `Micha' Cadilhac | Le copillage-collage |
| Epita/LRDE Promo 2007 | tue le programmeur. |
| http://www.lrde.org/~cadilh_m | -- Dictons LRDE |
`-- - JID: micha@amessage.be --' - --'
[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]
[-- Attachment #2: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2006-05-29 22:32 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-24 19:36 Ispell loads dict twice Michaël Cadilhac
2006-04-26 10:14 ` Agustin Martin
2006-04-26 21:58 ` Michaël Cadilhac
2006-05-23 18:26 ` Michaël Cadilhac
2006-05-24 11:28 ` Agustin Martin
2006-05-25 10:57 ` delete-process bug (was: Ispell loads dict twice.) Michaël Cadilhac
2006-05-25 12:19 ` Agustin Martin
2006-05-25 14:55 ` delete-process bug Stefan Monnier
2006-05-25 14:59 ` David Kastrup
2006-05-25 15:17 ` Michaël Cadilhac
2006-05-25 15:26 ` David Kastrup
2006-05-25 19:40 ` Stefan Monnier
2006-05-25 23:51 ` Kim F. Storm
2006-05-26 4:49 ` Richard Stallman
2006-05-26 13:03 ` Stefan Monnier
2006-05-26 2:22 ` Richard Stallman
2006-05-26 11:29 ` Michaël Cadilhac
2006-05-27 3:36 ` Richard Stallman
2006-05-26 13:10 ` Stefan Monnier
2006-05-26 17:27 ` Michael Mauger
2006-05-27 9:19 ` Michaël Cadilhac
2006-05-27 14:16 ` Stefan Monnier
2006-05-27 14:29 ` Michaël Cadilhac
2006-05-28 16:01 ` Michaël Cadilhac
2006-05-28 18:00 ` Stefan Monnier
2006-05-28 18:32 ` Michaël Cadilhac
2006-05-28 19:48 ` Stefan Monnier
2006-05-28 20:26 ` Michaël Cadilhac
2006-05-28 21:15 ` Kim F. Storm
2006-05-28 21:36 ` Michaël Cadilhac
2006-05-28 23:54 ` Stefan Monnier
2006-05-29 11:39 ` Michaël Cadilhac
2006-05-29 8:22 ` Kim F. Storm
2006-05-29 8:50 ` David Kastrup
2006-05-29 19:04 ` Eli Zaretskii
2006-05-29 19:27 ` Eli Zaretskii
2006-05-29 21:42 ` Kim F. Storm
2006-05-29 22:08 ` Eli Zaretskii
2006-05-29 3:32 ` Eli Zaretskii
2006-05-29 8:14 ` Kim F. Storm
2006-05-29 10:59 ` Michaël Cadilhac
2006-05-29 19:25 ` Eli Zaretskii
2006-05-29 20:04 ` Michaël Cadilhac
2006-05-29 21:24 ` Eli Zaretskii
2006-05-29 21:42 ` Michaël Cadilhac
2006-05-29 22:11 ` Eli Zaretskii
2006-05-29 22:32 ` Michaël Cadilhac [this message]
2006-05-30 12:11 ` Kim F. Storm
2006-05-30 12:42 ` Michaël Cadilhac
2006-05-30 14:26 ` Kim F. Storm
2006-05-30 15:13 ` Michaël Cadilhac
2006-06-01 14:06 ` Kim F. Storm
2006-06-01 14:20 ` Michaël Cadilhac
2006-06-01 14:29 ` Kim F. Storm
2006-06-01 16:05 ` Michaël Cadilhac
2006-06-02 7:46 ` Kim F. Storm
2006-06-01 16:41 ` Agustin Martin
2006-06-01 16:55 ` Michaël Cadilhac
2006-05-29 23:07 ` Agustin Martin
2006-05-25 23:52 ` delete-process bug (was: Ispell loads dict twice.) Kim F. Storm
2006-06-06 20:45 ` Ispell loads dict twice Michaël Cadilhac
2006-06-09 13:02 ` Kim F. Storm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871wucfona.fsf@lrde.org \
--to=michael.cadilhac@lrde.org \
--cc=agustin.martin@hispalinux.es \
--cc=emacs-devel@gnu.org \
--cc=storm@cua.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.