[seltenreich@gmx.de: Patch: make navigation work as documented in easy-mmode derived modes]

[seltenreich@gmx.de: Patch: make navigation work as documented in easy-mmode derived modes]

[Richard Stallman]

Would someone please install this, then ack?

------- Start of forwarded message -------
From: Andreas Seltenreich <seltenreich@gmx.de>
To: emacs-devel@gnu.org
Date: Mon, 27 Nov 2006 16:44:19 +0100
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Patch: make navigation work as documented in easy-mmode derived
	modes
X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=failed 
	version=3.0.4

I just noticed that prefix args didn't work when navigating in
diff-mode, contrary to the docstrings of the functions.

The attached patch fixes it for me.

regards,
andreas

Index: lisp/ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.10357
diff -u -0 -r1.10357 ChangeLog
- --- lisp/ChangeLog	27 Nov 2006 14:35:47 -0000	1.10357
+++ lisp/ChangeLog	27 Nov 2006 15:21:37 -0000
@@ -0,0 +1,6 @@
+2006-11-27  Andreas Seltenreich  <uwi7@rz.uni-karlsruhe.de>
+
+	* emacs-lisp/easy-mmode.el (easy-mmode-define-navigation): Fix
+	interactive spec of the functions getting defined to make them
+	work as documented.
+
Index: lisp/emacs-lisp/easy-mmode.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/emacs-lisp/easy-mmode.el,v
retrieving revision 1.78
diff -u -r1.78 easy-mmode.el
- --- lisp/emacs-lisp/easy-mmode.el	31 Aug 2006 23:14:26 -0000	1.78
+++ lisp/emacs-lisp/easy-mmode.el	27 Nov 2006 15:22:45 -0000
@@ -500,7 +500,7 @@
 		    ,(concat "^No \\(previous\\|next\\) " (regexp-quote name)))
        (defun ,next-sym (&optional count)
 	 ,(format "Go to the next COUNT'th %s." name)
- -	 (interactive)
+	 (interactive "p")
 	 (unless count (setq count 1))
 	 (if (< count 0) (,prev-sym (- count))
 	   (if (looking-at ,re) (setq count (1+ count)))
@@ -523,7 +523,7 @@
        (put ',next-sym 'definition-name ',base)
        (defun ,prev-sym (&optional count)
 	 ,(format "Go to the previous COUNT'th %s" (or name base-name))
- -	 (interactive)
+	 (interactive "p")
 	 (unless count (setq count 1))
 	 (if (< count 0) (,next-sym (- count))
            (let (was-narrowed)


_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
------- End of forwarded message -------

Re: [seltenreich@gmx.de: Patch: make navigation work as documented in easy-mmode derived modes]

[Chong Yidong]

Richard Stallman <rms@gnu.org> writes:

> Would someone please install this, then ack?

Done.

> From: Andreas Seltenreich <seltenreich@gmx.de>
> Subject: Patch: make navigation work as documented in easy-mmode derived modes
> To: emacs-devel@gnu.org
>
> I just noticed that prefix args didn't work when navigating in
> diff-mode, contrary to the docstrings of the functions.
>
> The attached patch fixes it for me.