Re: [cjm@pobox.com: Case-insensitive partial-completion bug]

[Chong Yidong <cyd@stupidchicken.com>]

Richard Stallman <rms@gnu.org> writes:

>     I hope the bug below will get fixed. I run into it quite frequently
>     when reading Info:
>
>       emacs -Q -f partial-completion-mode -f info-emacs-manual
>
>       `g mark RET' doesn't select and exit minibuffer.
>
> I don't use Partial Completion mode.  Is this a bug in it?
> It looks that way, but I can't be sure.
>
> If it is, does anyone want to fix it?

I think this is an oversight in the logic of `PC-do-completion'.  The
following patch should fix it.

*** emacs/lisp/complete.el.~1.59.~	2007-01-21 08:38:26.000000000 -0500
--- emacs/lisp/complete.el	2007-03-04 13:28:25.000000000 -0500
***************
*** 404,411 ****
  
      ;; Check if buffer contents can already be considered complete
      (if (and (eq mode 'exit)
! 	     (test-completion-ignore-case str table pred))
! 	'complete
  
        ;; Do substitutions in directory names
        (and filename
--- 404,418 ----
  
      ;; Check if buffer contents can already be considered complete
      (if (and (eq mode 'exit)
! 	     (test-completion str table pred))
! 	(progn
! 	  ;; If completion-ignore-case is non-nil, insert the
! 	  ;; completion string since that may have a different case.
! 	  (when completion-ignore-case
! 	    (setq str (try-completion str table pred))
! 	    (delete-region beg end)
! 	    (insert str))
! 	  'complete)
  
        ;; Do substitutions in directory names
        (and filename