From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Yoni Rabkin Katzenell Newsgroups: gmane.emacs.devel Subject: Re: Uninformative comment in files.el Date: Wed, 12 Dec 2007 17:41:59 +0200 Message-ID: <871w9rudh4.fsf@actcom.com> References: <475EF93E.3060203@ig.com.br> <475F0992.2030307@gmx.at> <475F45EB.2070704@ig.com.br> <87mysg1l17.fsf@actcom.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1197474428 21133 80.91.229.12 (12 Dec 2007 15:47:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 12 Dec 2007 15:47:08 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 12 16:47:20 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1J2Tnm-0002AA-Fl for ged-emacs-devel@m.gmane.org; Wed, 12 Dec 2007 16:47:14 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J2TnU-0000Wr-Hu for ged-emacs-devel@m.gmane.org; Wed, 12 Dec 2007 10:46:56 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J2TmQ-0007XN-Cl for emacs-devel@gnu.org; Wed, 12 Dec 2007 10:45:50 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J2TmM-0007Rj-IL for emacs-devel@gnu.org; Wed, 12 Dec 2007 10:45:49 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J2TmL-0007RB-VA for emacs-devel@gnu.org; Wed, 12 Dec 2007 10:45:46 -0500 Original-Received: from sa10.bezeqint.net ([192.115.104.24]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J2TmL-0002Fn-ML for emacs-devel@gnu.org; Wed, 12 Dec 2007 10:45:45 -0500 Original-Received: from localhost (unknown [127.0.0.1]) by sa10.bezeqint.net (Bezeq International SMTP out Mail Server) with ESMTP id 7CA90106944 for ; Wed, 12 Dec 2007 17:43:47 +0200 (IST) Original-Received: from sa10.bezeqint.net ([127.0.0.1]) by localhost (sa10.bezeqint.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 08854-05 for ; Wed, 12 Dec 2007 17:43:37 +0200 (IST) Original-Received: from ardbeg.actcom.com (unknown [212.179.253.14]) by sa10.bezeqint.net (Bezeq International SMTP out Mail Server) with ESMTP for ; Wed, 12 Dec 2007 17:43:36 +0200 (IST) X-Ethics: Use GNU In-Reply-To: (Stefan Monnier's message of "Wed, 12 Dec 2007 10:20:16 -0500") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.50 (gnu/linux) X-Virus-Scanned: amavisd-new at bezeqint.net X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:85098 Archived-At: Stefan Monnier writes: >> After reading that thread (which I neglected to do beforehand, sorry) I >> still think that revert-buffer should remove all overlays and the mark. > > I disagree. Anything that's not a minor mode will suffer from similar > problems and setting revert-buffer-function is not an option for them. > Your change will cause problems for the other category of minor-mode > like packages: those that need their overlays to survive a revert-buffer. Maybe what confuses me is that it is called `revert-buffer' and not something like `revert-to-file-contents'. I'd expect the former to revert the buffer to a pristine state, but the latter to only change the contents as they relate to the associated file. I'll recapitulate what I wrote in a separate response: I'll wait until it is clear what you guys want to do with `revert-buffer' (if anything), then I'll see if I can help implement that. Currently I'm both unclear as to the purpose of the function, and obviously ignorant of the subtleties. -- "Cut your own wood and it will warm you twice"