From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: bookmark.el and lisp/gnus/gnus-bookmark.el Date: Fri, 07 Mar 2008 16:12:50 +0100 Message-ID: <871w6m8t59.fsf@member.fsf.org> References: <874pbj682f.fsf@red-bean.com> <87zltbhbq8.fsf@bzg.ath.cx> <87iqzzigv6.fsf@bzg.ath.cx> <87ejan7xhq.fsf@member.fsf.org> <87hcfi3egg.fsf@bzg.ath.cx> <87abla8w6b.fsf@member.fsf.org> <87bq5qhba6.fsf@bzg.ath.cx> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1204902791 26690 80.91.229.12 (7 Mar 2008 15:13:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 7 Mar 2008 15:13:11 +0000 (UTC) Cc: Karl Fogel , Stefan Monnier , Reiner Steib , emacs-devel@gnu.org To: Bastien Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 07 16:13:37 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JXeGL-0005mx-7I for ged-emacs-devel@m.gmane.org; Fri, 07 Mar 2008 16:13:33 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JXeFn-0004as-B1 for ged-emacs-devel@m.gmane.org; Fri, 07 Mar 2008 10:12:59 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JXeFk-0004an-G7 for emacs-devel@gnu.org; Fri, 07 Mar 2008 10:12:56 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JXeFi-0004ab-PM for emacs-devel@gnu.org; Fri, 07 Mar 2008 10:12:55 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JXeFi-0004aY-Ml for emacs-devel@gnu.org; Fri, 07 Mar 2008 10:12:54 -0500 Original-Received: from out4.smtp.messagingengine.com ([66.111.4.28]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JXeFi-0001Fx-HV for emacs-devel@gnu.org; Fri, 07 Mar 2008 10:12:54 -0500 Original-Received: from compute1.internal (compute1.internal [10.202.2.41]) by out1.messagingengine.com (Postfix) with ESMTP id 41A3BB853C; Fri, 7 Mar 2008 10:12:54 -0500 (EST) Original-Received: from heartbeat1.messagingengine.com ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 07 Mar 2008 10:12:54 -0500 X-Sasl-enc: 4w5ltCsYbuK/WqHl6zlvCTDJoL5XvxYBbF0PzAUS/nov 1204902773 Original-Received: from localhost (dslb-084-063-012-045.pools.arcor-ip.net [84.63.12.45]) by mail.messagingengine.com (Postfix) with ESMTPA id 31FFF3526; Fri, 7 Mar 2008 10:12:51 -0500 (EST) Mail-Followup-To: Bastien , Stefan Monnier , Karl Fogel , Reiner Steib , emacs-devel@gnu.org In-Reply-To: <87bq5qhba6.fsf@bzg.ath.cx> (Bastien's message of "Fri, 07 Mar 2008 14:13:53 +0000") User-Agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:91636 Archived-At: Bastien writes: >>>> Hm, looking at the code `bookmark-buffer-file-name' is only called >>>> for buffers that don't have `bookmark-make-record-function' set >>>> locally, so I don't see why you would need that? >>> >>> I think you mean: `bookmark-make-cell-function', right? >> >> Nope, Karl has renamed it to bookmark-make-record-function. > > No, there is both > > bookmark-make-record-function (line 466) > bookmark-make-cell-function (line 741) Yeah, but I think Karl missed the second one (make-cell) while renaming. I've already sent him a mail. Looking at the code of bookmark-set, I think I'm right. (or (local-variable-p 'bookmark-make-cell-function) (bookmark-buffer-file-name) (error "Buffer not visiting a file or directory")) If the record-creation is done by another mode, it's fine. Else, if (bookmark-buffer-file-name) returns nil, which it does for buffers with no file, error. This is needed, because if bookmark-make-record-function is not set by the mode, the default bookmark-make-record-for-text-file will be used, and that works only with buffers associated with a file. >>> Now a mode can define `bookmark-make-cell-function' so that it tells >>> bookmark.el how to set the name of the bookmark. >> >> Now it's bookmark-make-record-function, but that has been there (as >> b-m-cell-f) for a while now... > > I think there is a misunderstanding somewhere. Yep, and I think exceptionally not on my side. :) Bye, Tassilo