From: Chong Yidong <cyd@stupidchicken.com>
To: Lars Lindberg <Lars.Lindberg@sypro.cap.se>
Cc: 1948@emacsbugs.donarmstrong.com, Peter Tury <tury.peter@gmail.com>
Subject: bug#1948: confusion and bug in dabbrev.el
Date: Mon, 19 Jan 2009 09:54:48 -0500 [thread overview]
Message-ID: <871vuzpcqv.fsf@cyd.mit.edu> (raw)
Hi Lars, could you take a look at this bug report for dabbrev? Thanks.
Peter Tury <tury.peter@gmail.com> wrote:
> 1) in `dabbrev--substitute-expansion' (in dabbrev.el), `t' value of
> variable `dabbrev-eliminate-newlines' causes elimination of spaces
> (and tabs) as well. Thus its name and its functionality are not really
> compatible. In the best case it should have a better name
> (`dabbrev-eliminate-whitespace'??), but as a minimum, its
> documentation should be improved and mention elimination of tabs and
> spaces as well, I think.
> Moreover, contrary to its documentation again, it doesn't "converts
> them [=newlines] to spaces": instead it just removes them. So its
> documentation should be fixed here as well in my opinion.
> 2) However, the more serious problem is that it "forgets" such
> eliminations when it searches for `old' expansion in case of repeated
> calls of `dabbrev-expand' (i.e. when the check "(eq last-command
> this-command)" in this function results t) what results in weird text
> in some cases. To check this:
> * customize `dabbrev-abbrev-char-regexp' to be a period (.) Thus
> dabbrev-expand will replace whole lines.
> * type these two lines into a buffer (with double spaces between the
> words!):
> one tt
> one ww
> * then type "on" in the next line and call `dabbrev-expand' two times.
> Your buffer should look like this at the end:
> one tt
> one ww
> one tt
> But instead you will get this:
> one tt
> one tt
> one ww
> What seems to be a complete mess.
> As I see the key here is the search for `old' at the end of
> `dabbrev--substitute-expansion' (`old' is the first parameter of this
> function). If I replace the following original code:
> " (if old
> (save-excursion
> (search-backward old))"
> to be
> " (if old
> ;; Convert whitespace to single spaces.
> (progn
> (if dabbrev-eliminate-newlines
> (let ((pos
> (if (equal abbrev " ") 0 (length abbrev))))
> ;; If ABBREV is real, search after the end of it.
> ;; If ABBREV is space and we are copying
> successive words,
> ;; search starting at the front.
> (while (string-match "[\n \t]+"
> old pos)
> (setq pos (1+
> (match-beginning 0)))
> (setq old
> (replace-match
> " " nil
> nil
> old)))))
> (save-excursion
> (search-backward
> old)))"
> my test (above) works well. Here I simply copy-pasted (...) original
> whitespace-elimination code from few lines above, so this is clearly
> not a nice solution: it just shows a way of fixing the broken
> functionality.
> (I "reported" this problem in gnu.emacs.help with the subject "strange
> dabbrev for whole lines and double spaces in cvs Emacs 23" on
> Jan.8.2009)
next reply other threads:[~2009-01-19 14:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 14:54 Chong Yidong [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-01-18 19:37 bug#1948: confusion and bug in dabbrev.el Peter Tury
2012-09-12 19:22 ` Fred
2016-01-09 23:36 ` Alan J Third
2016-01-10 13:41 ` Alan J Third
2016-01-30 1:01 ` Alan Third
2016-01-30 2:00 ` Drew Adams
2016-01-30 11:59 ` Alan Third
2016-01-30 12:25 ` Eli Zaretskii
2016-01-30 17:37 ` Drew Adams
2016-02-29 4:18 ` Lars Ingebrigtsen
2016-02-29 4:18 ` Lars Ingebrigtsen
2016-03-01 3:16 ` Glenn Morris
2016-03-01 3:16 ` Glenn Morris
2016-03-01 3:27 ` Lars Ingebrigtsen
2016-01-30 1:01 ` Alan Third
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871vuzpcqv.fsf@cyd.mit.edu \
--to=cyd@stupidchicken.com \
--cc=1948@emacsbugs.donarmstrong.com \
--cc=Lars.Lindberg@sypro.cap.se \
--cc=tury.peter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.