From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: x-popup-menu Date: Tue, 10 Nov 2009 02:43:48 +0200 Organization: JURTA Message-ID: <871vk78dsb.fsf@mail.jurta.org> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1257814687 7573 80.91.229.12 (10 Nov 2009 00:58:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 10 Nov 2009 00:58:07 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 10 01:58:00 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1N7f3X-0001QP-Ns for ged-emacs-devel@m.gmane.org; Tue, 10 Nov 2009 01:57:59 +0100 Original-Received: from localhost ([127.0.0.1]:36145 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N7f3X-0006gS-DG for ged-emacs-devel@m.gmane.org; Mon, 09 Nov 2009 19:57:59 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N7f3S-0006g7-9E for emacs-devel@gnu.org; Mon, 09 Nov 2009 19:57:54 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N7f3N-0006fE-3k for emacs-devel@gnu.org; Mon, 09 Nov 2009 19:57:53 -0500 Original-Received: from [199.232.76.173] (port=51917 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N7f3N-0006f9-1G for emacs-devel@gnu.org; Mon, 09 Nov 2009 19:57:49 -0500 Original-Received: from smtp-out1.starman.ee ([85.253.0.3]:54578 helo=mx1.starman.ee) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N7f3M-0005Id-Ew for emacs-devel@gnu.org; Mon, 09 Nov 2009 19:57:48 -0500 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Original-Received: from mail.starman.ee (62.65.211.91.cable.starman.ee [62.65.211.91]) by mx1.starman.ee (Postfix) with ESMTP id 0A1D23F417A; Tue, 10 Nov 2009 02:57:41 +0200 (EET) In-Reply-To: (Stefan Monnier's message of "Mon, 09 Nov 2009 01:23:01 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:116769 Archived-At: > I've just consolidated the X(&msdos), w32, and ns code of x-popup-menu > into menu.c. > I've only tested the X11 version, and left some #ifdefs which I suspect > are not needed. Please test and fix as needed for other GUI backends, On a non-toolkit X build, `make bootstrap' fails with: xmenu.c:2320: error: static declaration of 'xmenu_show' follows non-static declaration menu.h:46: error: previous declaration of 'xmenu_show' was here make[2]: *** [xmenu.o] Error 1 where xmenu.c:2320 contains: static Lisp_Object xmenu_show (f, x, y, for_click, keymaps, title, error, timestamp) and menu.h:46 contains: extern Lisp_Object xmenu_show (FRAME_PTR, int, int, int, int, Lisp_Object, char **, EMACS_UINT); But the same function cannot be static and extern at the same time. -- Juri Linkov http://www.jurta.org/emacs/