From: Juri Linkov <juri@jurta.org>
To: enami tsugutomo <tsugutomo.enami@jp.sony.com>
Cc: 5652@debbugs.gnu.org
Subject: bug#5652: 23.1.92; Info-index puts cursor at wrong position
Date: Fri, 26 Feb 2010 11:08:27 +0200 [thread overview]
Message-ID: <871vg89yve.fsf@mail.jurta.org> (raw)
In-Reply-To: <201002260126.o1Q1Q6uq008127@memory-leak.sm.sony.co.jp> (enami tsugutomo's message of "Fri, 26 Feb 2010 10:26:06 +0900 (JST)")
> Info-index puts cursor at wrong position. The key sequence in `Recent
> input' below is the example when `save-excursion' is searched on emacs
> lisp refernec manual. Ideally (and acutually at least emacs 20.7 does)
> it puts cursor at the line here:
>
> -- Special Form: save-excursion body...
>
> .. but instead it puts 2 lines below.
>
> I guess Info-index-next should be changed as follows:
Thanks for the bug report. I think your patch is not right.
When you look at the raw Info file in info/elisp-11, you can see:
* save-excursion: Excursions. (line 20)
========
When you turn breadcrumbs off e.g. by (setq Info-breadcrumbs-depth 0),
visit (info "(elisp) Excursions") and go to the line 20, you can see
that it is the following line:
The `save-excursion' special form saves the identity of the current
So currently the incorrect offset is not 2 lines, but only 1 line.
When you see that the line 20 is "-- Special Form: save-excursion body..."
it is only when breadcrumbs insert a line directly to the Info buffer
and thus breaks line numbers. We have more troubles with breadcrumbs
and hope to fix them by displaying breadcrumbs in the header window.
Now it seems the right fix is to just decrement this offset by 1:
=== modified file 'lisp/info.el'
--- lisp/info.el 2010-02-11 20:57:10 +0000
+++ lisp/info.el 2010-02-26 09:07:27 +0000
@@ -3090,7 +3090,7 @@ (defun Info-index-next (num)
num (1- num)))
(Info-goto-node (nth 1 (car Info-index-alternatives)))
(if (> (nth 3 (car Info-index-alternatives)) 0)
- (forward-line (1- (nth 3 (car Info-index-alternatives))))
+ (forward-line (- (nth 3 (car Info-index-alternatives)) 2))
(forward-line 3) ; don't search in headers
(let ((name (car (car Info-index-alternatives))))
(Info-find-index-name name)))
BTW, the brz history seems corrupted.
Trying to see the reason why this line in `Info-index-next'
was changed last time:
(forward-line (1- (nth 3 (car Info-index-alternatives))))
I typed `C-x v g' (vc-annotate) in info.el, and it displays:
49780.1.32 henrik. | (forward-line (1- (nth 3 (car Info-index-alternatives))))
Typing `l' on this line displays the *vc-change-log* buffer:
------------------------------------------------------------
revno: 49780.1.32
committer: Henrik Enberg <henrik.enberg@telia.com>
timestamp: Mon 2006-01-16 00:03:54 +0000
message:
sync with trunk
Does anyone know is it possible to see the original log
instead of this merge commit?
--
Juri Linkov
http://www.jurta.org/emacs/
next prev parent reply other threads:[~2010-02-26 9:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-26 1:26 bug#5652: 23.1.92; Info-index puts cursor at wrong position enami tsugutomo
2010-02-26 9:08 ` Juri Linkov [this message]
2010-02-26 9:56 ` Andreas Schwab
2010-02-26 10:09 ` bug#5652: broken bzr history Juri Linkov
2010-03-01 1:01 ` broken bzr history? Glenn Morris
2010-03-01 2:20 ` Óscar Fuentes
2010-03-01 4:55 ` Stefan Monnier
2010-03-01 6:03 ` Óscar Fuentes
2010-03-02 21:19 ` bug#5652: 23.1.92; Info-index puts cursor at wrong position Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871vg89yve.fsf@mail.jurta.org \
--to=juri@jurta.org \
--cc=5652@debbugs.gnu.org \
--cc=tsugutomo.enami@jp.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.