all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@stupidchicken.com>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 'Emacs-Devel devel' <emacs-devel@gnu.org>
Subject: Re: tool-bars  - broken again
Date: Sat, 03 Jul 2010 18:27:53 -0400	[thread overview]
Message-ID: <871vbk6w0m.fsf@stupidchicken.com> (raw)
In-Reply-To: <17A106BDF5AA40A9B41416AE7E8F13CB@us.oracle.com> (Drew Adams's message of "Sat, 3 Jul 2010 12:23:34 -0700")

"Drew Adams" <drew.adams@oracle.com> writes:

> I must say, and I am trying to be polite, that I am really getting
> tired of the fiddling with the tool bars that has been going on for
> years now.  I try to have code that works across versions.  You just
> won't leave it alone, it seems.

No, we can't maintain cruft indefinitely.  The complicated interaction
between default-frame-alist and tool/menu bar mode needed simplifying.

The default value of `default-frame-alist' is now nil, unless you
explicitly set the value to something else.  It is a properly-behaved
defcustom (and so is `initial-frame-alist'); Emacs does not muck with
the value when starting up, nor when you run the `*-bar-mode' commands.

Conceptually, adding any element to `default-frame-alist' is like
implicitly supplying an argument to `make-frame'.  (Any actual argument
you supply to `make-frame' takes precedence over `default-frame-alist'.)

If no `tool-bar-lines' or `menu-bar-lines' parameter is supplied in the
`make-frame' arguments or `default-frame-alist', Emacs sets the value
from the value of `menu-bar-mode' and `tool-bar-mode'.


> In my startup code, I set `default-frame-alist' and I also turn off
> `tool-bar-mode'.  Prior to the 6/28 build, the value of
> `tool-bar-lines' in `default-frame-alist' was correctly set to 0 when
> my code turned off `tool-bar-mode'; now it is not.

You are likely setting a non-zero `tool-bar-lines' in
`default-frame-alist'.  I don't know why you would want to do this, if
your intention is to disable the tool bar.  As far as I can see, there
is no bug here.



  reply	other threads:[~2010-07-03 22:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-03 19:23 tool-bars - broken again Drew Adams
2010-07-03 22:27 ` Chong Yidong [this message]
2010-07-05 17:29   ` Drew Adams
2010-07-05 18:01     ` Chong Yidong
2010-07-05 18:59       ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871vbk6w0m.fsf@stupidchicken.com \
    --to=cyd@stupidchicken.com \
    --cc=drew.adams@oracle.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.