From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?=C3=93scar?= Fuentes Newsgroups: gmane.emacs.bugs Subject: bug#6674: PATCH: fix assignment of grep-find-use-xargs on Windows Date: Wed, 21 Jul 2010 01:18:38 +0200 Message-ID: <871vax3fox.fsf@telefonica.net> References: <878w564xtc.fsf@telefonica.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1279668656 20211 80.91.229.12 (20 Jul 2010 23:30:56 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 20 Jul 2010 23:30:56 +0000 (UTC) Cc: lekktu@gmail.com To: 6674@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 21 01:30:55 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ObMGz-0005zx-Ei for geb-bug-gnu-emacs@m.gmane.org; Wed, 21 Jul 2010 01:30:54 +0200 Original-Received: from localhost ([127.0.0.1]:48952 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ObMGv-0005Fn-PL for geb-bug-gnu-emacs@m.gmane.org; Tue, 20 Jul 2010 19:30:49 -0400 Original-Received: from [140.186.70.92] (port=56989 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ObMGo-0005EL-Mt for bug-gnu-emacs@gnu.org; Tue, 20 Jul 2010 19:30:43 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ObMGn-0007Ed-38 for bug-gnu-emacs@gnu.org; Tue, 20 Jul 2010 19:30:42 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54267) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ObMGm-0007EW-QO for bug-gnu-emacs@gnu.org; Tue, 20 Jul 2010 19:30:41 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1ObM5W-0006GW-Iq; Tue, 20 Jul 2010 19:19:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <878w564xtc.fsf@telefonica.net> Resent-From: =?UTF-8?Q?=C3=93scar?= Fuentes Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Jul 2010 23:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6674 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6674-submit@debbugs.gnu.org id=B6674.127966791024062 (code B ref 6674); Tue, 20 Jul 2010 23:19:02 +0000 Original-Received: (at 6674) by debbugs.gnu.org; 20 Jul 2010 23:18:30 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ObM50-0006G2-3k for submit@debbugs.gnu.org; Tue, 20 Jul 2010 19:18:30 -0400 Original-Received: from impaqm5.telefonica.net ([213.4.138.5]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ObM4w-0006Fw-QT for 6674@debbugs.gnu.org; Tue, 20 Jul 2010 19:18:27 -0400 Original-Received: from IMPmailhost3.adm.correo ([10.20.102.124]) by IMPaqm5.telefonica.net with bizsmtp id kP8G1e0042h2L9m3RPJg94; Wed, 21 Jul 2010 01:18:40 +0200 Original-Received: from qcore ([83.42.13.171]) by IMPmailhost3.adm.correo with BIZ IMP id kPJe1e0043hRxRf1jPJfuB; Wed, 21 Jul 2010 01:18:39 +0200 X-Brightmail-Tracker: AAAAAA== X-TE-authinfo: authemail="981711563$telefonica.net" |auth_email="981711563@telefonica.net" X-TE-AcuTerraCos: auth_cuTerraCos="cosuitnetc01" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 20 Jul 2010 19:19:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:38708 Archived-At: rgrep is broken on Windows. Although it is obvious that a general fix for the shell issue is the most correct resolution for this bug, I propose to apply the patch below and revert it once cmdproxy.c is enhanced for dealing with the problem. Otherwise, a workaround is to add (setq grep-find-use-xargs 'exec) to the user's .emacs file. 2010-07-21 =C3=93scar Fuentes * progmodes/grep.el (grep-compute-defaults): always assign 'exec to grep-find-use-xargs on Windows. =3D=3D=3D modified file 'lisp/progmodes/grep.el' *** lisp/progmodes/grep.el 2010-01-31 21:47:47 +0000 --- lisp/progmodes/grep.el 2010-07-20 23:04:56 +0000 *************** Set up `compilation-exit-message-functio *** 552,557 **** --- 552,561 ---- (unless grep-find-use-xargs (setq grep-find-use-xargs (cond + ;; Windows' shell has problems with long commands and + ;; pipes. See bug #6674. + ((eq system-type 'windows-nt) + 'exec) ((and (grep-probe find-program `(nil nil nil ,null-device "-print0")) (grep-probe xargs-program `(nil nil nil "-0" "-e" "echo")))