all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Óscar Fuentes" <ofv@wanadoo.es>
To: 6674@debbugs.gnu.org
Cc: lekktu@gmail.com
Subject: bug#6674: PATCH: fix assignment of grep-find-use-xargs on Windows
Date: Wed, 21 Jul 2010 01:18:38 +0200	[thread overview]
Message-ID: <871vax3fox.fsf@telefonica.net> (raw)
In-Reply-To: <878w564xtc.fsf@telefonica.net>

rgrep is broken on Windows. Although it is obvious that a general fix
for the shell issue is the most correct resolution for this bug, I
propose to apply the patch below and revert it once cmdproxy.c is
enhanced for dealing with the problem.

Otherwise, a workaround is to add

(setq grep-find-use-xargs 'exec)

to the user's .emacs file.


2010-07-21  Óscar Fuentes  <ofv@wanadoo.es>

	* progmodes/grep.el (grep-compute-defaults): always assign
        'exec to grep-find-use-xargs on Windows.

=== modified file 'lisp/progmodes/grep.el'
*** lisp/progmodes/grep.el	2010-01-31 21:47:47 +0000
--- lisp/progmodes/grep.el	2010-07-20 23:04:56 +0000
*************** Set up `compilation-exit-message-functio
*** 552,557 ****
--- 552,561 ----
  	(unless grep-find-use-xargs
  	  (setq grep-find-use-xargs
  		(cond
+ 		 ;; Windows' shell has problems with long commands and
+ 		 ;; pipes. See bug #6674.
+ 		 ((eq system-type 'windows-nt)
+ 		  'exec)
  		 ((and
  		   (grep-probe find-program `(nil nil nil ,null-device "-print0"))
  		   (grep-probe xargs-program `(nil nil nil "-0" "-e" "echo")))





  parent reply	other threads:[~2010-07-20 23:18 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-20  3:49 bug#6674: PATCH: fix assignment of grep-find-use-xargs on Windows/MS-DOS Óscar Fuentes
2010-07-20 12:57 ` Juanma Barranquero
2010-07-20 13:39   ` Óscar Fuentes
2010-07-20 14:24     ` Óscar Fuentes
2010-07-20 15:18       ` Juanma Barranquero
2010-07-20 16:56       ` Eli Zaretskii
2010-07-20 17:28       ` Eli Zaretskii
2010-07-20 17:42         ` Juanma Barranquero
2010-07-20 19:51         ` Óscar Fuentes
2010-07-20 21:41           ` Eli Zaretskii
2010-07-20 22:18             ` Eli Zaretskii
2010-07-21  0:38               ` Christoph
2010-07-21  1:22                 ` Óscar Fuentes
2010-08-02 10:26           ` Laimonas Vėbra
2010-08-02 15:23             ` Óscar Fuentes
2010-08-02 15:48             ` bug#6674: [PATCH] bug#6674: " Óscar Fuentes
2010-08-02 17:11               ` Andreas Schwab
2010-08-02 17:48               ` bug#6674: [PATCH fixed] " Óscar Fuentes
2010-08-02 19:07                 ` Eli Zaretskii
2010-08-02 19:47                   ` Juanma Barranquero
2010-08-02 19:57                   ` Óscar Fuentes
2010-08-02 20:11                     ` Juanma Barranquero
2010-08-02 20:15                     ` Óscar Fuentes
2010-08-03  2:56                     ` Eli Zaretskii
2010-07-20 16:46 ` bug#6674: PATCH: " Eli Zaretskii
2010-07-20 23:18 ` Óscar Fuentes [this message]
2010-07-21  0:44   ` bug#6674: PATCH: fix assignment of grep-find-use-xargs on Windows Christoph
2010-07-21  0:50     ` Juanma Barranquero
2010-07-21  0:57     ` Óscar Fuentes
2010-07-21  4:02     ` Eli Zaretskii
2010-07-21  4:05       ` Christoph
2010-08-02  2:21       ` Christoph
2010-08-02  3:10         ` Eli Zaretskii
2010-08-02  4:03           ` Christoph
2010-08-02 18:02             ` Eli Zaretskii
2010-08-02 20:17 ` bug#6674: Closing bug 6674 Óscar Fuentes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871vax3fox.fsf@telefonica.net \
    --to=ofv@wanadoo.es \
    --cc=6674@debbugs.gnu.org \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.