From: David Maus <dmaus@ictsoc.de>
To: Ivanov Dmitry <usr345@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Re[6]: programming for org-mode
Date: Mon, 09 Aug 2010 21:16:06 +0200 [thread overview]
Message-ID: <871va78umh.wl%dmaus@ictsoc.de> (raw)
In-Reply-To: <1245668073.20100808194925@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1262 bytes --]
Ivanov Dmitry wrote:
>I modified the scheme and the function. I think, that these 2 if-s
>just complicate the code for comprehension: we have 3 cases, for each
>of them we should return the appropriate value.
Yes, `cond' is more suitable here.
>All the tests work fine with the new version.
>When I tried
>(org-read-prop "(1 2 3))") -> (1 2 3)
>It gave me (1 2 3), ignoring the last ')'. Seems to be the read
>function bug.
Not sure if it is a bug or the indended behavior. `read' returns the
first valid lisp expression in finds. E.g.
(read "(a b c) foo bar") => (a b c)
I think this is good enough at this place. A complete solutation
would require to parse the entire string.
>At last I got rid of these nasty little squares on the scheme :)
:D
Of course the next step for you would be to tame the beast called git
and prepare a proper patch. The steps are:
1. create a topic branch for the fix
2. change the function, commit to topic branch and provide a proper
commit message
(http://orgmode.org/worg/org-contribute.php#sec-4)
3. create a patch against current master
4. send the patch manually or using git send-email
Best,
-- David
--
OpenPGP... 0x99ADB83B5A4478E6
Jabber.... dmjena@jabber.org
Email..... dmaus@ictsoc.de
[-- Attachment #1.2: Type: application/pgp-signature, Size: 230 bytes --]
[-- Attachment #2: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Emacs-orgmode mailing list
Please use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode
prev parent reply other threads:[~2010-08-09 19:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-15 4:52 programming for org-mode Ivanov Dmitry
2010-07-15 17:26 ` Eric Schulte
2010-07-15 20:15 ` David Maus
2010-07-15 20:21 ` David Maus
2010-07-15 21:40 ` Nick Dokos
2010-07-15 21:53 ` Eric Schulte
2010-07-15 22:17 ` Nick Dokos
2010-08-05 12:33 ` Re[2]: " Ivanov Dmitry
[not found] ` <AANLkTi=wrOCCrZxRZTGgvNKGjy2jmnogiA91bYnHAExV@mail.gmail.com>
2010-08-06 7:33 ` Re[4]: " Ivanov Dmitry
2010-08-07 13:12 ` Re[2]: " David Maus
2010-08-07 15:29 ` Re[4]: " Ivanov Dmitry
2010-08-08 6:43 ` David Maus
2010-08-08 15:49 ` Re[6]: " Ivanov Dmitry
2010-08-09 19:16 ` David Maus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871va78umh.wl%dmaus@ictsoc.de \
--to=dmaus@ictsoc.de \
--cc=emacs-orgmode@gnu.org \
--cc=usr345@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.