From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.bugs Subject: bug#7190: Crash in menus on w32 Date: Fri, 22 Oct 2010 22:09:29 +0800 Message-ID: <871v7iz5d2.fsf@home.jasonrumney.net> References: <4CC01FDD.5060707@gmx.de> <877hhb4ldd.fsf@home.jasonrumney.net> <4CC0735E.5080406@gmx.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1287757786 26015 80.91.229.12 (22 Oct 2010 14:29:46 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 22 Oct 2010 14:29:46 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org To: grischka Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 22 16:29:44 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P9Ick-0007jK-U2 for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Oct 2010 16:29:39 +0200 Original-Received: from localhost ([127.0.0.1]:43351 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P9Ick-00024a-94 for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Oct 2010 10:29:38 -0400 Original-Received: from [140.186.70.92] (port=55800 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P9IMS-0008Uw-Ih for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2010 10:12:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P9IMO-0003r4-KX for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2010 10:12:48 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45124) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P9IMO-0003qv-Iz for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2010 10:12:44 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1P9IFt-00035E-TQ; Fri, 22 Oct 2010 10:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jason Rumney Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Oct 2010 14:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7190 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: Original-Received: via spool by submit@debbugs.gnu.org id=B.128775635511844 (code B ref -1); Fri, 22 Oct 2010 14:06:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Oct 2010 14:05:55 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P9IFn-00034z-EM for submit@debbugs.gnu.org; Fri, 22 Oct 2010 10:05:55 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P9IFk-00034t-MM for submit@debbugs.gnu.org; Fri, 22 Oct 2010 10:05:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P9IJR-0002GM-M5 for submit@debbugs.gnu.org; Fri, 22 Oct 2010 10:09:46 -0400 Original-Received: from lists.gnu.org ([199.232.76.165]:39996) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P9IJR-0002GI-K3 for submit@debbugs.gnu.org; Fri, 22 Oct 2010 10:09:41 -0400 Original-Received: from [140.186.70.92] (port=53703 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P9IJQ-0005op-51 for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2010 10:09:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P9IJM-0002FL-4B for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2010 10:09:39 -0400 Original-Received: from mail-iw0-f180.google.com ([209.85.214.180]:56767) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P9IJM-0002F3-0Y for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2010 10:09:36 -0400 Original-Received: by iwn37 with SMTP id 37so1057471iwn.39 for ; Fri, 22 Oct 2010 07:09:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:received:from:to:cc :subject:references:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=+LxsbM6Hk58wKHxTbG1cN2xP6eThOC9i54FK2tmSmyk=; b=j9vZOsIWcfKeYUUs7nKauetjiE8f1KQg6HPQt3Y8esox7kRek3rkAl1nR6fwjwdvlW wn3bdyat23P0QWZwXhRSuy5TRhVSC46G65EZkI56bNAD2qu7i3tTI0Jvr3NyaqMZzTsc X0T6kFocZNqKAIo2i6+DdSFhfTX/tU3RHxg78= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; b=omHJ6fFkdPW1/C28XaPOfScGkc3XjB6TENztDdr9nOmqKpRwrAmZnJQgXw2sz+52Mp jgbk1HBHyqHOW23dskfO1H3Cmz+C3hcI5wiv8UodtJK+m/SguVbeTYvysxrpDaYm5iEJ PDfpwwjZA4Hzgfb2FBx5Ok2ejWiynd7oh+tYY= Original-Received: by 10.231.157.9 with SMTP id z9mr2643268ibw.48.1287756575445; Fri, 22 Oct 2010 07:09:35 -0700 (PDT) Original-Received: from home.jasonrumney.net ([202.87.221.130]) by mx.google.com with ESMTPS id gy41sm3341175ibb.11.2010.10.22.07.09.32 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 22 Oct 2010 07:09:33 -0700 (PDT) Original-Received: by home.jasonrumney.net (Postfix, from userid 1000) id 7B17B10D1; Fri, 22 Oct 2010 22:09:29 +0800 (MYT) In-Reply-To: <4CC0735E.5080406@gmx.de> (grischka's message of "Thu, 21 Oct 2010 19:07:42 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 22 Oct 2010 10:06:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:41065 Archived-At: grischka writes: >> The above code was to fix a memory and resource leak in that case. > > With the patch, leaking these strings cannot happen by design also > provided the MENUITEMs themselves are destroyed correctly always which > is made sure by bugs 2/3 fixed: >>> 2) memory leak: was trying to free items from already deleted menu >>> 3) memory leak: was trying to free menu from already deleted window OK, I understand now - it seems you have fixed the underlying bug that caused that memory leak to happen in the first place, so the timer kludge is no longer neccesary.