bug#7881: 23.2.91; Bold spaces sometimes(?) underlined in man pages

bug#7881: 23.2.91; Bold spaces sometimes(?) underlined in man pages

[Reuben Thomas]

If I view abort(3) in Emacs 23.2.91 on my GNU/Linux system, I get a line

       #include <stdlib.h>

where the space between “include” and “<stdlib.h>” is shown underlined.
None of the rest of the text is underlined. This does not happen in an
xterm, and the markup is:

\fB#include <stdlib.h>

which looks fine.

To reproduce, from emacs -Q: M-x man abort RET


In GNU Emacs 23.2.91.4 (i686-pc-linux-gnu, GTK+ Version 2.22.0)
 of 2011-01-13 on canta
Windowing system distributor `The X.Org Foundation', version 11.0.10900000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_GB.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: C/l

Minor modes in effect:
  diff-auto-refine-mode: t
  shell-dirtrack-mode: t
  flyspell-mode: t
  recentf-mode: t
  show-paren-mode: t
  savehist-mode: t
  minibuffer-electric-default-mode: t
  iswitchb-mode: t
  icomplete-mode: t
  global-whitespace-mode: t
  whitespace-mode: t
  global-auto-revert-mode: t
  desktop-save-mode: t
  yas/global-mode: t
  yas/minor-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t
  abbrev-mode: t

Recent input:
<backspace> <backspace> <backspace> <backspace> r e 
p <return> SPC d i e SPC * . c <return> M-x g r e p 
<return> e x i t SPC * . c <return> <M-backspace> r 
e t u r n SPC - <backspace> - <backspace> - E B A D 
F <left> <left> <left> <left> <left> <backspace> C-e 
; <return> b r e a k ; <return> } C-x C-s C-a <up> 
<up> C-k C-n C-n C-s C-y C-g C-a C-y C-p <tab> <up> 
<up> <up> <up> <down> C-a C-k C-k C-_ C-_ C-n C-k C-_ 
C-_ C-_ C-_ C-_ C-_ C-_ C-_ C-n C-n C-e <return> r 
e t u r n SPC <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> a b o <backspace> <backspace> 
<backspace> <backspace> a b o r t SPC 9 ) <backspace> 
<backspace> <backspace> S-SPC ( ) ; C-x C-s C-a C-o 
C-n C-e SPC / * S-SPC C a n ' t SPC g e t SPC h e r 
e . * SPC ? <backspace> <backspace> / <backspace> <backspace> 
SPC * / C-x C-s M-x m a n <return> a a <backspace> 
b o r t <return> C-x b <return> C-x b <return> C-n 
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-p C-p C-p C-p 
C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f 
C-f C-f C-f C-f C-f C-f C-b C-b C-b C-b C-a C-f C-f 
C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f 
C-f C-b C-x k <return> M-SPC M-x r e p o r t - e m 
a c s - b u g <return> m a n SPC p a g e s SPC C-g 
M-x m <backspace> r e p o r t - e m <tab> <return>

Recent messages:
Undo! [3 times]
Redo! [2 times]
Undo! [5 times]
Saving file /home/rrt/repo/grep-decompress/src/zinput.c...
Wrote /home/rrt/repo/grep-decompress/src/zinput.c
Saving file /home/rrt/repo/grep-decompress/src/zinput.c...
Wrote /home/rrt/repo/grep-decompress/src/zinput.c
Invoking man abort in the background
Please wait: formatting the abort man page...
abort man page formatted
Quit

Load-path shadows:
/home/rrt/.emacs.d/elpa/ruby-mode-1.1/ruby-mode hides /usr/share/emacs-snapshot/site-lisp/ruby1.8-elisp/ruby-mode
/home/rrt/local/share/emacs/site-lisp/popup hides /usr/local/share/emacs/23.2.91/site-lisp/auto-complete/popup
/home/rrt/local/share/emacs/site-lisp/fuzzy hides /usr/local/share/emacs/23.2.91/site-lisp/auto-complete/fuzzy
/home/rrt/.emacs.d/elpa/css-mode-1.0/css-mode hides /usr/local/share/emacs/23.2.91/site-lisp/css-mode/css-mode
/home/rrt/.emacs.d/elpa/dictionary-1.8.7/link hides /usr/local/share/emacs/23.2.91/site-lisp/dictionary-el/link
/home/rrt/.emacs.d/elpa/dictionary-1.8.7/connection hides /usr/local/share/emacs/23.2.91/site-lisp/dictionary-el/connection
/home/rrt/.emacs.d/elpa/dictionary-1.8.7/dictionary-init hides /usr/local/share/emacs/23.2.91/site-lisp/dictionary-el/dictionary-init
/home/rrt/.emacs.d/elpa/dictionary-1.8.7/dictionary hides /usr/local/share/emacs/23.2.91/site-lisp/dictionary-el/dictionary
/home/rrt/.emacs.d/elpa/css-mode-1.0/css-mode hides /usr/local/share/emacs/23.2.91/lisp/textmodes/css-mode
/home/rrt/.emacs.d/elpa/ruby-mode-1.1/ruby-mode hides /usr/local/share/emacs/23.2.91/lisp/progmodes/ruby-mode
/home/rrt/.emacs.d/elpa/css-mode-1.0/css-mode hides /usr/share/emacs/site-lisp/css-mode/css-mode
/usr/local/share/emacs/23.2.91/site-lisp/auctex/tex-info hides /usr/share/emacs/site-lisp/auctex/tex-info
/usr/local/share/emacs/23.2.91/site-lisp/auctex/context-nl hides /usr/share/emacs/site-lisp/auctex/context-nl
/usr/local/share/emacs/23.2.91/site-lisp/auctex/context-en hides /usr/share/emacs/site-lisp/auctex/context-en
/usr/local/share/emacs/23.2.91/site-lisp/auctex/latex hides /usr/share/emacs/site-lisp/auctex/latex
/usr/local/share/emacs/23.2.91/site-lisp/auctex/tex-mik hides /usr/share/emacs/site-lisp/auctex/tex-mik
/usr/local/share/emacs/23.2.91/site-lisp/dictionary-el/lpath hides /usr/share/emacs/site-lisp/auctex/lpath
/usr/local/share/emacs/23.2.91/site-lisp/auctex/tex-buf hides /usr/share/emacs/site-lisp/auctex/tex-buf
/usr/local/share/emacs/23.2.91/site-lisp/auctex/tex-jp hides /usr/share/emacs/site-lisp/auctex/tex-jp
/usr/local/share/emacs/23.2.91/site-lisp/auctex/tex-bar hides /usr/share/emacs/site-lisp/auctex/tex-bar
/usr/local/share/emacs/23.2.91/site-lisp/auctex/tex hides /usr/share/emacs/site-lisp/auctex/tex
/usr/local/share/emacs/23.2.91/site-lisp/auctex/multi-prompt hides /usr/share/emacs/site-lisp/auctex/multi-prompt
/usr/local/share/emacs/23.2.91/site-lisp/auctex/tex-fptex hides /usr/share/emacs/site-lisp/auctex/tex-fptex
/usr/local/share/emacs/23.2.91/site-lisp/auctex/tex-font hides /usr/share/emacs/site-lisp/auctex/tex-font
/usr/local/share/emacs/23.2.91/site-lisp/auctex/tex-fold hides /usr/share/emacs/site-lisp/auctex/tex-fold
/usr/local/share/emacs/23.2.91/site-lisp/auctex/texmathp hides /usr/share/emacs/site-lisp/auctex/texmathp
/usr/local/share/emacs/23.2.91/site-lisp/auctex/context hides /usr/share/emacs/site-lisp/auctex/context
/usr/local/share/emacs/23.2.91/site-lisp/auctex/font-latex hides /usr/share/emacs/site-lisp/auctex/font-latex
/usr/local/share/emacs/23.2.91/site-lisp/auctex/bib-cite hides /usr/share/emacs/site-lisp/auctex/bib-cite
/usr/local/share/emacs/23.2.91/site-lisp/auctex/toolbar-x hides /usr/share/emacs/site-lisp/auctex/toolbar-x
/usr/local/share/emacs/23.2.91/site-lisp/auctex/tex-style hides /usr/share/emacs/site-lisp/auctex/tex-style

Features:
(shadow sort mail-extr message sendmail ecomplete rfc822 mml mml-sec
password-cache mm-decode mm-bodies mm-encode mailcap mail-parse rfc2231
rfc2047 rfc2045 qp ietf-drums mailabbrev nnheader gnus-util netrc
time-date mm-util mail-prsvr gmm-utils mailheader canlock sha1 hex-util
hashcash mail-utils emacsbug make-mode inform-mode tabify man log-edit
pcvs-util add-log grep compile pp diff-git diff-mode vc vc-dispatcher
autoconf autoconf-mode ediff-merg ediff-diff ediff-wind ediff-help
ediff-util ediff-mult ediff-init ediff cus-edit term disp-table ehelp
electric macros info vc-git vc-cvs python-21 python multi-isearch
help-mode view ansi-color shell jka-compr face-remap filladapt flyspell
completing-help recentf tree-widget wid-edit uniquify paren savehist
minibuf-eldef iswitchb icomplete whitespace autorevert time cus-start
cus-load desktop server php-mode etags cc-langs cc-mode cc-fonts
cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs speedbar
sb-image ezimage dframe lua-mode regexp-opt comint ring ropemacs pymacs
etags-update smart-quotes ispell auto-dictionary-autoloads
css-mode-autoloads dictionary-autoloads diff-git-autoloads
dired-isearch-autoloads full-ack-autoloads guess-style-autoloads
http-post-simple-autoloads js2-mode-autoloads magit-autoloads
mv-shell-autoloads ruby-mode-autoloads package reporter advice
advice-preload yasnippet help-fns derived edmacro kmacro easymenu assoc
cl cl-19 muse-autoloads emacs-goodies-el emacs-goodies-custom
emacs-goodies-loaddefs easy-mmode bbdb-autoloads preview-latex tex-site
auto-loads tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win
x-dnd font-setting tool-bar dnd fontset image fringe lisp-mode register
page menu-bar rfn-eshadow timer select scroll-bar mldrag mouse jit-lock
font-lock syntax facemenu font-core frame cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew
greek romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button
minibuffer faces cus-face files text-properties overlay md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process dbusbind system-font-setting
font-render-setting gtk x-toolkit x multi-tty emacs)

-- 
http://rrt.sc3d.org/

bug#7881: 23.2.91; Bold spaces sometimes(?) underlined in man pages

[Andreas Schwab]

Reuben Thomas <rrt@sc3d.org> writes:

> If I view abort(3) in Emacs 23.2.91 on my GNU/Linux system, I get a line
>
>        #include <stdlib.h>
>
> where the space between “include” and “<stdlib.h>” is shown underlined.

That's because it's a button, and the button face is underlined.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#7881: 23.2.91; Bold spaces sometimes(?) underlined in man pages

[Reuben Thomas]

On 21 January 2011 16:12, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Reuben Thomas <rrt@sc3d.org> writes:
>
>> If I view abort(3) in Emacs 23.2.91 on my GNU/Linux system, I get a line
>>
>>        #include <stdlib.h>
>>
>> where the space between “include” and “<stdlib.h>” is shown underlined.
>
> That's because it's a button, and the button face is underlined.

Argh. Is there some way of making it a bit more obvious that it's a
button? It's a nice feature, but it's barely noticeable (I've been
reading plenty of man pages in Emacs recently, and have only just
noticed this), and when I did finally notice it it looked like a bug.

The only obvious signal that it's a button that I can discover is the
highlighting that occurs if I mouse over it. But I don't use the mouse
much in Emacs!

-- 
http://rrt.sc3d.org

bug#7881: 23.2.91; Bold spaces sometimes(?) underlined in man pages

[Glenn Morris]

Andreas Schwab wrote:

>> where the space between “include” and “<stdlib.h>” is shown underlined.
>
> That's because it's a button, and the button face is underlined.

Why isn't the whole button underlined, just the space in the middle?

Why don't the "see also" links at the end of the very same page have
any visible underlining?

Answering myself: because the links are made with `make-text-button',
and it seems since it adds the button face as a text property, it
loses out to any existing text properties (bold in this case).

This seems a bit poor, doesn't it?

`make-button', using overlays, doesn't suffer from this.

bug#7881: 23.2.91; Bold spaces sometimes(?) underlined in man pages

[Chong Yidong]

Glenn Morris <rgm@gnu.org> writes:

> Andreas Schwab wrote:
>
>>> where the space between “include” and “<stdlib.h>” is shown underlined.
>>
>> That's because it's a button, and the button face is underlined.
>
> Why isn't the whole button underlined, just the space in the middle?
>
> Why don't the "see also" links at the end of the very same page have
> any visible underlining?
>
> Answering myself: because the links are made with `make-text-button',
> and it seems since it adds the button face as a text property, it
> loses out to any existing text properties (bold in this case).
>
> This seems a bit poor, doesn't it?
>
> `make-button', using overlays, doesn't suffer from this.

I think `make-button' is indeed the apropriate choice here, since the
button face needs to coexist with the other face text properties applied
by man.el.  Committed to trunk.

bug#7881: 23.2.91; Bold spaces sometimes(?) underlined in man pages

[Glenn Morris]

Chong Yidong wrote:

> I think `make-button' is indeed the apropriate choice here, since the
> button face needs to coexist with the other face text properties applied
> by man.el.

Can make-text-button do better? It's supposedly possible for face text
properties to be a list of faces that get merged into the output. So
ideally it would try to add to the existing face props.

bug#7881: 23.2.91; Bold spaces sometimes(?) underlined in man pages

[Chong Yidong]

Glenn Morris <rgm@gnu.org> writes:

> Chong Yidong wrote:
>
>> I think `make-button' is indeed the apropriate choice here, since the
>> button face needs to coexist with the other face text properties
>> applied by man.el.
>
> Can make-text-button do better? It's supposedly possible for face text
> properties to be a list of faces that get merged into the output. So
> ideally it would try to add to the existing face props.

Currently, text prop buttons use the category property.  The category
specifies a default when a requested property (in this case, the `face'
property) does not exist.  If the property exists, it overrides the
category entirely.

One possibility is to treat `face' properties specially in this regard,
by merging into the category property instead of replacing.  But this
would be a backward incompatible behavior change, and possibly
bug-prone.  And it doesn't seem clean for a `face' category property to
behave so differently from other category properties.

Another possibility is to change the implementation of textprop buttons,
to assign the face directly by merging, instead of using a category
property.  I'll take a look and see if this is feasible.

bug#7881: 23.2.91; Bold spaces sometimes(?) underlined in man pages

[Glenn Morris]

Version: 24.1

Reuben Thomas wrote:

> Argh. Is there some way of making it a bit more obvious that it's a
> button? It's a nice feature, but it's barely noticeable (I've been
> reading plenty of man pages in Emacs recently, and have only just
> noticed this), and when I did finally notice it it looked like a bug.

You can customize the `button' face. The formatting is shared with all
other links, eg those in Help buffers. Hopefully now (as of 24.1) they
use overlays links in M-x man will be more consistently visible.

bug#7881: closed (Re: bug#7881: 23.2.91; Bold spaces sometimes(?) underlined in man pages)

[Reuben Thomas]

> ---------- Forwarded message ----------
> From: Glenn Morris <rgm@gnu.org>
> To: 7881-done@debbugs.gnu.org
> Date: Mon, 24 Jan 2011 21:05:45 -0500
> Subject: Re: bug#7881: 23.2.91; Bold spaces sometimes(?) underlined in man pages
> Version: 24.1
>

Thanks for the future fix. For now, in Emacs 23:

> You can customize the `button' face.

The trouble is that only the one space actually seems to use this face
(with underlining); the rest of the #include is in another face.
Excuse my ignorance and optimism, but is there nothing else to be done
with straightforward configuration?

-- 
http://rrt.sc3d.org

bug#7881: closed (Re: bug#7881: 23.2.91; Bold spaces sometimes(?) underlined in man pages)

[Glenn Morris]

Reuben Thomas wrote:

> The trouble is that only the one space actually seems to use this face
> (with underlining); the rest of the #include is in another face.
> Excuse my ignorance and optimism, but is there nothing else to be done
> with straightforward configuration?

All you can do is redefine Man-highlight-references0 to use
make-button instead of make-text-button.

Since this is a long-standing, minor cosmetic issue, such a change
does not seem appropriate for Emacs 23.3 at this stage.

bug#7881: closed (Re: bug#7881: 23.2.91; Bold spaces sometimes(?) underlined in man pages)

[Reuben Thomas]

On 25 January 2011 18:39, Glenn Morris <rgm@gnu.org> wrote:
>
> All you can do is redefine Man-highlight-references0 to use
> make-button instead of make-text-button.

Thanks, that's great, does exactly what I want.

> Since this is a long-standing, minor cosmetic issue, such a change
> does not seem appropriate for Emacs 23.3 at this stage.

Absolutely.

-- 
http://rrt.sc3d.org