From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Patch to fix the Bar Cursor Too Narrow problem on Mac OS X Date: Wed, 23 Feb 2011 15:45:58 -0500 Message-ID: <871v2yiint.fsf@stupidchicken.com> References: <87d3mnj0o1.fsf@stupidchicken.com> <87wrktxo9t.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1298493980 5785 80.91.229.12 (23 Feb 2011 20:46:20 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 23 Feb 2011 20:46:20 +0000 (UTC) Cc: Emacs-devel@gnu.org To: Ben Key Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 23 21:46:15 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PsLbC-0006EX-0c for ged-emacs-devel@m.gmane.org; Wed, 23 Feb 2011 21:46:14 +0100 Original-Received: from localhost ([127.0.0.1]:49523 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PsLbA-00081x-Ua for ged-emacs-devel@m.gmane.org; Wed, 23 Feb 2011 15:46:13 -0500 Original-Received: from [140.186.70.92] (port=51085 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PsLaz-00080H-Ui for Emacs-devel@gnu.org; Wed, 23 Feb 2011 15:46:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PsLay-0002BF-LN for Emacs-devel@gnu.org; Wed, 23 Feb 2011 15:46:01 -0500 Original-Received: from vm-emlprdomr-04.its.yale.edu ([130.132.50.145]:54221) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PsLay-0002BB-Jc for Emacs-devel@gnu.org; Wed, 23 Feb 2011 15:46:00 -0500 Original-Received: from furball (dhcp128036014213.central.yale.edu [128.36.14.213]) (authenticated bits=0) by vm-emlprdomr-04.its.yale.edu (8.14.4/8.14.4) with ESMTP id p1NKjw10018989 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 23 Feb 2011 15:45:58 -0500 Original-Received: by furball (Postfix, from userid 1000) id 1E584160683; Wed, 23 Feb 2011 15:45:59 -0500 (EST) In-Reply-To: (Ben Key's message of "Mon, 21 Feb 2011 15:15:46 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Scanned-By: MIMEDefang 2.71 on 130.132.50.145 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 130.132.50.145 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:136406 Archived-At: Ben Key writes: >> Does it do the right thing even if you leave out the change to >> xdisp.c? > > In all the cases I have tested, my patch does work correctly without > the change to xdisp.c. Thanks. I've committed that part. I don't agree with the change to get_specified_cursor_type, and have not applied it. If you can find other instances where bogus cursor width values are used, we should fix those instances, because it means the logic in the callers is faulty.