From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Julien Danjou Newsgroups: gmane.emacs.bugs Subject: bug#9581: 24.0.50; dbus-unregister-object fails if service is nil Date: Fri, 23 Sep 2011 18:12:04 +0200 Message-ID: <871uv7i6gb.fsf@keller.adm.naquadah.org> References: <87pqisi3lu.fsf@keller.adm.naquadah.org> <87ehz7e0ck.fsf@gmx.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Trace: dough.gmane.org 1316794376 26247 80.91.229.12 (23 Sep 2011 16:12:56 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 23 Sep 2011 16:12:56 +0000 (UTC) Cc: 9581@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 23 18:12:49 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1R78Mr-0004FY-G2 for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Sep 2011 18:12:49 +0200 Original-Received: from localhost ([::1]:51112 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R78Mq-0006x6-VA for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Sep 2011 12:12:48 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:60984) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R78Me-0006wn-M7 for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2011 12:12:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1R78Md-0004an-EV for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2011 12:12:36 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38528) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1R78Md-0004aA-B7 for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2011 12:12:35 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1R78N4-0000QX-8V for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2011 12:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Julien Danjou Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Sep 2011 16:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9581 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9581-submit@debbugs.gnu.org id=B9581.13167943561609 (code B ref 9581); Fri, 23 Sep 2011 16:13:02 +0000 Original-Received: (at 9581) by debbugs.gnu.org; 23 Sep 2011 16:12:36 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R78Me-0000Pu-80 for submit@debbugs.gnu.org; Fri, 23 Sep 2011 12:12:36 -0400 Original-Received: from prometheus.naquadah.org ([212.85.154.174] helo=mx1.naquadah.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R78Mb-0000Pm-Oe for 9581@debbugs.gnu.org; Fri, 23 Sep 2011 12:12:35 -0400 Original-Received: from keller.adm.naquadah.org (AMontsouris-651-1-106-83.w83-202.abo.wanadoo.fr [83.202.161.83]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mx1.naquadah.org (Postfix) with ESMTPSA id 12E7E5C1AE; Fri, 23 Sep 2011 18:12:05 +0200 (CEST) In-Reply-To: <87ehz7e0ck.fsf@gmx.de> (Michael Albinus's message of "Fri, 23 Sep 2011 17:37:31 +0200") User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 23 Sep 2011 12:13:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:51724 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Fri, Sep 23 2011, Michael Albinus wrote: >> While I agree on point 1., the point 2. is totally irrelevant in such a >> case. There's no need to do such a thing, the name has never been >> requested with RequestName before. > > It's simply an error. We are speaking abut the generalized > `dbus-unregister-object', which is used for both signals and > methods. ReleaseName shall be called only in case a *method* has been > registered; I'll fix this. > >> I think that: >> - step 2 should be removed or another function should be created which >> does not send a ReleaseName > > Nope. See above. Ok, if you do this in one function, I agree with you then. >> - dbus_bus_remove_match() should be used to remove the watch from the >> bus, which would be a lot cleaner. > > Good point. Registering a signal shall also keep the match string in > dbus-registered-objects-table (it doesn't yet). Then we could use this > string to send RemoveMatch. > > I'll prepare a patch for this (hopefully in time before starting the > pretest). It sounds like a solution. What I don't like is that it's not really opaque, so somebody could mess with this, but well=E2=80=A6 I might be para= noid. :) =2D-=20 Julien Danjou --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJOfK/UAAoJEGEbqVCLeKXCltwP/2Ah7UdQdCg/xwxt4aX7Qoo4 qCOu2OLFJ+T446MvUoHCuBbfl4C+lyGwPKbmwBAeBOoPjYJmz/M28LvUfnaJqrDd 5vMrDGw8K+n5xBLjqTTQ1Ol159PcPtTSZSGBi4PE5iDJAr/CQ2g/dWqB5B+T6g0F xN9cUwUuSUdKzZkt26xjQIF4xNeUsjnzZLRBy506oGPCD0Nhyc+4YZLWtCvoBQFS 8Q9Cby/3U2b+ruuZFNSmYWmz4mDIX1vW9zwK1c+lETPZCDN+3Qa4rlSEq2scR4KN cGsc0y8ad3NtMGoC7tdjX6hxHQbuN0/extHfJp+SeM8y3M0nre1jdinJkb72CowH iQ3JAVInuotaIanLQdcd1Vqf7wU8xpmvkU6f5C/hT19phb+nV0DOEd9dkAqF1dyP 29jYwElsA2xGpOPHYoEKFmO7JUZq5M5kvd/oWFM3sF8O5jhGaWI9OzA+6/o8d53T bycAidAWbP3PZao0KzvUCGiG1xdZIy2wBQzFAVDNJw0qTbyjl38Es4MhhUEmYRlt gXKRkLzpbPNeXtmHBZKD6lmKF8rHACQIN9sxfCR0L/dsfKRPNamVPqBGXd8Np2u3 uWoQJGmDJtwN0q9p9z4ULLAjLBo3al8T528/D0/NleNzCxxijW+Y0E42TO7JmAQA LXORSMqDxK1rc0sY1gfw =rfQK -----END PGP SIGNATURE----- --=-=-=--