From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy Date: Mon, 16 Jan 2012 15:13:11 +0100 Message-ID: <871uqzn3bc.fsf@gmx.de> References: <87mx9su32g.fsf@web.de> <87fwfkc4pn.fsf@gmx.de> <87fwfjsw8t.fsf@gmail.com> <87aa5rdazl.fsf@gmx.de> <87d3anogf5.fsf@gmail.com> <011AEED9E81C4DEFA6B1E03B0F57F28F@us.oracle.com> <878vlbljnc.fsf@gmx.de> <8739bj8mu1.fsf@gmail.com> <87fwfjo24c.fsf@gmx.de> <87pqen76p4.fsf@gmail.com> <83fwfik92e.fsf@gnu.org> <87mx9q1sz7.fsf@gmail.com> <87vcodm8ns.fsf@gmx.de> <87pqekopb5.fsf@gmail.com> <87hazwoost.fsf@gmail.com> <87ty3w9639.fsf@gmx.de> <8762gckckt.fsf@gmail.com> <87pqek9269.fsf@gmx.de> <87r4z0yqfx.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1326723266 31197 80.91.229.12 (16 Jan 2012 14:14:26 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 16 Jan 2012 14:14:26 +0000 (UTC) Cc: 10489@debbugs.gnu.org, Thierry Volpiatto To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 16 15:14:21 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RmnKH-0002vH-64 for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Jan 2012 15:14:21 +0100 Original-Received: from localhost ([::1]:33968 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmnKG-0003zL-NZ for geb-bug-gnu-emacs@m.gmane.org; Mon, 16 Jan 2012 09:14:20 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:48523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmnK9-0003yw-CX for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2012 09:14:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RmnK3-0003oQ-NF for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2012 09:14:13 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RmnK3-0003oM-Lh for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2012 09:14:07 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1RmnKv-0007pw-QI for bug-gnu-emacs@gnu.org; Mon, 16 Jan 2012 09:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Jan 2012 14:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10489-submit@debbugs.gnu.org id=B10489.132672325430054 (code B ref 10489); Mon, 16 Jan 2012 14:15:01 +0000 Original-Received: (at 10489) by debbugs.gnu.org; 16 Jan 2012 14:14:14 +0000 Original-Received: from localhost ([127.0.0.1]:59880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1RmnK9-0007og-JV for submit@debbugs.gnu.org; Mon, 16 Jan 2012 09:14:13 -0500 Original-Received: from mailout-de.gmx.net ([213.165.64.23]:35738) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1RmnK7-0007oU-5h for 10489@debbugs.gnu.org; Mon, 16 Jan 2012 09:14:12 -0500 Original-Received: (qmail invoked by alias); 16 Jan 2012 14:13:15 -0000 Original-Received: from p57BB9718.dip0.t-ipconnect.de (EHLO detlef.gmx.de) [87.187.151.24] by mail.gmx.net (mp033) with SMTP; 16 Jan 2012 15:13:15 +0100 X-Authenticated: #3708877 X-Provags-ID: V01U2FsdGVkX1/zjwBI1sLzjwJlDs86czK0/pzf6jYnBy5Ezg1OTZ h5o1jFVmvJl+G1 In-Reply-To: (Stefan Monnier's message of "Mon, 16 Jan 2012 08:56:55 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:55788 Archived-At: Stefan Monnier writes: >>> (string= (directory-file-name (file-truename (expand-file-name file1))) >>> (directory-file-name (file-truename (expand-file-name file2)))))) > >> So, any objections to apply my patch to trunk with these changes? > > Couldn't we use something closer to what we want to ideally use? > E.g. (equal (file-attributes file1) (file-attributes file2))? We need at least the `file-truename' call. (equal (file-attributes (file-truename (expand-file-name file1))) (file-attributes (file-truename (expand-file-name file2)))))) I don't know, whether `file-truename' calls `expand-file-name' internally. `tramp-sh-handle-file-truename' does. Maybe we don't need it. We could also add already the check for the file name handler. When there is no file name handler (Emacs 24.1), it doesn't hurt. Later on, we don't need to touch the fucntion, again. And I'll start to add the file name handler upstream Tramp, once the function is available in Emacs 24.1. > Stefan Best regards, Michael.