From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy Date: Fri, 24 Feb 2012 18:23:00 +0100 Message-ID: <871upkw3gr.fsf@gmail.com> References: <87mx9su32g.fsf@web.de> <871uqz651u.fsf@gmx.de> <87pqd89lh4.fsf@gmail.com> <87mx8b3nvb.fsf@gmail.com> <87pqd6wnvv.fsf@gmail.com> <87d395y1w0.fsf@gmail.com> <87zkc8x04p.fsf@gmail.com> <87vcmwwvk7.fsf@gmail.com> <834nugtwqf.fsf@gnu.org> <87r4xkwhky.fsf@gmail.com> <83vcmws3bs.fsf@gnu.org> <87ehtkwaiz.fsf@gmail.com> <87wr7cgsm3.fsf@gmx.de> <8762eww77b.fsf@gmail.com> <87ty2gdwxe.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1330104224 12619 80.91.229.3 (24 Feb 2012 17:23:44 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 24 Feb 2012 17:23:44 +0000 (UTC) Cc: 10489@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 24 18:23:42 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S0yrt-0000No-1q for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Feb 2012 18:23:41 +0100 Original-Received: from localhost ([::1]:58254 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0yrs-0000s8-J0 for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Feb 2012 12:23:40 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:44033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0yrp-0000r6-1n for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2012 12:23:38 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0yrf-0007Gg-Nw for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2012 12:23:36 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:52507) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0yrf-0007GY-J5 for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2012 12:23:27 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1S0yu9-0004Gf-R4 for bug-gnu-emacs@gnu.org; Fri, 24 Feb 2012 12:26:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Feb 2012 17:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 10489-submit@debbugs.gnu.org id=B10489.133010435016388 (code B ref 10489); Fri, 24 Feb 2012 17:26:01 +0000 Original-Received: (at 10489) by debbugs.gnu.org; 24 Feb 2012 17:25:50 +0000 Original-Received: from localhost ([127.0.0.1]:54404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S0ytx-0004GG-2W for submit@debbugs.gnu.org; Fri, 24 Feb 2012 12:25:49 -0500 Original-Received: from mail-we0-f172.google.com ([74.125.82.172]:56731) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S0ytu-0004G3-2R for 10489@debbugs.gnu.org; Fri, 24 Feb 2012 12:25:47 -0500 Original-Received: by werg1 with SMTP id g1so1643389wer.3 for <10489@debbugs.gnu.org>; Fri, 24 Feb 2012 09:23:05 -0800 (PST) Received-SPF: pass (google.com: domain of thierry.volpiatto@gmail.com designates 10.180.102.132 as permitted sender) client-ip=10.180.102.132; Authentication-Results: mr.google.com; spf=pass (google.com: domain of thierry.volpiatto@gmail.com designates 10.180.102.132 as permitted sender) smtp.mail=thierry.volpiatto@gmail.com; dkim=pass header.i=thierry.volpiatto@gmail.com Original-Received: from mr.google.com ([10.180.102.132]) by 10.180.102.132 with SMTP id fo4mr4420915wib.6.1330104185675 (num_hops = 1); Fri, 24 Feb 2012 09:23:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=BJmpIJBChb/24qBnCIVe50M16JoHeDIQ6q/LfVzjG0E=; b=V0+FtwyC9le2TleQFMZS7/8scXiXQJ1SK5ftSUAeOJ/cB3kafXnwHr7ElBiySJnNG6 2QWT15b2egMp2z2FNA5X5ymni3Lj993ojjnlAVURhuRcLPAo2YCBDz2umuz/4VPbf8X1 1VyQbsWnla/yhmMGWtEzH42xh/sZchgdIk7wE= Original-Received: by 10.180.102.132 with SMTP id fo4mr3532878wib.6.1330104185558; Fri, 24 Feb 2012 09:23:05 -0800 (PST) Original-Received: from thierry-MM061 (lbe83-2-78-243-104-167.fbx.proxad.net. [78.243.104.167]) by mx.google.com with ESMTPS id gf3sm4827773wib.6.2012.02.24.09.23.02 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 24 Feb 2012 09:23:03 -0800 (PST) In-Reply-To: <87ty2gdwxe.fsf@gmx.de> (Michael Albinus's message of "Fri, 24 Feb 2012 17:21:33 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:57184 Archived-At: Michael Albinus writes: > Thierry Volpiatto writes: > >> (defun files-equal-p (file1 file2) >> "Return non-nil if FILE1 and FILE2 name the same file." >> (let ((handler (or (find-file-name-handler file1 'files-equal-p) >> (find-file-name-handler file2 'files-equal-p)))) >> (if handler >> (funcall handler 'files-equal-p file1 file2) >> (and (equal (file-remote-p file1) (file-remote-p file2)) > > Not needed anymore, you have called the handler already. You mean this is not needed: (and (equal (file-remote-p file1) (file-remote-p file2)) right? >> (equal (file-attributes (file-truename file1)) >> (file-attributes (file-truename file2))))))) > > Here we have the discussion about the inode numbers. But this is an edge > case; let's go this way. Eli will fix it for Windows :-) Yes I leave it as it is because it still not clear what to do here. Think it is safe enough anyway. -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997