From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jambunathan K Newsgroups: gmane.emacs.bugs Subject: bug#13892: 24.3.50; Provide for customizing default regexp in hi-lock commands Date: Fri, 08 Mar 2013 09:59:42 +0530 Message-ID: <871ubqecp5.fsf@gmail.com> References: <87fw08za2u.fsf@gmail.com> <87ehfrmv92.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1362717032 6621 80.91.229.3 (8 Mar 2013 04:30:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 8 Mar 2013 04:30:32 +0000 (UTC) Cc: 13892-done@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 08 05:30:56 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UDoxJ-00014p-KL for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Mar 2013 05:30:53 +0100 Original-Received: from localhost ([::1]:40679 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDowx-0004fj-QN for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Mar 2013 23:30:31 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:49287) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDowv-0004fc-7u for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2013 23:30:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UDowt-0008Bj-VO for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2013 23:30:29 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:33694) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UDowt-0008Ba-Qt for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2013 23:30:27 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UDoxS-0000Ye-Mq for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2013 23:31:02 -0500 Resent-From: Jambunathan K Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Mar 2013 04:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 13892 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 13892@debbugs.gnu.org, kjambunathan@gmail.com, kjambunathan@gmail.com Original-Received: via spool by 13892-done@debbugs.gnu.org id=D13892.13627170282103 (code D ref 13892); Fri, 08 Mar 2013 04:31:02 +0000 Original-Received: (at 13892-done) by debbugs.gnu.org; 8 Mar 2013 04:30:28 +0000 Original-Received: from localhost ([127.0.0.1]:37803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UDowt-0000Xr-8V for submit@debbugs.gnu.org; Thu, 07 Mar 2013 23:30:27 -0500 Original-Received: from mail-pa0-f41.google.com ([209.85.220.41]:45830) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UDowr-0000Xe-MK for 13892-done@debbugs.gnu.org; Thu, 07 Mar 2013 23:30:26 -0500 Original-Received: by mail-pa0-f41.google.com with SMTP id fb11so1011140pad.14 for <13892-done@debbugs.gnu.org>; Thu, 07 Mar 2013 20:29:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=5E3kQr9fmmvVDaS8YBVp+ghPXOQK//wtm1DMNcWoWps=; b=j+DnydV8clKmzwKgQvlYuEpeUB2MpjLwHmfcaFV6T+UCCEcJc0nEUwfgcEPZzP0jci 3GtVfSrkdTC3YAV07RqdT+V4c9qAZcbBZf0HrP+Cwg5W3/HQBUGbjP6bz8E4sEJHAI7Y nkQl8y2ik6QOwKgFkEbGkYPHrrrpg236DVyNnqQyO02EwOIu2gaf8BJxXKA/3tHy5Na5 6kbLBnqPl5k+1XtP4mbD9F+1Jnlo1gdGu6hGjHGHTMn/x91xMCZX6R/MRpOmrfbaiQbD 28rEeH+uWfb6d3wdMIOIEftX5cAM5dCVCvzEcMHJvWKi24bU1/cPfaL/YNVyq+ODt/V7 hvyg== X-Received: by 10.66.233.102 with SMTP id tv6mr2029676pac.99.1362716984801; Thu, 07 Mar 2013 20:29:44 -0800 (PST) Original-Received: from debian-6.05 ([115.241.126.42]) by mx.google.com with ESMTPS id xr3sm4044919pbc.46.2013.03.07.20.29.41 (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Thu, 07 Mar 2013 20:29:43 -0800 (PST) In-Reply-To: <87ehfrmv92.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 07 Mar 2013 11:09:29 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:72220 Archived-At: Juri Linkov writes: >> +(defvar hi-lock-read-regexp-defaults-function >> + 'hi-lock-read-regexp-defaults >> + "Function that provides default regexp(s) for highlighting commands. >> +This function should take one argument OP and return one of nil, >> +a regexp or a list of regexps for use with highlighting command >> +OP. OP, a symbol, can be one of `phrase', `line' or `nil' >> +signifying commands `hi-lock-face-phrase-buffer', >> +`hi-lock-line-face-buffer' and `hi-lock-face-buffer' >> +respectively. > > Requiring an additional argument `op' means that we wouldn't > be able to customize `hi-lock-read-regexp-defaults-function' > to just `find-tag-default' or `find-tag-default-as-regexp'. > I think there is no need to distinguish between different > hi-lock commands since one user would very likely prefer > the one way to get the default for all hi-lock commands, > so you could call `hi-lock-read-regexp-defaults-function' > without arguments. Committed as bzr revision 111971. I have removed OP, updated the docstring. I have also introduced `find-tag-default-as-regexp' in subr.el.