From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: trunk r115265: * lisp/vc/vc-dispatcher.el (vc-log-edit): Setup the Summary&Author headers. Date: Fri, 29 Nov 2013 06:39:50 +0200 Message-ID: <871u1zes89.fsf@yandex.ru> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1385700009 16818 80.91.229.3 (29 Nov 2013 04:40:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Nov 2013 04:40:09 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 29 05:40:14 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VmFsC-0007p8-1j for ged-emacs-devel@m.gmane.org; Fri, 29 Nov 2013 05:40:12 +0100 Original-Received: from localhost ([::1]:45416 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmFsB-0007An-LU for ged-emacs-devel@m.gmane.org; Thu, 28 Nov 2013 23:40:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55639) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmFs4-00077L-I2 for emacs-devel@gnu.org; Thu, 28 Nov 2013 23:40:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VmFrz-0006zD-2n for emacs-devel@gnu.org; Thu, 28 Nov 2013 23:40:04 -0500 Original-Received: from mail-we0-x22f.google.com ([2a00:1450:400c:c03::22f]:49155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VmFry-0006z8-RC for emacs-devel@gnu.org; Thu, 28 Nov 2013 23:39:58 -0500 Original-Received: by mail-we0-f175.google.com with SMTP id p61so8717398wes.6 for ; Thu, 28 Nov 2013 20:39:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=H9uIeQHwES//fqMpV2jQ/4zalHlHKTZlQ/lj3HSRftQ=; b=o4s8x1q+wQYebihoxrlq7C9vPDRSr8+5R60VAJsugdW7tOzScUN1geMMmJHsHOa1se wEgJ9h7jR2wukNApaAQYHSFnOajdfUciLr//tEWMUuxACwrcJ5aqYdq+AaGu3uLNAX3M OMfhWkNXFzq9odECI2/kHTSETyizdaR2IlBPeq3mBTWk+w9ZWVaMqkeBYJi/3n0/VRIW 03zbAaZbvDyb5lcveMtf49BzpDYp1H9kPtFELabg+3ooF3BfEbtaSNYlPWibYuMzS6ve uguKwVKYH8f5ag5HI9TruiYSr532rzHFa1LmL1yfDfdo0spZBd9ldBEYlvA61YJCdqnp x+5Q== X-Received: by 10.180.7.136 with SMTP id j8mr5051036wia.17.1385699997662; Thu, 28 Nov 2013 20:39:57 -0800 (PST) Original-Received: from axl (83-43-131.netrun.cytanet.com.cy. [83.168.43.131]) by mx.google.com with ESMTPSA id a19sm88060136wib.1.2013.11.28.20.39.55 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 28 Nov 2013 20:39:56 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Thu, 28 Nov 2013 01:49:30 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c03::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165850 Archived-At: Stefan Monnier writes: > revno: 115265 > * lisp/vc/vc-dispatcher.el (vc-log-edit): Setup the Summary&Author > headers. This looks like a fix of previously-implemented functionality, but I'm not sure I like the result. Pros: `log-edit-insert-changelog' and `log-edit-show-files' are nifty. Cons: 1. The "Author" header will be almost always unused in other projects, aside from Emacs, I'm contributing to. So it'll stick out like a sore thumb. And even with Emacs, when the ChangeLog entry has the proper author mentioned, it's auto-filled anyway. 2. The "Summary" doesn't add anything in the way of features, I can just as well write it in the first line of the message. When the buffer is displayed initially, the point is before "Summary:", so now I have to move it first before I can write the commit message. `vc-git-log-edit-toggle-amend' is not aware of this header and inserts the whole message, summary and the rest, below the headers, leaving "Summary" empty. Although this should be fixable. 3. If I decide I don't want to commit now, and I kill the log-edit buffer (is there any other way to dismiss it?), the window and buffer created by `log-edit-show-files', doesn't go anywhere, and I have to take care of it separately. Also fixable.