From: Dmitry Gutov <dgutov@yandex.ru>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: trunk r115265: * lisp/vc/vc-dispatcher.el (vc-log-edit): Setup the Summary&Author headers.
Date: Fri, 29 Nov 2013 06:39:50 +0200 [thread overview]
Message-ID: <871u1zes89.fsf@yandex.ru> (raw)
In-Reply-To: <E1VlqjS-0006O3-Fn@vcs.savannah.gnu.org> (Stefan Monnier's message of "Thu, 28 Nov 2013 01:49:30 +0000")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> revno: 115265
> * lisp/vc/vc-dispatcher.el (vc-log-edit): Setup the Summary&Author
> headers.
This looks like a fix of previously-implemented functionality, but I'm
not sure I like the result.
Pros: `log-edit-insert-changelog' and `log-edit-show-files' are nifty.
Cons:
1. The "Author" header will be almost always unused in other projects,
aside from Emacs, I'm contributing to. So it'll stick out like a sore
thumb. And even with Emacs, when the ChangeLog entry has the proper
author mentioned, it's auto-filled anyway.
2. The "Summary" doesn't add anything in the way of features, I can just
as well write it in the first line of the message.
When the buffer is displayed initially, the point is before "Summary:",
so now I have to move it first before I can write the commit message.
`vc-git-log-edit-toggle-amend' is not aware of this header and inserts
the whole message, summary and the rest, below the headers, leaving
"Summary" empty. Although this should be fixable.
3. If I decide I don't want to commit now, and I kill the log-edit
buffer (is there any other way to dismiss it?), the window and buffer
created by `log-edit-show-files', doesn't go anywhere, and I have to
take care of it separately. Also fixable.
next parent reply other threads:[~2013-11-29 4:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1VlqjS-0006O3-Fn@vcs.savannah.gnu.org>
2013-11-29 4:39 ` Dmitry Gutov [this message]
2013-11-29 13:33 ` trunk r115265: * lisp/vc/vc-dispatcher.el (vc-log-edit): Setup the Summary&Author headers Stefan Monnier
2013-11-29 14:53 ` Dmitry Gutov
2013-11-29 17:04 ` Stefan Monnier
2013-11-29 22:37 ` Dmitry Gutov
2013-11-30 2:29 ` Stefan Monnier
2013-11-30 16:02 ` Dmitry Gutov
2013-12-01 21:10 ` Stefan Monnier
2013-12-02 2:40 ` Dmitry Gutov
2013-12-02 13:53 ` Stefan Monnier
2013-12-02 23:02 ` Dmitry Gutov
2013-12-03 0:56 ` Leo Liu
2013-12-03 3:06 ` Stefan Monnier
2013-12-04 0:38 ` Dmitry Gutov
2013-12-03 2:17 ` Dmitry Gutov
2013-12-03 3:09 ` Stefan Monnier
2013-12-04 0:43 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871u1zes89.fsf@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.