From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#11571: 24.0.97; doc string of `dired-get-subdir-min' Date: Sat, 08 Feb 2014 19:59:19 -0800 Message-ID: <871tzdgcmg.fsf@building.gnus.org> References: <144EDF3C01664A2180447B02D1A6EB09@us.oracle.com> <484EACDE2A4A4185B158B84473AB1710@us.oracle.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1391918460 14178 80.91.229.3 (9 Feb 2014 04:01:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 9 Feb 2014 04:01:00 +0000 (UTC) Cc: 11571@debbugs.gnu.org To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 09 05:01:07 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WCLZr-0000LD-9Y for geb-bug-gnu-emacs@m.gmane.org; Sun, 09 Feb 2014 05:01:07 +0100 Original-Received: from localhost ([::1]:49077 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCLZr-0006Qt-0Q for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Feb 2014 23:01:07 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCLZn-0006Qo-Pi for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2014 23:01:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WCLZm-00082I-Oo for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2014 23:01:03 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44723) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCLZm-00082E-Lz for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2014 23:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WCLZm-0007ql-AM for bug-gnu-emacs@gnu.org; Sat, 08 Feb 2014 23:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Feb 2014 04:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11571 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11571-submit@debbugs.gnu.org id=B11571.139191845029333 (code B ref 11571); Sun, 09 Feb 2014 04:01:02 +0000 Original-Received: (at 11571) by debbugs.gnu.org; 9 Feb 2014 04:00:50 +0000 Original-Received: from localhost ([127.0.0.1]:58742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCLZZ-0007cO-LX for submit@debbugs.gnu.org; Sat, 08 Feb 2014 23:00:50 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:32996) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCLZW-0007YS-0L for 11571@debbugs.gnu.org; Sat, 08 Feb 2014 23:00:46 -0500 Original-Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WCLZH-0004xu-Bh; Sun, 09 Feb 2014 05:00:31 +0100 In-Reply-To: <484EACDE2A4A4185B158B84473AB1710@us.oracle.com> (Drew Adams's message of "Sun, 27 May 2012 14:41:52 -0700") User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.3.50 (gnu/linux) X-MailScanner-ID: 1WCLZH-0004xu-Bh MailScanner-NULL-Check: 1392523232.00777@4/f6eGKnCURwLCzGKi9mzA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:85034 Archived-At: "Drew Adams" writes: > Actually, the real bug is that `dired-get-subdir-min' has no doc string, so the > doc string of `cdr' is used in its stead. The whole point of defining and using > a separate function for this, instead of just coding with `cdr', is to enable > readers of the code - and a fortiori the doc - to think in terms of the data > structure of directories and not just abstract cons cells. There should be doc > at the proper level of abstraction here. Help says: --- dired-get-subdir-min is an alias for `cdr' in `dired.el'. (dired-get-subdir-min LIST) Return the cdr of LIST. If arg is nil, return nil. Error if arg is not nil and not a cons cell. See also `cdr-safe'. --- I think that's fine. However: ;; can't use macro, must be redefinable for other alist format in dired-nstd. (defalias 'dired-get-subdir-min 'cdr) Which is kinda er. I don't know what nstd is, and the function doesn't seem to be redefined anywhere, so is this just legacy gunk? Should `dired-get-subdir-min' just be replaced by `cdr' in all the calling sites? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/