From: Bastien <bzg@gnu.org>
To: Marcin Antczak <marcin.antczak@neutrico-themes.pl>
Cc: Rick Frankel <rick@rickster.com>, emacs-orgmode@gnu.org
Subject: Re: [Patch] Few small fixes to html header
Date: Wed, 16 Apr 2014 16:50:13 +0200 [thread overview]
Message-ID: <871twxz0bq.fsf@bzg.ath.cx> (raw)
In-Reply-To: <87siq2jj6l.fsf@neutrico-themes.pl> (Marcin Antczak's message of "Fri, 28 Mar 2014 19:02:10 +0100")
Hi Marcin and Rick,
Marcin Antczak <marcin.antczak@neutrico-themes.pl> writes:
>> Another good question. Bastien- Do you think it makes sense to do a
>> whitespace cleanup only commit of ox-html to master?
>
> +1 from me.
The practice I've seen on Emacs is to not do whitespace commits,
but the cleanup whitespace when there is another real change.
Let's do it that way.
>> While source whitespace and output formatting are annoying, our
>> approach to modifications of this (quite old) file has been to not
>> make changes which don't materially affect functionality or fix bugs
>> (the rule of least damage :).
>
> I agree. But code really should be valid and IMHO little improvements
> and code cleanups are ok.
Agreed. Can you submit a patch for the small enhancement you are
suggesting? Then you can also do the whitespace cleanup.
Thanks!
--
Bastien
prev parent reply other threads:[~2014-04-16 16:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 19:57 [Patch] Few small fixes to html header Marcin Antczak
2014-03-28 7:59 ` Rainer M Krug
2014-03-28 10:40 ` Marcin Antczak
2014-03-28 14:43 ` Rick Frankel
2014-03-28 15:16 ` Marcin Antczak
2014-03-28 16:00 ` Rick Frankel
2014-03-28 18:02 ` Marcin Antczak
2014-04-16 14:50 ` Bastien [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871twxz0bq.fsf@bzg.ath.cx \
--to=bzg@gnu.org \
--cc=emacs-orgmode@gnu.org \
--cc=marcin.antczak@neutrico-themes.pl \
--cc=rick@rickster.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.