From: Stephen Berman <stephen.berman@gmx.net>
To: martin rudalics <rudalics@gmx.at>
Cc: 18357@debbugs.gnu.org
Subject: bug#18357: 24.3.93; Calendar not fully displayed
Date: Sat, 30 Aug 2014 21:35:19 +0200 [thread overview]
Message-ID: <871trxrcso.fsf@rosalinde.fritz.box> (raw)
In-Reply-To: <54021337.9020800@gmx.at> (martin rudalics's message of "Sat, 30 Aug 2014 20:08:55 +0200")
On Sat, 30 Aug 2014 20:08:55 +0200 martin rudalics <rudalics@gmx.at> wrote:
>> Are you sure fit-window-to-buffer was called? My reading of
>> calendar.el is that it isn't in this scenario.
>
> It is.
Martin is correct: when calendar-generate-window is called from
calendar-basic-setup, the selected window is the one containing the
*Calendar* buffer (this is because calendar-basic-setup previously
called `(pop-to-buffer calendar-buffer)').
>>> For Stephen's the estimate is for a non-selected window and `calendar'
>>> selects the window _after_ `fit-window-to-buffer' was executed.
>>
>> See above: are you sure?
>
> Yes. Stephen please verify.
If I follow you (but I'm not sure I do), I think you are mistaken here:
when I step through the code, fit-window-to-buffer is called (in
calendar-generate-window, as noted above) with *Calendar* buffer window
already being the selected window. In any case, the estimate for the
mode line height should be the same in my case as in yours, see below.
>>> If you have a better explanation, I'll be all ears.
>>
>> I don't see what I need to explain. From my POV, what we see here is
>> all normal, as I already explained in my original response to Stephen.
>
> The problem is that `fit-window-to-buffer' shouldn't leave a line
> partially visible. At least not in the case at hand where there's
> plenty of space.
>
>> Then you agree with me: there's no problem here, just normal reaction
>> to the fact that point entered a partially visible line.
>
> See above. Stephen, does it fit if you make the font of a non-active
> mode line just as high as that of an active one?
In my recipe, both active and inactive mode lines have the same height:
face mode-line-inactive inherits the overline attribute from face
mode-line.
One interesting observation (which I do not understand), is that when I
execute the recipe and step through calendar-generate-window with
Edebug, after the call to fit-window-to-buffer, the height of the
Calendar window is 9, and the Calendar is fully displayed. But when I
execute the recipe alone, the height is 8 and the display is partial.
Steve Berman
next prev parent reply other threads:[~2014-08-30 19:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-29 18:24 bug#18357: 24.3.93; Calendar not fully displayed Stephen Berman
2014-08-29 19:07 ` Stephen Berman
2014-08-30 9:58 ` Eli Zaretskii
2014-08-30 11:32 ` Stephen Berman
2014-08-30 12:34 ` Eli Zaretskii
2014-08-30 14:07 ` Stephen Berman
2014-08-30 16:40 ` martin rudalics
2014-08-30 12:43 ` martin rudalics
2014-08-30 12:48 ` martin rudalics
2014-08-30 13:27 ` Eli Zaretskii
2014-08-30 13:51 ` martin rudalics
2014-08-30 14:09 ` Eli Zaretskii
2014-08-30 16:40 ` martin rudalics
2014-08-30 16:46 ` Eli Zaretskii
2014-08-30 17:15 ` martin rudalics
2014-08-30 17:54 ` Eli Zaretskii
2014-08-30 18:08 ` martin rudalics
2014-08-30 19:35 ` Stephen Berman [this message]
2014-08-31 11:28 ` martin rudalics
2014-09-01 9:18 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871trxrcso.fsf@rosalinde.fritz.box \
--to=stephen.berman@gmx.net \
--cc=18357@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.