From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: emacs-devel@gnu.org
Subject: Re: eieio, pretty printing, and edebug
Date: Wed, 29 Oct 2014 19:50:54 -0700 [thread overview]
Message-ID: <871tpqfey9.fsf@ericabrahamsen.net> (raw)
In-Reply-To: jwvd29a47lr.fsf-monnier+emacs@gnu.org
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> objects to be a part of the "safety" routine -- would it be unreasonable
>> to make edebug aware of eieio, and move most of the logic of
>> `eieio-edebug-prin1-to-string' into `edebug-safe-prin1-to-string',
>> guarded by a `featurep'?
>
> I don't think it'd be better than using advice-add, actually.
>
> If you want it to be cleaner, the first step is to replace
> the edebug-prin1-to-string function with a variable
> edebug-prin1-to-string-function (so it's clear that it's meant to be
> changed), and hence to modify it with add-function rather than
> advice-add.
>
> The even better way, as mentioned earlier, is to change prin1's
> underlying infrastructure so eieio can hook into it.
I just put up a patch that does considerably less than all that. I can
probably manage solution number one above, but if you'd like to hold out
for solution number two, I'll bow out and leave the bug report for
others.
prev parent reply other threads:[~2014-10-30 2:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 18:22 eieio, pretty printing, and edebug Eric Abrahamsen
2014-10-28 16:44 ` Stefan Monnier
2014-10-29 2:38 ` Eric Ludlam
2014-10-29 23:40 ` Eric Abrahamsen
2014-10-30 1:57 ` Stefan Monnier
2014-10-30 2:36 ` Eric Abrahamsen
2014-10-30 2:34 ` Stefan Monnier
2014-10-30 2:50 ` Eric Abrahamsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tpqfey9.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.