From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: Network Security Manager merge time? Date: Tue, 25 Nov 2014 09:20:39 -0500 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <871torfjk8.fsf@lifelogs.com> References: <87lhn7cfe0.fsf@lifelogs.com> <87egszcd3i.fsf@lifelogs.com> <87h9xvavjm.fsf@lifelogs.com> <874mtuc1hq.fsf@lifelogs.com> Reply-To: emacs-devel@gnu.org NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1416925347 4489 80.91.229.3 (25 Nov 2014 14:22:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 25 Nov 2014 14:22:27 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 25 15:22:20 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XtH0V-0007wW-RZ for ged-emacs-devel@m.gmane.org; Tue, 25 Nov 2014 15:22:19 +0100 Original-Received: from localhost ([::1]:57629 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtH0U-0002zn-66 for ged-emacs-devel@m.gmane.org; Tue, 25 Nov 2014 09:22:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53581) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtGya-0001P6-46 for emacs-devel@gnu.org; Tue, 25 Nov 2014 09:20:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XtGyT-00038U-Me for emacs-devel@gnu.org; Tue, 25 Nov 2014 09:20:20 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:35809) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XtGyT-00038E-Fc for emacs-devel@gnu.org; Tue, 25 Nov 2014 09:20:13 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XtGyS-0006Eu-Up for emacs-devel@gnu.org; Tue, 25 Nov 2014 15:20:12 +0100 Original-Received: from c-98-229-61-72.hsd1.ma.comcast.net ([98.229.61.72]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 25 Nov 2014 15:20:12 +0100 Original-Received: from tzz by c-98-229-61-72.hsd1.ma.comcast.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 25 Nov 2014 15:20:12 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 42 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: c-98-229-61-72.hsd1.ma.comcast.net X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) Cancel-Lock: sha1:5sweA7LqTGhm46NsrTMxkksJ698= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:178238 Archived-At: On Fri, 21 Nov 2014 12:29:45 +0100 Lars Magne Ingebrigtsen wrote: LMI> Ted Zlatanov writes: >> Looking at the code, there's a lot of copy+pasta there between the >> GnuTLS verification in `gnutls-boot' and the message collection in >> `gnutls-peer-status'. Could you factor that out so there's only one >> sequence of checks to maintain, especially since I'd like to deprecate >> the GnuTLS verification in favor of NSM? Basically call >> `gnutls-peer-status' in `gnutls-boot' and then iterate through the >> messages (which can be the simpler version you use instead of the one >> with the hostname attached I have in `gnutls-boot'). I can do it if you >> prefer. LMI> Sure; go ahead. The verification checks should probably be factored out LMI> from `gnutls-peer-status', though, since `gnutls-boot' doesn't need the LMI> other things it calculates (like the fingerprints etc). OK, done as follows: * `gnutls-peer-status' returns a simple list of symbols, which can then be passed to `gnutls-peer-status-warning-describe' for the full string. That could turn into a more complex struct or symbol properties, but for now it's just a string message. I adapted `gnutls-boot' accordingly. The certificate info is not generated when it's called through `gnutls-boot' because that struct is not populated yet, so there's no wasted cycles. * nsm.el was also adapted accordingly. I think we should now do the following: * deprecate `gnutls-verify-error' in favor of `network-security-level' * to help the migration, map :trustfiles and :hostname to 'medium (IIUC) * add the ability to set the `network-security-level' per hostname regex * put the 'gnutls customization group next to 'nsm under 'comm WDYT? Ted