From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] files.el: avoid asking whether to kill Emacs multiple times Date: Thu, 29 Jan 2015 17:01:38 +0100 Message-ID: <871tmdtw2l.fsf@fencepost.gnu.org> References: <1422540409-4134-1-git-send-email-mpn@google.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1422547334 3975 80.91.229.3 (29 Jan 2015 16:02:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 29 Jan 2015 16:02:14 +0000 (UTC) Cc: Michal Nazarewicz , Drew Adams , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 29 17:02:13 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YGrXl-0003c4-Np for ged-emacs-devel@m.gmane.org; Thu, 29 Jan 2015 17:02:09 +0100 Original-Received: from localhost ([::1]:60514 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGrXl-0005xm-4V for ged-emacs-devel@m.gmane.org; Thu, 29 Jan 2015 11:02:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGrXO-0005v3-RI for emacs-devel@gnu.org; Thu, 29 Jan 2015 11:01:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YGrXI-0003E0-O5 for emacs-devel@gnu.org; Thu, 29 Jan 2015 11:01:46 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59553) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGrXI-0003Dw-IM for emacs-devel@gnu.org; Thu, 29 Jan 2015 11:01:40 -0500 Original-Received: from localhost ([127.0.0.1]:38495 helo=lola) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YGrXH-0008Su-EM; Thu, 29 Jan 2015 11:01:40 -0500 Original-Received: by lola (Postfix, from userid 1000) id E25F5DF2EF; Thu, 29 Jan 2015 17:01:38 +0100 (CET) In-Reply-To: (Stefan Monnier's message of "Thu, 29 Jan 2015 10:54:42 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:181987 Archived-At: Stefan Monnier writes: >>> If `confirm-kill-emacs' is set, but user has just been asked whether >>> they really want to kill Emacs (for example with a =E2=80=98Modified bu= ffers >>> exist; exit anyway?=E2=80=99 prompt), do not ask them for another confi= rmation. > > I agree that skipping the second confirmation would be desirable. > >>> However, apply this exception only if `confirm-kill-emacs' is >>> 'yes-or-no-p or 'y-or-n-p, otherwise this change might errenously >>> prevent some user defined function from being run. > > Is it really worth the trouble? Comparing functions is just a bad idea > in general, so if we can avoid it, it's preferable. > >> Related? >> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D9577 > > Another painful one is when a file is modified outside of Emacs but you > still want to edit the current buffer and then save it (hence > overwriting the changes made outside of Emacs). I think in total this > gets you 3 confirmation prompts and at least one of them should go. I think in connection with something like C-x v u some of the later questions are rather hard to answer. You just don't have a clue what will be retained and what will be overwritten. I have, on occasion, reverted to just doing a manual copy of the file from the shell before daring to answer Emacs. --=20 David Kastrup