all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Stephen J. Turnbull" <stephen@xemacs.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets
Date: Mon, 02 Feb 2015 12:45:34 +0900	[thread overview]
Message-ID: <871tm9q8m9.fsf@uwakimon.sk.tsukuba.ac.jp> (raw)
In-Reply-To: <54CEDF1C.2010504@yandex.ru>

Dmitry Gutov writes:
 > On 02/02/2015 04:12 AM, Stephen J. Turnbull wrote:

 > >   > Why do we need to fetch first? Just check against
 > >   > origin/master. If it's outdated, the push will most likely
 > >   > fail anyway.
 > >
 > > It didn't this time.
 > 
 > That means origin/master on Joakim's machine wasn't outdated. Which, 
 > without someone implementing the actual check, doesn't give us anything.

The check isn't hard, it's just

    current=$(git rev-parse origin/master)
    base=$(git rev-list --first-parent origin/master^..HEAD | tail -1)
    test "$current" = "$base"

(untested).  Probably we should be a little more careful about
specifying what is proposed for push on the user side than just
"HEAD", but that gives the basic computation.

Turning that into a hook for receive-pack is something that may be
equally trivial, but I don't have the time (or the interest) to
investigate hook-writing.

In any case, the point of doing the check locally is to avoid a failed
push which is annoying and upsetting, especially to users who are used
to a different workflow or VCS.  If you're doing the check offline or
otherwise the fetch of the branch you want to push to fails, sure,
fall back to the current state.



      reply	other threads:[~2015-02-02  3:45 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20150201003025.18138.95966@vcs.savannah.gnu.org>
     [not found] ` <E1YHiQk-0004jf-UH@vcs.savannah.gnu.org>
2015-02-01  6:11   ` [Emacs-diffs] xwidget 9fe732a 2/2: Better changelog for xwidgets Dmitry Gutov
2015-02-01  8:50     ` joakim
2015-02-01 10:53       ` Paul Eggert
2015-02-01 15:46         ` joakim
2015-02-01 16:09           ` Dmitry Gutov
2015-02-01 16:17             ` joakim
2015-02-01 16:30               ` Dmitry Gutov
2015-02-01 19:48                 ` joakim
2015-02-01 19:53                 ` Paul Eggert
2015-02-01 19:59                   ` joakim
2015-02-01 20:05                   ` Dmitry Gutov
2015-02-01 20:08             ` David Engster
2015-02-01 20:18               ` Dmitry Gutov
2015-02-01 20:21                 ` David Engster
2015-02-03 22:38         ` joakim
2015-02-03 23:42           ` Paul Eggert
2015-02-04 15:59             ` joakim
2015-02-04 18:57               ` joakim
2015-02-05  0:38                 ` Paul Eggert
2015-02-05 15:54                   ` joakim
2015-02-05 16:17                     ` Paul Eggert
2015-02-09 11:50                       ` joakim
2015-02-09 11:56                   ` joakim
2015-02-09 19:47                     ` Paul Eggert
2015-02-09 20:24                       ` joakim
2015-02-09 22:20                         ` Paul Eggert
2015-02-10 18:27                           ` joakim
2015-02-01 15:36     ` Eli Zaretskii
2015-02-01 15:51       ` David Engster
2015-02-01 15:52       ` joakim
2015-02-01 16:04         ` David Engster
2015-02-01 16:04         ` Eli Zaretskii
2015-02-01 16:05         ` Andreas Schwab
2015-02-01 16:11           ` David Engster
2015-02-01 16:15             ` Andreas Schwab
2015-02-01 16:18               ` joakim
2015-02-01 19:29               ` David Engster
2015-02-01 19:39                 ` Dmitry Gutov
2015-02-01 19:56                   ` Eli Zaretskii
2015-02-01 20:41                     ` Dmitry Gutov
2015-02-02  3:30                       ` Eli Zaretskii
2015-02-02  8:03                         ` David Engster
2015-02-02 10:53                           ` Ulrich Mueller
2015-02-02 16:30                           ` Eli Zaretskii
2015-02-02 23:19                             ` Stefan Monnier
2015-02-02  1:35                 ` Stephen J. Turnbull
2015-02-02  1:57                   ` Dmitry Gutov
2015-02-02  2:12                     ` Stephen J. Turnbull
2015-02-02  2:21                       ` Dmitry Gutov
2015-02-02  3:45                         ` Stephen J. Turnbull [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871tm9q8m9.fsf@uwakimon.sk.tsukuba.ac.jp \
    --to=stephen@xemacs.org \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.