all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Dima Kogan <dima@secretsauce.net>
Cc: 18958@debbugs.gnu.org
Subject: bug#18958: 25.0.50; auto-revert-mode reacts slowly even if using an event-driven backend
Date: Thu, 19 Feb 2015 21:41:17 +0100	[thread overview]
Message-ID: <871tll63de.fsf@gmx.de> (raw)
In-Reply-To: <878ujpcw07.fsf@secretsauce.net>

Dima Kogan <dima@secretsauce.net> writes:

Hi Dima,

I'm sorry that I could not interact earlier. Meanwhile I have read all
the threads about, and I believe your proposed patch is worth to be
applied.

> The issue is that auto-revert-mode reacts to modifications on a timer,
> even if its backend is event-driven. There is a prototype patch in that
> thread, attached here also.
>
> On Linux, the two available backends have issues, so this patch wouldn't
> be completely effective until those are resolved.
>
> The gfile backend has a problem where emacs isn't using glib correctly,
> and the gfile backend itself, in turn, adds artificial delays in how it
> deals with inotify. Those are discussed (and partly patched) here:
>
>  http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18861
>
> The inotify backend has an issue where it doesn't deal with more than
> one monitored file in a directory correctly:
>
>  http://debbugs.gnu.org/cgi/bugreport.cgi?bug=18880

Both bugs are fixed meanwhile.

> From 567d8469dfb143786890c65de58bf2ce887e9ebd Mon Sep 17 00:00:00 2001
> From: Dima Kogan <dima@secretsauce.net>
> Date: Fri, 24 Oct 2014 19:44:43 -0700
> Subject: [PATCH] auto-revert-mode can now revert immediately in response to a
>  change event

I've applied your patch to the master branch (including Stefan's
recommendation to use defvar-local). Could you, please, recheck that
everything works as expected, also wrt the other two bugs you've mentioned?

Best regards, Michael.





  parent reply	other threads:[~2015-02-19 20:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-05 19:01 bug#18958: 25.0.50; auto-revert-mode reacts slowly even if using an event-driven backend Dima Kogan
2014-11-07 20:01 ` Stefan Monnier
2015-02-19 20:41 ` Michael Albinus [this message]
2015-02-20  9:59   ` Dima Kogan
2015-02-20 10:25     ` Michael Albinus
2015-02-21  3:38     ` Dima Kogan
2015-02-21  9:57       ` Michael Albinus
2015-02-21 11:39         ` Eli Zaretskii
2015-02-21 12:43           ` Michael Albinus
2015-02-28 15:31             ` Eli Zaretskii
2015-02-21 22:38         ` Dima Kogan
2015-02-22  9:53           ` Michael Albinus
2015-02-22 15:57             ` Eli Zaretskii
2015-02-23  3:47             ` Dima Kogan
2015-02-23 16:05               ` Michael Albinus
2015-02-23 19:51                 ` Dima Kogan
2015-02-24  8:42                   ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871tll63de.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=18958@debbugs.gnu.org \
    --cc=dima@secretsauce.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.