From: Nicolas Petton <nicolas@petton.fr>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Nicolas Petton <nicolas@petton.fr>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 387e1e1: New version of `seq-let' based on a pcase pattern
Date: Mon, 11 May 2015 23:13:14 +0200 [thread overview]
Message-ID: <871times2d.fsf@petton.fr> (raw)
In-Reply-To: <jwvfv7317sr.fsf-monnier+emacsdiffs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1415 bytes --]
Stefan Monnier writes:
>> Yes. My idea of it was that you bind a sequence like the following:
>> (seq [a b [c d]])
>
> I was thinking of (seq a b (seq c d)).
>
> You could add support for (seq a b [c d]), if you want since that
> currently wouldn't collide with any pcase pattern, tho I'm not sure it's
> worth the added complexity for the user.
>
>> But then how can I have `seq-let' work the way it did until now? For
>> instance:
>> (seq-let [a [b [c]]] my-vector
>> ...)
>
> You expand [a [b [c]]] to (seq a (seq b (seq c))) before passing it to
> pcase-let.
>
>>>> + (push `(app (seq--reverse-args #'seq--nested-elt
>>>> + (reverse (cons ,index ',nested-indexes)))
>>>> + ,name)
>>> This reverse plus seq--reverse-args business seems
>>> hideously inefficient. Why do you need that?
>> because of the way the `app' pattern works. Or maybe I'm missing
>> something?
>
> Why wouldn't
>
> `(app (seq--nested-elt ',(reverse (cons index nested-indexes))) ,name)
>
> work as well? Or, once you get rid of the nested case,
>
> `(app (seq-elt ,index) ,name)
I understand what you meant now. It indeed makes sense, and the pcase
pattern would be much more consistent. I'll push another commit.
Cheers,
Nico
>
>
> -- Stefan
--
Nicolas Petton
http://nicolas-petton.fr
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
next prev parent reply other threads:[~2015-05-11 21:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150510182502.23307.63648@vcs.savannah.gnu.org>
[not found] ` <E1YrVuR-00064X-CK@vcs.savannah.gnu.org>
2015-05-11 4:15 ` [Emacs-diffs] master 387e1e1: New version of `seq-let' based on a pcase pattern Stefan Monnier
2015-05-11 13:42 ` Nicolas Petton
2015-05-11 15:06 ` Stefan Monnier
2015-05-11 21:13 ` Nicolas Petton [this message]
2015-05-11 21:35 ` Nicolas Petton
2015-05-12 1:03 ` Stefan Monnier
2015-05-12 6:51 ` Nicolas Petton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871times2d.fsf@petton.fr \
--to=nicolas@petton.fr \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.