From: Ted Zlatanov <tzz@lifelogs.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: Krzysztof Jurewicz <krzysztof.jurewicz@gmail.com>, 20541@debbugs.gnu.org
Subject: bug#20541: ERC password fetching using Secret Service API is broken
Date: Mon, 29 Jun 2015 22:28:45 -0400 [thread overview]
Message-ID: <871tguj5eq.fsf@lifelogs.com> (raw)
In-Reply-To: <871thvzsw5.fsf@gmx.de> (Michael Albinus's message of "Mon, 01 Jun 2015 11:20:58 +0200")
On Mon, 01 Jun 2015 11:20:58 +0200 Michael Albinus <michael.albinus@gmx.de> wrote:
MA> Krzysztof Jurewicz <krzysztof.jurewicz@gmail.com> writes:
>> One possible patch is attached below. This is the simplest solution; I
>> have not thought much about whether it may be more desirable to convert
>> numbers to strings inside the secrets.el package.
MA> Well, secrets.el expects only strings as attributes. No conversion
MA> foreseen. I don't know what auth-source.el does. If auth-source-search
MA> also allows only strings (and symbol names) as attributes, then your
MA> patch is right. Otherwise, if a :port attribute could also be an
MA> integer, it shall be transformed to a string.
Sorry for the late reply.
The docs of `auth-source-search' say:
A string value is always matched literally. A symbol is matched
as its string value, literally. All the SPEC values can be
single values (symbol or string) or lists thereof (in which case
any of the search terms matches).
...so numbers are not allowed. By design, that means that "80" and
"http" can be used for :port, for instance. IIRC there was no gain from
making any of the search criteria take numbers in the case of
auth-source.el specifically.
So I think the patch is OK :)
Ted
next prev parent reply other threads:[~2015-06-30 2:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-10 14:13 bug#20541: ERC password fetching using Secret Service API is broken Krzysztof Jurewicz
2015-06-01 9:20 ` Michael Albinus
2015-06-30 2:28 ` Ted Zlatanov [this message]
2015-12-27 8:05 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871tguj5eq.fsf@lifelogs.com \
--to=tzz@lifelogs.com \
--cc=20541@debbugs.gnu.org \
--cc=krzysztof.jurewicz@gmail.com \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.